From: Hector Martin <marcan@marcan.st> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier <maz@kernel.org>, Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@kernel.org>, Olof Johansson <olof@lixom.net>, Mark Kettenis <mark.kettenis@xs4all.nl>, Tony Lindgren <tony@atomide.com>, Mohamed Mediouni <mohamed.mediouni@caramail.com>, Stan Skowronek <stan@corellium.com>, Alexander Graf <graf@amazon.com>, Will Deacon <will@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs Date: Thu, 18 Feb 2021 23:16:40 +0900 [thread overview] Message-ID: <f08f4346-e6fd-1487-9b15-f879de4bc59a@marcan.st> (raw) In-Reply-To: <20210215191309.k7qkak73usqj7jxp@kozik-lap> On 16/02/2021 04.13, Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:10PM +0900, Hector Martin wrote: >> @@ -389,10 +396,12 @@ static void enable_tx_pio(struct s3c24xx_uart_port *ourport) >> ucon = rd_regl(port, S3C2410_UCON); >> ucon &= ~(S3C64XX_UCON_TXMODE_MASK); >> ucon |= S3C64XX_UCON_TXMODE_CPU; >> - wr_regl(port, S3C2410_UCON, ucon); >> >> /* Unmask Tx interrupt */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: >> + ucon |= APPLE_S5L_UCON_TXTHRESH_ENA_MSK; >> + break; >> case TYPE_S3C6400: >> s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, S3C64XX_UINTM); >> break; >> @@ -401,7 +410,16 @@ static void enable_tx_pio(struct s3c24xx_uart_port *ourport) >> break; >> } >> >> + wr_regl(port, S3C2410_UCON, ucon); > > You are now configuring the PIO mode after unmasking interrupt. I don't > think it's a good idea to change the order... and if it were, it > would deserve a separate patch. For v3 I moved the wr_regl back and just write it again in the TYPE_APPLE_S5L branch; that way, setting the PIO mode and unmasking the interrupt are two discrete operations on S5L, like they are on other types. >> /* Keep all interrupts masked and cleared */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: { > > Usually you put TYPE_APPLE at the end of switch, so please keep it > consistent. Can be first or last - just everywhere the same, unless you > have a fall-through on purpose. Good point, thanks, moved it for v3. It was actually inconsistent in more places, I made all the orders the same (the enum order, and default: always goes at the end). >> @@ -2179,6 +2329,32 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) >> if (port) { >> /* restore IRQ mask */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: { >> + unsigned int ucon; >> + >> + clk_prepare_enable(ourport->clk); >> + if (!IS_ERR(ourport->baudclk)) >> + clk_prepare_enable(ourport->baudclk); > > We should start checking the return values of clk operations. I know > that existing code does it only in few places, so basically you are not > making it worse... Added error checking for these for v3, thanks. >> +#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)&s5l_serial_drv_data) >> +#else >> +#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) >> +#endif >> + >> + > > Only one line break. Fixed in v3. Thank you for the reviews! -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub
WARNING: multiple messages have this Message-ID (diff)
From: Hector Martin <marcan@marcan.st> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, Arnd Bergmann <arnd@kernel.org>, Rob Herring <robh@kernel.org>, Tony Lindgren <tony@atomide.com>, Marc Zyngier <maz@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf <graf@amazon.com>, Olof Johansson <olof@lixom.net>, Mohamed Mediouni <mohamed.mediouni@caramail.com>, Stan Skowronek <stan@corellium.com>, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Mark Kettenis <mark.kettenis@xs4all.nl> Subject: Re: [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs Date: Thu, 18 Feb 2021 23:16:40 +0900 [thread overview] Message-ID: <f08f4346-e6fd-1487-9b15-f879de4bc59a@marcan.st> (raw) In-Reply-To: <20210215191309.k7qkak73usqj7jxp@kozik-lap> On 16/02/2021 04.13, Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:10PM +0900, Hector Martin wrote: >> @@ -389,10 +396,12 @@ static void enable_tx_pio(struct s3c24xx_uart_port *ourport) >> ucon = rd_regl(port, S3C2410_UCON); >> ucon &= ~(S3C64XX_UCON_TXMODE_MASK); >> ucon |= S3C64XX_UCON_TXMODE_CPU; >> - wr_regl(port, S3C2410_UCON, ucon); >> >> /* Unmask Tx interrupt */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: >> + ucon |= APPLE_S5L_UCON_TXTHRESH_ENA_MSK; >> + break; >> case TYPE_S3C6400: >> s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, S3C64XX_UINTM); >> break; >> @@ -401,7 +410,16 @@ static void enable_tx_pio(struct s3c24xx_uart_port *ourport) >> break; >> } >> >> + wr_regl(port, S3C2410_UCON, ucon); > > You are now configuring the PIO mode after unmasking interrupt. I don't > think it's a good idea to change the order... and if it were, it > would deserve a separate patch. For v3 I moved the wr_regl back and just write it again in the TYPE_APPLE_S5L branch; that way, setting the PIO mode and unmasking the interrupt are two discrete operations on S5L, like they are on other types. >> /* Keep all interrupts masked and cleared */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: { > > Usually you put TYPE_APPLE at the end of switch, so please keep it > consistent. Can be first or last - just everywhere the same, unless you > have a fall-through on purpose. Good point, thanks, moved it for v3. It was actually inconsistent in more places, I made all the orders the same (the enum order, and default: always goes at the end). >> @@ -2179,6 +2329,32 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) >> if (port) { >> /* restore IRQ mask */ >> switch (ourport->info->type) { >> + case TYPE_APPLE_S5L: { >> + unsigned int ucon; >> + >> + clk_prepare_enable(ourport->clk); >> + if (!IS_ERR(ourport->baudclk)) >> + clk_prepare_enable(ourport->baudclk); > > We should start checking the return values of clk operations. I know > that existing code does it only in few places, so basically you are not > making it worse... Added error checking for these for v3, thanks. >> +#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)&s5l_serial_drv_data) >> +#else >> +#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) >> +#endif >> + >> + > > Only one line break. Fixed in v3. Thank you for the reviews! -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-18 17:05 UTC|newest] Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-15 12:16 [PATCH v2 00/25] Apple M1 SoC platform bring-up Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 01/25] dt-bindings: vendor-prefixes: Add apple prefix Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 17:44 ` Krzysztof Kozlowski 2021-02-15 17:44 ` Krzysztof Kozlowski 2021-03-02 8:21 ` Linus Walleij 2021-03-02 8:21 ` Linus Walleij 2021-02-15 12:16 ` [PATCH v2 02/25] dt-bindings: arm: apple: Add bindings for Apple ARM platforms Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 17:48 ` Krzysztof Kozlowski 2021-02-15 17:48 ` Krzysztof Kozlowski 2021-02-16 14:30 ` Hector Martin 2021-02-16 14:30 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 03/25] dt-bindings: arm: cpus: Add apple,firestorm & icestorm compatibles Hector Martin 2021-02-15 12:16 ` [PATCH v2 03/25] dt-bindings: arm: cpus: Add apple, firestorm " Hector Martin 2021-02-15 12:16 ` [PATCH v2 04/25] arm64: cputype: Add CPU implementor & types for the Apple M1 cores Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 05/25] dt-bindings: timer: arm,arch_timer: Add interrupt-names support Hector Martin 2021-02-15 12:16 ` [PATCH v2 05/25] dt-bindings: timer: arm, arch_timer: " Hector Martin 2021-02-15 12:16 ` [PATCH v2 06/25] arm64: arch_timer: implement support for interrupt-names Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 13:28 ` Marc Zyngier 2021-02-15 13:28 ` Marc Zyngier 2021-02-15 15:13 ` Hector Martin 2021-02-15 15:13 ` Hector Martin 2021-02-15 18:23 ` Tony Lindgren 2021-02-15 18:23 ` Tony Lindgren 2021-02-16 14:33 ` Hector Martin 2021-02-16 14:33 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 07/25] arm64: cpufeature: Add a feature for FIQ support Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 08/25] arm64: Always keep DAIF.[IF] in sync Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-17 12:22 ` Mark Rutland 2021-02-17 12:22 ` Mark Rutland 2021-02-18 12:51 ` Hector Martin 2021-02-18 12:51 ` Hector Martin 2021-02-18 14:22 ` Mark Rutland 2021-02-18 14:22 ` Mark Rutland 2021-02-18 14:42 ` Hector Martin 2021-02-18 14:42 ` Hector Martin 2021-02-18 15:26 ` Mark Rutland 2021-02-18 15:26 ` Mark Rutland 2021-02-15 12:16 ` [PATCH v2 09/25] arm64: entry: Map the FIQ vector to IRQ on NEEDS_FIQ platforms Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-17 11:49 ` Mark Rutland 2021-02-17 11:49 ` Mark Rutland 2021-02-17 14:38 ` Marc Zyngier 2021-02-17 14:38 ` Marc Zyngier 2021-02-15 12:16 ` [PATCH v2 10/25] asm-generic/io.h: Add a non-posted variant of ioremap() Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 15:27 ` kernel test robot 2021-02-15 15:27 ` kernel test robot 2021-02-15 16:47 ` Hector Martin 2021-02-16 10:53 ` Christoph Hellwig 2021-02-16 10:53 ` Christoph Hellwig 2021-02-18 13:08 ` Hector Martin 2021-02-18 13:08 ` Hector Martin 2021-02-15 12:16 ` [PATCH v2 11/25] arm64: Implement ioremap_np() to map MMIO as nGnRnE Hector Martin 2021-02-15 12:16 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 12/25] of/address: Add infrastructure to declare MMIO as non-posted Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 13/25] arm64: Add Apple vendor-specific system registers Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 14/25] dt-bindings: interrupt-controller: Add DT bindings for apple-aic Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-16 9:41 ` Arnd Bergmann 2021-02-16 9:41 ` Arnd Bergmann 2021-02-16 11:00 ` Mark Kettenis 2021-02-16 11:00 ` Mark Kettenis 2021-02-16 11:21 ` Arnd Bergmann 2021-02-16 11:21 ` Arnd Bergmann 2021-02-16 11:45 ` Marc Zyngier 2021-02-16 11:45 ` Marc Zyngier 2021-03-02 8:47 ` Linus Walleij 2021-03-02 8:47 ` Linus Walleij 2021-02-15 12:17 ` [PATCH v2 15/25] irqchip/apple-aic: Add support for the Apple Interrupt Controller Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 18:09 ` Marc Zyngier 2021-02-15 18:09 ` Marc Zyngier 2021-02-22 19:35 ` Hector Martin 2021-02-22 19:35 ` Hector Martin 2021-02-23 17:37 ` Marc Zyngier 2021-02-23 17:37 ` Marc Zyngier 2021-02-15 12:17 ` [PATCH v2 16/25] arm64: Kconfig: Introduce CONFIG_ARCH_APPLE Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 18:06 ` Krzysztof Kozlowski 2021-02-15 18:06 ` Krzysztof Kozlowski 2021-02-18 13:24 ` Hector Martin 2021-02-18 13:24 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 18:26 ` Krzysztof Kozlowski 2021-02-15 18:26 ` Krzysztof Kozlowski 2021-02-18 13:37 ` Hector Martin 2021-02-18 13:37 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 18:40 ` Krzysztof Kozlowski 2021-02-15 18:40 ` Krzysztof Kozlowski 2021-02-18 13:53 ` Hector Martin 2021-02-18 13:53 ` Hector Martin 2021-02-20 19:11 ` Krzysztof Kozlowski 2021-02-20 19:11 ` Krzysztof Kozlowski 2021-02-21 13:43 ` Hector Martin 2021-02-21 13:43 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 18:51 ` Krzysztof Kozlowski 2021-02-15 18:51 ` Krzysztof Kozlowski 2021-02-18 14:01 ` Hector Martin 2021-02-18 14:01 ` Hector Martin 2021-02-20 19:13 ` Krzysztof Kozlowski 2021-02-20 19:13 ` Krzysztof Kozlowski 2021-02-20 19:17 ` Marc Zyngier 2021-02-20 19:17 ` Marc Zyngier 2021-02-21 14:38 ` Hector Martin 2021-02-21 14:38 ` Hector Martin 2021-02-21 14:59 ` Marc Zyngier 2021-02-21 14:59 ` Marc Zyngier 2021-02-21 17:09 ` Hector Martin 2021-02-21 17:09 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 21/25] dt-bindings: serial: samsung: Add apple,s5l-uart compatible Hector Martin 2021-02-15 12:17 ` [PATCH v2 21/25] dt-bindings: serial: samsung: Add apple, s5l-uart compatible Hector Martin 2021-02-15 18:53 ` [PATCH v2 21/25] dt-bindings: serial: samsung: Add apple,s5l-uart compatible Krzysztof Kozlowski 2021-02-15 18:53 ` Krzysztof Kozlowski 2021-03-02 8:31 ` Linus Walleij 2021-03-02 8:31 ` [PATCH v2 21/25] dt-bindings: serial: samsung: Add apple, s5l-uart compatible Linus Walleij 2021-02-15 12:17 ` [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 19:13 ` Krzysztof Kozlowski 2021-02-15 19:13 ` Krzysztof Kozlowski 2021-02-18 14:16 ` Hector Martin [this message] 2021-02-18 14:16 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon " Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 19:17 ` Krzysztof Kozlowski 2021-02-15 19:17 ` Krzysztof Kozlowski 2021-02-16 10:18 ` Arnd Bergmann 2021-02-16 10:18 ` Arnd Bergmann 2021-02-16 10:20 ` Krzysztof Kozlowski 2021-02-16 10:20 ` Krzysztof Kozlowski 2021-02-16 10:29 ` Arnd Bergmann 2021-02-16 10:29 ` Arnd Bergmann 2021-02-16 10:50 ` Hector Martin 2021-02-16 10:50 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 24/25] dt-bindings: display: Add apple,simple-framebuffer Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 12:17 ` [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree Hector Martin 2021-02-15 12:17 ` Hector Martin 2021-02-15 19:29 ` Krzysztof Kozlowski 2021-02-15 19:29 ` Krzysztof Kozlowski 2021-02-15 21:00 ` Randy Dunlap 2021-02-15 21:00 ` Randy Dunlap 2021-02-16 7:31 ` Krzysztof Kozlowski 2021-02-16 7:31 ` Krzysztof Kozlowski 2021-02-21 14:43 ` Hector Martin 2021-02-21 14:43 ` Hector Martin 2021-02-21 15:32 ` Krzysztof Kozlowski 2021-02-21 15:32 ` Krzysztof Kozlowski 2021-02-15 12:57 ` [PATCH v2 00/25] Apple M1 SoC platform bring-up Arnd Bergmann 2021-02-15 12:57 ` Arnd Bergmann 2021-02-15 13:22 ` gregkh 2021-02-15 13:22 ` gregkh 2021-02-15 15:57 ` Hector Martin 2021-02-15 15:57 ` Hector Martin 2021-02-15 16:12 ` gregkh 2021-02-15 16:12 ` gregkh 2021-02-15 16:54 ` Hector Martin 2021-02-15 16:54 ` Hector Martin 2021-02-15 17:43 ` Krzysztof Kozlowski 2021-02-15 17:43 ` Krzysztof Kozlowski 2021-02-15 19:11 ` Marc Zyngier 2021-02-15 19:11 ` Marc Zyngier [not found] ` <CAHp75Vd2ObiUJFn-kVWBx+E30my9zXVX5iUtsyRb_c4FcZEDOA@mail.gmail.com> 2021-02-23 9:11 ` Hector Martin 2021-02-23 9:11 ` Hector Martin 2021-02-18 14:36 ` Mark Rutland 2021-02-18 14:36 ` Mark Rutland 2021-02-21 15:20 ` Hector Martin 2021-02-21 15:20 ` Hector Martin 2021-02-24 15:55 ` Hector Martin 2021-02-24 15:55 ` Hector Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f08f4346-e6fd-1487-9b15-f879de4bc59a@marcan.st \ --to=marcan@marcan.st \ --cc=arnd@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=graf@amazon.com \ --cc=krzk@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.kettenis@xs4all.nl \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=mohamed.mediouni@caramail.com \ --cc=olof@lixom.net \ --cc=robh@kernel.org \ --cc=stan@corellium.com \ --cc=tony@atomide.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.