From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Munoz Subject: Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus Date: Thu, 28 Jun 2018 14:20:05 -0700 Message-ID: References: <1530134719-19407-1-git-send-email-steven.hill@cavium.com> <1530134719-19407-4-git-send-email-steven.hill@cavium.com> <20180628084156.GF16727@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "Steven J. Hill" , netdev@vger.kernel.org, Chandrakala Chavva To: Andrew Lunn Return-path: Received: from mail-bl2nam02on0087.outbound.protection.outlook.com ([104.47.38.87]:28387 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752547AbeF1VUL (ORCPT ); Thu, 28 Jun 2018 17:20:11 -0400 In-Reply-To: <20180628084156.GF16727@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/28/2018 01:41 AM, Andrew Lunn wrote: > External Email > >> +static char *mix_port; >> +module_param(mix_port, charp, 0444); >> +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX interfaces."); >> + >> +static char *pki_port; >> +module_param(pki_port, charp, 0444); >> +MODULE_PARM_DESC(pki_port, "Specifies which ports connect to the PKI."); > Module parameters are generally not liked. Can you do without them? These parameters change the kernel port assignment required by user space applications. We rather keep them as they simplify the process. > >> + /* One time request driver module */ >> + if (is_mix) { >> + if (atomic_cmpxchg(&request_mgmt_once, 0, 1) == 0) >> + request_module_nowait("octeon_mgmt"); > Why is this needed? So long as the driver has the needed properties, > udev should load the module. > > Andrew The thing is the management module is only loaded when a port is assigned to it (determined by the above module parameter "mix_port"). Best regards, Carlos