From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AAEC4338F for ; Tue, 24 Aug 2021 12:48:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A6016127B for ; Tue, 24 Aug 2021 12:48:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A6016127B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.171322.312626 (Exim 4.92) (envelope-from ) id 1mIVqn-0001tw-Tu; Tue, 24 Aug 2021 12:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 171322.312626; Tue, 24 Aug 2021 12:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIVqn-0001tp-R4; Tue, 24 Aug 2021 12:48:21 +0000 Received: by outflank-mailman (input) for mailman id 171322; Tue, 24 Aug 2021 12:48:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIVqm-0001tZ-8L for xen-devel@lists.xenproject.org; Tue, 24 Aug 2021 12:48:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIVqf-0003JD-Il; Tue, 24 Aug 2021 12:48:13 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mIVqf-000664-Cj; Tue, 24 Aug 2021 12:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=cnEuulBrOIjQKZLoOdzkzpcx19I/WHPHq0paK0dDiKk=; b=Jh5hzLSqjKJR8DDYAFKt4ND4pE u7CMNX0KWIf5dMk0ARxz8OM1sSlAlMt078flxBzyuaXYyprf36dqNI7qs5hqWwdavObxLBl/sofus gWAAG51EMX6MIMCxrnkyHOaUUCnD3Gqc+4XTaC9ugNd5gO+TthBQMROqBLoHJUXmRxRs=; Subject: Re: [PATCH v3 6/6] x86: change asm/debugger.h to xen/debugger.h To: Bobby Eshleman , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Elena Ufimtseva , Jun Nakajima , Kevin Tian , George Dunlap , Ian Jackson References: From: Julien Grall Message-ID: Date: Tue, 24 Aug 2021 13:48:10 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 18/08/2021 21:29, Bobby Eshleman wrote: > This commit allows non-x86 architecture to omit the file asm/debugger.h > if they do not require it. It changes debugger.h to be a general > xen/debugger.h which, if CONFIG_CRASH_DEBUG, resolves to include > asm/debugger.h. > > It also changes all asm/debugger.h includes to xen/debugger.h. > > Because it is no longer required, arm/debugger.h is removed. > > Signed-off-by: Bobby Eshleman > --- > Changes in v3: > - No longer introduces a fake TRAP_invalid_op for arm to consume, it > is not necessary given the removal of the arm calls now precedes > this patch. > - Instead of defining prototypes that arch/ is expected to implement, > this version simply #includes when CONFIG_CRASH_DEBUG. > > xen/arch/x86/traps.c | 2 +- > xen/common/domain.c | 2 +- > xen/common/gdbstub.c | 2 +- > xen/common/keyhandler.c | 2 +- > xen/common/shutdown.c | 2 +- > xen/drivers/char/console.c | 2 +- > xen/include/asm-arm/debugger.h | 15 ---------- For the Arm bits: Acked-by: Julien Grall Cheers, -- Julien Grall