Re: [PATCH 1/3] thermal: qcom: lmh: Add support for sm8150

From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Thara Gopinath <thara.gopinath@linaro.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	daniel.lezcano@linaro.org, rafael@kernel.org,
	rui.zhang@intel.com, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] thermal: qcom: lmh: Add support for sm8150
Date: Sat, 4 Dec 2021 14:34:40 +0100	[thread overview]
Message-ID: <f0ae3d36-8317-b297-cc99-645adca1f25c@somainline.org> (raw)
In-Reply-To: <20211202223802.382068-2-thara.gopinath@linaro.org>

Hi,

On 02.12.2021 23:38, Thara Gopinath wrote:
> Add compatible to support LMh for sm8150 SoC.
> sm8150 does not require explicit enabling for various LMh subsystems.
> Move this piece of code under condition that it is executed only
> for sdm845 SoC.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
>  drivers/thermal/qcom/lmh.c | 61 ++++++++++++++++++++------------------
>  1 file changed, 32 insertions(+), 29 deletions(-)

[...]

> -		return ret;
> +	if (of_device_is_compatible(np, "qcom,sdm845-lmh")) {
> +		if (!qcom_scm_lmh_dcvsh_available())
> +			return -EINVAL;

I don't believe this is the correct approach, as different SoCs may

require different sequences of these writes (for example SDM660/MSM8998

seems to only enable the thermal algorithm), and there will (hopefully) be interest

in adding LMH support for more platforms, so perhaps separating this somehow

could keep this a bit cleaner and easier to work with for the next person..

Konrad