From: Jens Axboe <axboe@kernel.dk>
To: Pankaj Raghav <pankydev8@gmail.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v3] block: only check previous entry for plug merge attempt
Date: Sat, 16 Oct 2021 16:13:46 -0600 [thread overview]
Message-ID: <f0c566bf-dd0c-0cf9-ff10-37d678898e15@kernel.dk> (raw)
In-Reply-To: <20211015141839.hlc4zjtvdpl75o2a@quentin>
On 10/15/21 8:18 AM, Pankaj Raghav wrote:
> On Thu, Oct 14, 2021 at 12:34:21PM -0600, Jens Axboe wrote:
>> diff --git a/block/blk-merge.c b/block/blk-merge.c
>> index f390a8753268..575080ad0617 100644
>> --- a/block/blk-merge.c
>> +++ b/block/blk-merge.c
>
> Even though the code is self-documenting, the current description on top
> of this function is now outdated with this change.
>
> - * Determine whether @bio being queued on @q can be merged with a request
> - * on %current's plugged list. Returns %true if merge was successful,
> + * Determine whether @bio being queued on @q can be merged with the previous
> + * request on %current's plugged list. Returns %true if merge was successful,
> * otherwise %false.
Fixed up, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-16 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:34 [PATCH v3] block: only check previous entry for plug merge attempt Jens Axboe
2021-10-15 14:18 ` Pankaj Raghav
2021-10-16 22:13 ` Jens Axboe [this message]
2021-10-16 4:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c566bf-dd0c-0cf9-ff10-37d678898e15@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.