From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96C7C3A5A6 for ; Tue, 27 Aug 2019 12:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5EBA2077B for ; Tue, 27 Aug 2019 12:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566910440; bh=AAvlP0FQ08qZNxkiapbiyn3gUYc4lERuXZdOOramFIA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=I0dNHnLmCnNTdE4RDG2yQtYAps+JBbjzUvAg6iY6DARZ5bv3TUUrDetVRltAB54K6 soK0jPAFc7kCUp7rbAvuyaII31ckHiNeim4pjxSkmG14SNIvgGq9HHuH/SyctphZh4 mBf0lbl8gZBwiZisjSdk44aZpBHbQWQvHqOwP2EA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729773AbfH0MyA (ORCPT ); Tue, 27 Aug 2019 08:54:00 -0400 Received: from foss.arm.com ([217.140.110.172]:44102 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbfH0Mx7 (ORCPT ); Tue, 27 Aug 2019 08:53:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E31528; Tue, 27 Aug 2019 05:53:58 -0700 (PDT) Received: from [10.1.197.61] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 402C93F718; Tue, 27 Aug 2019 05:53:54 -0700 (PDT) Subject: Re: [PATCH 06/13] irqchip: Add driver for Loongson-3 HyperTransport interrupt controller To: Jiaxun Yang , linux-mips@vger.kernel.org Cc: chenhc@lemote.com, paul.burton@mips.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.co, devicetree@vger.kernel.org References: <20190827085302.5197-1-jiaxun.yang@flygoat.com> <20190827085302.5197-7-jiaxun.yang@flygoat.com> From: Marc Zyngier Organization: Approximate Message-ID: Date: Tue, 27 Aug 2019 13:53:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190827085302.5197-7-jiaxun.yang@flygoat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/08/2019 09:52, Jiaxun Yang wrote: > This controller appeared on Loongson-3 family of chips to receive interrupts > from PCH chip. > > Signed-off-by: Jiaxun Yang > --- > drivers/irqchip/Kconfig | 8 ++ > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-ls3-htintc.c | 145 +++++++++++++++++++++++++++++++ > 3 files changed, 154 insertions(+) > create mode 100644 drivers/irqchip/irq-ls3-htintc.c > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 8d9eac5fd4a7..b3ce0f3e43ae 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -480,6 +480,14 @@ config LS3_IOINTC > help > Support for the Loongson-3 I/O Interrupt Controller. > > +config LS3_HTINTC > + bool "Loongson3 HyperTransport Interrupt Controller" > + depends on MACH_LOONGSON64 > + default y > + select IRQ_DOMAIN > + select GENERIC_IRQ_CHIP > + help > + Support for the Loongson-3 HyperTransport Interrupt Controller. > endmenu > > config SIFIVE_PLIC > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index 49ecb8d38138..0fda94c319e9 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -103,3 +103,4 @@ obj-$(CONFIG_LS1X_IRQ) += irq-ls1x.o > obj-$(CONFIG_TI_SCI_INTR_IRQCHIP) += irq-ti-sci-intr.o > obj-$(CONFIG_TI_SCI_INTA_IRQCHIP) += irq-ti-sci-inta.o > obj-$(CONFIG_LS3_IOINTC) += irq-ls3-iointc.o > +obj-$(CONFIG_LS3_HTINTC) += irq-ls3-htintc.o > diff --git a/drivers/irqchip/irq-ls3-htintc.c b/drivers/irqchip/irq-ls3-htintc.c > new file mode 100644 > index 000000000000..c53bbb0bd78c > --- /dev/null > +++ b/drivers/irqchip/irq-ls3-htintc.c > @@ -0,0 +1,145 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019, Jiaxun Yang > + * Loongson-3 HyperTransport IRQ support > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define HTINTC_NUM_GC 4 > +#define HTINTC_GC_SIZE 0x4 > +#define HTINTC_NUM_HANDLER 4 > +#define HTINTC_HANDLER_SIZE 0x8 > +#define HTINTC_HANDLER_IRQ 64 > + > +#define HTINTC_VECTOR_OFFSET 0x0 > +#define HTINTC_EN_OFFSET 0x20 > + > +struct htintc_handler_priv { > + struct irq_domain *domain; > + void __iomem *handler_base; > +}; > + > +static void htintc_chained_handle_irq(struct irq_desc *desc) > +{ > + struct htintc_handler_priv *priv = irq_desc_get_handler_data(desc); > + struct irq_chip *chip = irq_desc_get_chip(desc); > + int i; > + bool handled; > + > + chained_irq_enter(chip, desc); > + > + for (i = 0; i < HTINTC_NUM_GC; i++) { > + uint32_t irqs = readl(priv->handler_base + HTINTC_GC_SIZE * i); > + > + while (irqs) { > + int bit = __ffs(irqs); > + > + generic_handle_irq(irq_find_mapping(priv->domain, bit + 32 * i)); > + irqs &= ~BIT(bit); > + handled = true; > + } > + } > + > + if (!handled) Uninitialized variable. I'm pretty sure your compiler warns about that. > + spurious_interrupt(); > + > + chained_irq_exit(chip, desc); > +} > + > +int __init ls3_htintc_of_init(struct device_node *node, > + struct device_node *parent) > +{ > + struct irq_chip_generic *gc; > + struct irq_chip_type *ct; > + struct htintc_handler_priv *priv; > + struct irq_domain *domain; > + void __iomem *base; > + int parent_irq[HTINTC_NUM_HANDLER], err = 0; > + int i; > + > + Spurious empty line. > + priv = kzalloc(sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + base = of_iomap(node, 0); > + if (!base) { > + err = -ENODEV; > + goto out_free_priv; > + } > + > + for (i = 0; i < HTINTC_NUM_HANDLER; i++) { > + parent_irq[i] = irq_of_parse_and_map(node, i); > + if (!parent_irq[i]) { > + pr_err("ls3-htintc: unable to get parent irq %d\n", i); > + err = -ENODEV; > + goto out_iounmap; > + } > + } > + /* Set up an IRQ domain */ > + domain = irq_domain_add_linear(node, 32 * HTINTC_NUM_GC, > + &irq_generic_chip_ops, NULL); Please align the second line on the opening bracket from the previous line. > + if (!domain) { > + pr_err("ls3-htintc: cannot add IRQ domain\n"); > + err = -ENOMEM; > + goto out_iounmap; > + } > + > + for (i = 0; i < HTINTC_NUM_HANDLER; i++) { > + /* Mask all interrupts */ > + writeq(0x0, base + HTINTC_EN_OFFSET + HTINTC_HANDLER_SIZE * i); > + } > + > + err = irq_alloc_domain_generic_chips(domain, 32, 1, > + node->full_name, handle_fasteoi_irq, handle_fast_eoi? Where is your irq_eoi callback? That looks wrong given that you're using a mask/ack/unmask sequence. > + IRQ_NOPROBE, 0, IRQ_GC_INIT_MASK_CACHE); > + if (err) { > + pr_err("ls3-htintc: unable to register IRQ domain\n"); > + err = -ENOMEM; > + goto out_free_domain; > + } > + > + for (i = 0; i < HTINTC_NUM_GC; i++) { > + gc = irq_get_domain_generic_chip(domain, i * 32); > + gc->reg_base = base + HTINTC_GC_SIZE * i; > + gc->domain = domain; > + > + ct = gc->chip_types; > + ct->regs.mask = HTINTC_EN_OFFSET; > + ct->regs.ack = HTINTC_VECTOR_OFFSET; > + ct->chip.irq_unmask = irq_gc_mask_set_bit; > + ct->chip.irq_mask = irq_gc_mask_clr_bit; > + ct->chip.irq_ack = irq_gc_ack_set_bit; > + } > + > + priv->domain = domain; > + priv->handler_base = base + HTINTC_VECTOR_OFFSET; > + > + for (i = 0; i < HTINTC_NUM_HANDLER; i++) { > + irq_set_chained_handler_and_data(parent_irq[i], > + htintc_chained_handle_irq, priv); > + } > + > + return 0; > + > +out_free_domain: > + irq_domain_remove(domain); > +out_iounmap: > + iounmap(base); > +out_free_priv: > + kfree(priv); > + > + return err; > +} > + > +IRQCHIP_DECLARE(ls3_htintc, "loongson,ls3-htintc", ls3_htintc_of_init); > M. -- Jazz is not dead, it just smells funny...