From: Chao Yu <chao@kernel.org>
To: Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
Yue Hu <zbestahu@gmail.com>,
Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: Re: [PATCH v2 3/3] erofs: introduce readmore decompression strategy
Date: Tue, 19 Oct 2021 20:58:49 +0800 [thread overview]
Message-ID: <f0d5ccd4-56c0-5212-dc13-fccff9d36e5d@kernel.org> (raw)
In-Reply-To: <20211017154253.GB4054@hsiangkao-HP-ZHAN-66-Pro-G1>
On 2021/10/17 23:42, Gao Xiang wrote:
> On Sun, Oct 17, 2021 at 11:34:22PM +0800, Chao Yu wrote:
>> On 2021/10/9 4:08, Gao Xiang wrote:
>>> From: Gao Xiang <hsiangkao@linux.alibaba.com>
>>>
>>> Previously, the readahead window was strictly followed by EROFS
>>> decompression strategy in order to minimize extra memory footprint.
>>> However, it could become inefficient if just reading the partial
>>> requested data for much big LZ4 pclusters and the upcoming LZMA
>>> implementation.
>>>
>>> Let's try to request the leading data in a pcluster without
>>> triggering memory reclaiming instead for the LZ4 approach first
>>> to boost up 100% randread of large big pclusters, and it has no real
>>> impact on low memory scenarios.
>>>
>>> It also introduces a way to expand read lengths in order to decompress
>>> the whole pcluster, which is useful for LZMA since the algorithm
>>> itself is relatively slow and causes CPU bound, but LZ4 is not.
>>>
>>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Looks fine to me now.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2021-10-19 12:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 20:08 [PATCH v2 0/3] erofs: some decompression improvements Gao Xiang
2021-10-08 20:08 ` Gao Xiang
2021-10-08 20:08 ` [PATCH v2 1/3] erofs: get compression algorithms directly on mapping Gao Xiang
2021-10-08 20:08 ` Gao Xiang
2021-10-09 1:52 ` Yue Hu
2021-10-09 1:52 ` Yue Hu
2021-10-17 15:25 ` Chao Yu
2021-10-17 15:25 ` Chao Yu
2021-10-08 20:08 ` [PATCH v2 2/3] erofs: introduce the secondary compression head Gao Xiang
2021-10-08 20:08 ` Gao Xiang
2021-10-09 3:50 ` Yue Hu
2021-10-09 3:50 ` Yue Hu
2021-10-09 4:47 ` Gao Xiang
2021-10-09 4:47 ` Gao Xiang
2021-10-09 18:12 ` [PATCH v3 " Gao Xiang
2021-10-09 18:12 ` Gao Xiang
2021-10-10 0:53 ` Yue Hu
2021-10-10 0:53 ` Yue Hu
2021-10-17 15:27 ` Chao Yu
2021-10-17 15:27 ` Chao Yu
2021-10-17 15:32 ` Gao Xiang
2021-10-17 15:32 ` Gao Xiang
2021-10-17 16:57 ` [PATCH v4 " Gao Xiang
2021-10-17 16:57 ` Gao Xiang
2021-10-19 12:56 ` Chao Yu
2021-10-19 12:56 ` Chao Yu
2021-10-08 20:08 ` [PATCH v2 3/3] erofs: introduce readmore decompression strategy Gao Xiang
2021-10-08 20:08 ` Gao Xiang
2021-10-17 15:34 ` Chao Yu
2021-10-17 15:34 ` Chao Yu
2021-10-17 15:42 ` Gao Xiang
2021-10-17 15:42 ` Gao Xiang
2021-10-19 12:58 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d5ccd4-56c0-5212-dc13-fccff9d36e5d@kernel.org \
--to=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.