From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CDFC433F5 for ; Wed, 19 Jan 2022 12:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350702AbiASM6D (ORCPT ); Wed, 19 Jan 2022 07:58:03 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:17354 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232897AbiASM6C (ORCPT ); Wed, 19 Jan 2022 07:58:02 -0500 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Jf5Hx5S6gz9s5T; Wed, 19 Jan 2022 20:56:45 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:59 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:58 +0800 Message-ID: Date: Wed, 19 Jan 2022 20:57:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/3] mm: vmalloc: Let user to control huge vmalloc default behavior Content-Language: en-US To: Nicholas Piggin , Andrew Morton , Jonathan Corbet , , , , , , CC: Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , "Michael Ellerman" , Paul Mackerras , "Thomas Gleixner" , Will Deacon , Matthew Wilcox References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-2-wangkefeng.wang@huawei.com> <1642473992.qrnqczjfna.astroid@bobo.none> From: Kefeng Wang In-Reply-To: <1642473992.qrnqczjfna.astroid@bobo.none> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme714-chm.china.huawei.com (10.1.199.110) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/1/18 10:52, Nicholas Piggin wrote: > Excerpts from Kefeng Wang's message of December 28, 2021 12:59 am: >> Introduce HUGE_VMALLOC_DEFAULT_ENABLED and make it default y, this >> let user to choose whether or not enable huge vmalloc mappings by >> default. >> >> Meanwhile, add new hugevmalloc=on/off parameter to enable or disable >> this feature at boot time, nohugevmalloc is still supported and >> equivalent to hugevmalloc=off. > Runtime options are bad enough, Kconfig and boot options are even worse. nohugevmalloc is like blacklists, on the other hand, Add a HUGE_VMALLOC_DEFAULT_ENABLED to close hugevmalloc default and enable it only via hugevmalloc=on is whiteList. Only parts of our products wants this feature,  we add some interfaces which only alloc hugevmalloc for them, eg, vmap_hugepage/vmalloc_hugepage/remap_vmalloc_hugepage_range.. for our products, but it's not the choice of most products, also add nohugevmalloc for most products is expensive, so this is the reason for adding the patch. more config/cmdline are more flexible for test/products， > > The 'nohugevmalloc' option mirrors 'nohugeiomap' and is not expected to > ever be understood by an administrator unless a kernel developer is > working with them to hunt down a regression. > > IMO there should be no new options. You could switch it off for > CONFIG_BASE_SMALL perhaps, and otherwise just try to work on heuristics > first. Bring in new options once it's proven they're needed. but yes, this patch is optional， could others give some more comments about this way？ Thanks. > Aside from that, thanks for working on these ports, great work. > > Thanks, > Nick > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B954DC433F5 for ; Wed, 19 Jan 2022 12:58:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jf5L800Zbz3cG3 for ; Wed, 19 Jan 2022 23:58:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.188; helo=szxga02-in.huawei.com; envelope-from=wangkefeng.wang@huawei.com; receiver=) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jf5KZ417tz2yQH for ; Wed, 19 Jan 2022 23:58:06 +1100 (AEDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Jf5Hx5S6gz9s5T; Wed, 19 Jan 2022 20:56:45 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:59 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:58 +0800 Message-ID: Date: Wed, 19 Jan 2022 20:57:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/3] mm: vmalloc: Let user to control huge vmalloc default behavior Content-Language: en-US To: Nicholas Piggin , Andrew Morton , Jonathan Corbet , , , , , , References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-2-wangkefeng.wang@huawei.com> <1642473992.qrnqczjfna.astroid@bobo.none> From: Kefeng Wang In-Reply-To: <1642473992.qrnqczjfna.astroid@bobo.none> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme714-chm.china.huawei.com (10.1.199.110) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Wilcox , Catalin Marinas , Dave Hansen , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Paul Mackerras , Thomas Gleixner , Will Deacon Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2022/1/18 10:52, Nicholas Piggin wrote: > Excerpts from Kefeng Wang's message of December 28, 2021 12:59 am: >> Introduce HUGE_VMALLOC_DEFAULT_ENABLED and make it default y, this >> let user to choose whether or not enable huge vmalloc mappings by >> default. >> >> Meanwhile, add new hugevmalloc=on/off parameter to enable or disable >> this feature at boot time, nohugevmalloc is still supported and >> equivalent to hugevmalloc=off. > Runtime options are bad enough, Kconfig and boot options are even worse. nohugevmalloc is like blacklists, on the other hand, Add a HUGE_VMALLOC_DEFAULT_ENABLED to close hugevmalloc default and enable it only via hugevmalloc=on is whiteList. Only parts of our products wants this feature,  we add some interfaces which only alloc hugevmalloc for them, eg, vmap_hugepage/vmalloc_hugepage/remap_vmalloc_hugepage_range.. for our products, but it's not the choice of most products, also add nohugevmalloc for most products is expensive, so this is the reason for adding the patch. more config/cmdline are more flexible for test/products， > > The 'nohugevmalloc' option mirrors 'nohugeiomap' and is not expected to > ever be understood by an administrator unless a kernel developer is > working with them to hunt down a regression. > > IMO there should be no new options. You could switch it off for > CONFIG_BASE_SMALL perhaps, and otherwise just try to work on heuristics > first. Bring in new options once it's proven they're needed. but yes, this patch is optional， could others give some more comments about this way？ Thanks. > Aside from that, thanks for working on these ports, great work. > > Thanks, > Nick > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0BF7C433F5 for ; Wed, 19 Jan 2022 12:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ahaMFVbJFx5DGGMpAExvuU8tW69cntDcLL7BDN+Zhc=; b=LHh3WLHJGC5D9i Qzw3b5F4mB9i5xpRwB23pCHUqNDkMSHzrM78ice1EiQ0xT8ZX4/vVwI2cxkYPQrzhWkOLPgLAojgi WfeyXfcFQQymhHJqPiphB9g+5OTbesCBOerX1fL6DZnxd5F2NL4EaV0PjMl8ocKulqoMcbCIR/znu TkkEJT4ZmNwEzTjNMitRw1n/J8Xm3OP0YTciy5Lw+Z5pBj5mnwKesOwV5X0WtwOBe+7He+N9bJG97 ZzSrnQCh6fF/bUomCjJHqLbXKXbX+zy/0PTdUzt/4XyXlGG9ljLm/qrCc+YykAaylEDnNg4/rb2vb DfsVPCui4bwBlEDsDKBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAAXW-005Wqi-E1; Wed, 19 Jan 2022 12:58:14 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAAXR-005WmL-UC for linux-arm-kernel@lists.infradead.org; Wed, 19 Jan 2022 12:58:11 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Jf5Hx5S6gz9s5T; Wed, 19 Jan 2022 20:56:45 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:59 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Wed, 19 Jan 2022 20:57:58 +0800 Message-ID: Date: Wed, 19 Jan 2022 20:57:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/3] mm: vmalloc: Let user to control huge vmalloc default behavior Content-Language: en-US To: Nicholas Piggin , Andrew Morton , Jonathan Corbet , , , , , , CC: Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , "Michael Ellerman" , Paul Mackerras , "Thomas Gleixner" , Will Deacon , Matthew Wilcox References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-2-wangkefeng.wang@huawei.com> <1642473992.qrnqczjfna.astroid@bobo.none> From: Kefeng Wang In-Reply-To: <1642473992.qrnqczjfna.astroid@bobo.none> X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme714-chm.china.huawei.com (10.1.199.110) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_045810_176916_F798FFFC X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjIvMS8xOCAxMDo1MiwgTmljaG9sYXMgUGlnZ2luIHdyb3RlOgo+IEV4Y2VycHRzIGZy b20gS2VmZW5nIFdhbmcncyBtZXNzYWdlIG9mIERlY2VtYmVyIDI4LCAyMDIxIDEyOjU5IGFtOgo+ PiBJbnRyb2R1Y2UgSFVHRV9WTUFMTE9DX0RFRkFVTFRfRU5BQkxFRCBhbmQgbWFrZSBpdCBkZWZh dWx0IHksIHRoaXMKPj4gbGV0IHVzZXIgdG8gY2hvb3NlIHdoZXRoZXIgb3Igbm90IGVuYWJsZSBo dWdlIHZtYWxsb2MgbWFwcGluZ3MgYnkKPj4gZGVmYXVsdC4KPj4KPj4gTWVhbndoaWxlLCBhZGQg bmV3IGh1Z2V2bWFsbG9jPW9uL29mZiBwYXJhbWV0ZXIgdG8gZW5hYmxlIG9yIGRpc2FibGUKPj4g dGhpcyBmZWF0dXJlIGF0IGJvb3QgdGltZSwgbm9odWdldm1hbGxvYyBpcyBzdGlsbCBzdXBwb3J0 ZWQgYW5kCj4+IGVxdWl2YWxlbnQgdG8gaHVnZXZtYWxsb2M9b2ZmLgo+IFJ1bnRpbWUgb3B0aW9u cyBhcmUgYmFkIGVub3VnaCwgS2NvbmZpZyBhbmQgYm9vdCBvcHRpb25zIGFyZSBldmVuIHdvcnNl LgoKbm9odWdldm1hbGxvYyBpcyBsaWtlIGJsYWNrbGlzdHMsIG9uIHRoZSBvdGhlciBoYW5kLCBB ZGQgYSAKSFVHRV9WTUFMTE9DX0RFRkFVTFRfRU5BQkxFRAoKdG8gY2xvc2UgaHVnZXZtYWxsb2Mg ZGVmYXVsdCBhbmQgZW5hYmxlIGl0IG9ubHkgdmlhIGh1Z2V2bWFsbG9jPW9uIGlzIAp3aGl0ZUxp c3QuCgoKT25seSBwYXJ0cyBvZiBvdXIgcHJvZHVjdHMgd2FudHMgdGhpcyBmZWF0dXJlLMKgIHdl IGFkZCBzb21lIGludGVyZmFjZXMgCndoaWNoIG9ubHkKCmFsbG9jIGh1Z2V2bWFsbG9jIGZvciB0 aGVtLCBlZywgCnZtYXBfaHVnZXBhZ2Uvdm1hbGxvY19odWdlcGFnZS9yZW1hcF92bWFsbG9jX2h1 Z2VwYWdlX3JhbmdlLi4KCmZvciBvdXIgcHJvZHVjdHMsIGJ1dCBpdCdzIG5vdCB0aGUgY2hvaWNl IG9mIG1vc3QgcHJvZHVjdHMsIGFsc28gYWRkIApub2h1Z2V2bWFsbG9jCgpmb3IgbW9zdCBwcm9k dWN0cyBpcyBleHBlbnNpdmUsIHNvIHRoaXMgaXMgdGhlIHJlYXNvbiBmb3IgYWRkaW5nIHRoZSBw YXRjaC4KCm1vcmUgY29uZmlnL2NtZGxpbmUgYXJlIG1vcmUgZmxleGlibGUgZm9yIHRlc3QvcHJv ZHVjdHPvvIwKCj4KPiBUaGUgJ25vaHVnZXZtYWxsb2MnIG9wdGlvbiBtaXJyb3JzICdub2h1Z2Vp b21hcCcgYW5kIGlzIG5vdCBleHBlY3RlZCB0bwo+IGV2ZXIgYmUgdW5kZXJzdG9vZCBieSBhbiBh ZG1pbmlzdHJhdG9yIHVubGVzcyBhIGtlcm5lbCBkZXZlbG9wZXIgaXMKPiB3b3JraW5nIHdpdGgg dGhlbSB0byBodW50IGRvd24gYSByZWdyZXNzaW9uLgo+Cj4gSU1PIHRoZXJlIHNob3VsZCBiZSBu byBuZXcgb3B0aW9ucy4gWW91IGNvdWxkIHN3aXRjaCBpdCBvZmYgZm9yCj4gQ09ORklHX0JBU0Vf U01BTEwgcGVyaGFwcywgYW5kIG90aGVyd2lzZSBqdXN0IHRyeSB0byB3b3JrIG9uIGhldXJpc3Rp Y3MKPiBmaXJzdC4gQnJpbmcgaW4gbmV3IG9wdGlvbnMgb25jZSBpdCdzIHByb3ZlbiB0aGV5J3Jl IG5lZWRlZC4KCmJ1dCB5ZXMsIHRoaXMgcGF0Y2ggaXMgb3B0aW9uYWzvvIwgY291bGQgb3RoZXJz IGdpdmUgc29tZSBtb3JlIGNvbW1lbnRzIAphYm91dCB0aGlzIHdhee+8nwoKVGhhbmtzLgoKPiBB c2lkZSBmcm9tIHRoYXQsIHRoYW5rcyBmb3Igd29ya2luZyBvbiB0aGVzZSBwb3J0cywgZ3JlYXQg d29yay4KPgo+IFRoYW5rcywKPiBOaWNrCj4gLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=