All of lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH nvme-cli rfc 0/6] Support discovery log change events
Date: Thu, 25 Apr 2019 12:10:41 -0700	[thread overview]
Message-ID: <f0e112f7-0db5-4928-0859-8b3b6b797432@grimberg.me> (raw)
In-Reply-To: <44f637f2-0c0d-cef4-05b3-c5e67ec907bb@grimberg.me>


>> I do have some quite fundamental problem with discovery log change 
>> events:
>> - The initial discovery is still unsolved, ie we have to know the 
>> transport address before we can even get to those events
> 
> I understand your concern, but its completely irrelevant to this.
> This is a building block to automate the entire sequence, but
> the fact that we don't have it all automated doesn't mean we should
> not support discovery log change AENs.
> 
> For root discovery automation, we can talk about bringing a tpar
> with a prototype.
> 
>> - More crucially, we don't get these events when we to the first 
>> connection, requiring us to have the initial call to 'connect-all' on 
>> a separate way.
> 
> Again, this is initial root discovery, which is irrelevant to discovery
> log change events.
> 
>> - We don't have any indication if a new subsystem has been created; 
>> once a subsystem a new subsystem on another port is created it's 
>> anyones guess if that'll show up on the particular discovery controller
> 
> What? the event is on the port level, every port/subsystem softlink will
> trigger a discovery log change event. Its not anyones guess, its pretty
> deterministic given that you have discovery controller connected to the
> port.
> 
>> Especially the second point is most vexing; we could get around this 
>> by requiring the discovery controller to send AENs on the initial connect
>> (well, actually as soon as the AENs are enabled), but I guess that'll 
>> require a change to the spec ...
> 
> Why? with a script to auto-connect or root discovery automation this is 
> no longer an issue (not sure how much this is an issue right now).

Reviving this (again).

Hannes, did you have a chance to look at this? Unless there are other
alternatives I suggest we go with this approach.

We should be able to support discovery log change events automatically
at some point...

  reply	other threads:[~2019-04-25 19:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23  2:32 [PATCH nvme-cli rfc 0/6] Support discovery log change events Sagi Grimberg
2019-02-23  2:32 ` [PATCH nvme-cli rfc 1/6] fabrics: ignore arguments that pass in "none" Sagi Grimberg
2019-05-07  9:17   ` Max Gurtovoy
2019-05-07 17:04     ` James Smart
2019-02-23  2:32 ` [PATCH nvme-cli rfc 2/6] fabrics: support persistent connections to a discovery controller Sagi Grimberg
2019-05-07  9:22   ` Max Gurtovoy
2019-02-23  2:32 ` [PATCH nvme-cli rfc 3/6] fabrics: allow user to retrieve discovery log from existing " Sagi Grimberg
2019-05-07  9:27   ` Max Gurtovoy
2019-02-23  2:32 ` [PATCH nvme-cli rfc 4/6] fabrics: add --quiet option Sagi Grimberg
2019-05-07  9:35   ` Max Gurtovoy
2019-05-07 17:12     ` James Smart
2019-05-07 18:54       ` Max Gurtovoy
2019-02-23  2:32 ` [PATCH nvme-cli rfc 5/6] fabrics: systemd and udev support for automatic discovery log changes Sagi Grimberg
2019-02-23  2:32 ` [PATCH nvme-cli rfc 6/6] fc: add autoconnect systemd service and udev rule for fc " Sagi Grimberg
2019-02-24 17:17 ` [PATCH nvme-cli rfc 0/6] Support discovery log change events Hannes Reinecke
2019-02-24 22:33   ` Sagi Grimberg
2019-03-09  2:18     ` Sagi Grimberg
2019-03-13 21:04     ` James Smart
2019-03-14  0:00       ` Sagi Grimberg
2019-03-14 20:43         ` James Smart
2019-03-14 20:50           ` James Smart
2019-03-15 12:40             ` Hannes Reinecke
2019-03-15 20:38               ` Sagi Grimberg
2019-04-25 19:10                 ` Sagi Grimberg [this message]
2019-04-26 14:19                   ` Hannes Reinecke
2019-04-26 15:46                     ` Sagi Grimberg
2019-04-26 16:17                       ` James Smart
2019-04-26 19:10                         ` Sagi Grimberg
2019-04-26 20:14                           ` James Smart
2019-05-06 22:38                             ` Arun Easi
2019-05-07 16:47                               ` James Smart
2019-04-27 11:05                           ` Hannes Reinecke
2019-04-27 10:53                       ` Hannes Reinecke
2019-03-14 21:41           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0e112f7-0db5-4928-0859-8b3b6b797432@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.