From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751256AbeEFHpo (ORCPT ); Sun, 6 May 2018 03:45:44 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:27459 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbeEFHpl (ORCPT ); Sun, 6 May 2018 03:45:41 -0400 From: "Reizer, Eyal" To: Tony Lindgren CC: Eyal Reizer , "bcousson@baylibre.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-omap@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support Thread-Topic: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support Thread-Index: AQHT4umNrIAS1VNvUkK07yas+IZ4paQiVQFA Date: Sun, 6 May 2018 07:45:31 +0000 Message-ID: References: <1525159453-32489-1-git-send-email-eyalr@ti.com> <20180502145100.GK98604@atomide.com> <5cc906da15da45ab96e06957f878b65b@ti.com> <20180503141759.GP98604@atomide.com> In-Reply-To: <20180503141759.GP98604@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [137.167.25.139] x-exclaimer-md-config: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w467jnW7009768 > > * Reizer, Eyal [180503 06:43]: > > > > > > * Eyal Reizer [180501 00:26]: > > > > enable mmc3 used for wlan and uart1 used for bluetooth > > > > configure the gpios used for wlan and bluetooth controls > > > > add fixed voltage regulator used for wlan power control > > > ... > > > > / { > > > > model = "TI AM437x SK EVM"; > > > > @@ -158,6 +159,22 @@ > > > > }; > > > > }; > > > > }; > > > > + > > > > + vmmcwl_fixed: fixedregulator-mmcwl { > > > > + /* > > > > + * WL_EN is not SDIO standard compliant. It is an out of band > > > > + * signal and hard to be dealt with in a standard way by the > > > > + * SDIO core driver. > > > > + * So modelling the WL_EN line as a regulator was a natural > > > > + * choice as the MMC core already deals with MMC supplies. > > > > + */ > > > > + compatible = "regulator-fixed"; > > > > + regulator-name = "vmmcwl_fixed"; > > > > + regulator-min-microvolt = <1800000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + gpio = <&gpio4 8 GPIO_ACTIVE_HIGH>; > > > > + enable-active-high; > > > > + }; > > > > }; > > > > > > Interesting that it needs much longer delay here compared to the > > > earlier? > > > > Where do you see a delay in here? > > There is no startup-delay-us value used in this patch. > > Oops sorry, I misread the voltage above as the startup-delay-us > value :) > No issue :) > > > BTW, I do have a patch in work to add pwrseq support for wlcore that > > > allows leaving out the regulator here. It still needs a bit more > > > work though. > > > > > > And I also have a series in work to make wlcore use runtime PM that > > > needs even more work, just FYI to avoid any duplicate work. > > > > > > Hmm you don't happen to have a patch series somewhere making > > > wlcore use the SDIO dat lien interrupt? > > wilink has always used out of band interrupt (using wlan_irq gpio). > > in-band interrupts was not supported. > > See section 10.5.2 in this the wl18xx hardware integration guide: > > http://www.ti.com/lit/ug/swru437/swru437.pdf > > Hmm yeah I've been wondering about that. Why not follow the SDIO > standard here though? Do you have links to documentation explaining > that? > I will try to see what I can find out and why it has always been used only With out-of band interrupts and whether there is a real hardware Limitation behind it . In the past also the omap-hsmmc driver was not really supporting in-band sdio interrupt out of the box. Not sure what is the state of it tofday. > > > I think we should use that when idle rather than the (edge) gpio > > > interrupt as the SDIO dat interrupt is level sensitive and wired > > > to the always on gpio bank for most SDIO controller instances. > > > On runtime PM wakeup, there's no status anywhere to been with the > > > GPIO edge interrupt. > > > > > I agree that it would have been better, especially for cases such as wake > > On wlan, but again, in-band interrupt was something that was talked > > about way back but it was never implemented. > > I think we can have both if performance is the reason for the > out of band interrupt. We could still use SDIO dat line interrupt > during idle for wake-up events. Correct, assuming we can make in-band interrupt work with wilink8. Best Regards, Eyal