From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B28C07E99 for ; Mon, 12 Jul 2021 14:40:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 988FC61156 for ; Mon, 12 Jul 2021 14:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988FC61156 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2x6a-0006TM-OE for qemu-devel@archiver.kernel.org; Mon, 12 Jul 2021 10:40:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2x57-00055I-IJ; Mon, 12 Jul 2021 10:38:50 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:12584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2x54-0005rR-Lb; Mon, 12 Jul 2021 10:38:48 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id B0D9374570E; Mon, 12 Jul 2021 16:38:43 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 45EE174570D; Mon, 12 Jul 2021 16:38:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 447D17456B4; Mon, 12 Jul 2021 16:38:43 +0200 (CEST) Date: Mon, 12 Jul 2021 16:38:43 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH] mv64361: Remove extra break from a switch case In-Reply-To: <5a2131d6-4b85-839d-8cd3-18cdcea15925@amsat.org> Message-ID: References: <20210712131259.B705B7456E3@zero.eik.bme.hu> <5a2131d6-4b85-839d-8cd3-18cdcea15925@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-583204199-1626100723=:20424" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-583204199-1626100723=:20424 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 12 Jul 2021, Philippe Mathieu-Daudé wrote: > On 7/12/21 3:11 PM, BALATON Zoltan wrote: >> The switch case of writing PCI 1 IO base address had an extra break >> statement that made part of the code unreachable. This did not cause a >> problem as guests ususally leave this register at its default value. >> >> Reported-by: Coverity (CID 1458135) > > Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system > controller") > ? Yeah, why not. Feel free to add the Fixes tag when merging, although that's the only commit this file had so far so linking to it does not seem to add much more info. Regards, BALATON Zoltan >> Signed-off-by: BALATON Zoltan >> --- >> hw/pci-host/mv64361.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c >> index 20510d8680..92b0f5d047 100644 >> --- a/hw/pci-host/mv64361.c >> +++ b/hw/pci-host/mv64361.c >> @@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val, >> case MV64340_PCI_1_IO_BASE_ADDR: >> s->pci[1].io_base = val & 0x30fffffULL; >> warn_swap_bit(val); >> - break; >> if (!(s->cpu_conf & BIT(27))) { >> s->pci[1].remap[4] = (val & 0xffffULL) << 16; >> } >> > > --3866299591-583204199-1626100723=:20424--