From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23591C433E6 for ; Sun, 7 Feb 2021 18:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9E8864E30 for ; Sun, 7 Feb 2021 18:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbhBGStV (ORCPT ); Sun, 7 Feb 2021 13:49:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhBGStS (ORCPT ); Sun, 7 Feb 2021 13:49:18 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6431C06174A; Sun, 7 Feb 2021 10:48:37 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id y18so15591661edw.13; Sun, 07 Feb 2021 10:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=ToR10LHsn60YUDp2DP0hDjaXCyVzc8zWU/NGOLWEgKHS6gMxtdfHAMZ6v3cS6X0/iY aZwv5NRsuqKhCHL0rJMZX+249h0GhfVmma5wrykmnWvvGkZA1mHvIEORbNp5IKyPx1R7 47IGQ16ETe9b+F4QIb+C5P/JwoY+vv0K3Vzn1umWLIBVY+eKNZSTJIkzD89xhjqn+mF3 UeY+vdZsEvvSLhf5zMl3eweZVvJ8gQ/AZEVlLre/YN1LNTwHJE9ErIpyR1+rmASTrOnV mDbZaSTdvK4AdIeqguB8QY/JDaKUe1YwXadFwDC0rB684zoN3pZTw5ABoJWssinMRv9Y GUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=C/fSQjKc2o96F1ABaq29HFLMyyfPXdcp3dKy9as6e7Tp1QN+1rCqJh/F1lcj6lCJe/ 8zViHCvyAWfQ0Gv2GrtCf8rMBdbVmtbcsGpq6bD0/imVryaY/sRdug5RxXzkgSIhNbYA xEOzpANagMOtmOujIDv5cmPxStZUcGQru+eTeYFzxRBhfCQWsvyV7/geVqkcq8R6xZvz ujdxbQacSBRCU7gtMAfNXWU0auUS5vHyw6NnKqW6xsHgTlp/Hm2LG1h6teWQC0XrvxP4 jaSZtBbF256Ln7L5Tmzg12QFnECartz+kmIGVyAvu6uoa+d4ugelJb316opnAuN1/fjS X5OA== X-Gm-Message-State: AOAM533s8mX1FJr4G64XKNKQKyyHiyAIFEWa/Zj9GhZAwYZvH+bXfxMT EJ/bWe/lFfa6iF4EwCIMEW89L28iij4X5w== X-Google-Smtp-Source: ABdhPJw0mfAfPKKjiEL+LasOhxLInAfCF/IyAaxDCVbPW22DiVvyPcta0oxPzyEwqia1eDWJFUublw== X-Received: by 2002:a50:d6c1:: with SMTP id l1mr13873785edj.336.1612723716670; Sun, 07 Feb 2021 10:48:36 -0800 (PST) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id bz20sm7383803ejc.38.2021.02.07.10.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Feb 2021 10:48:35 -0800 (PST) Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes To: Tzung-Bi Shih Cc: Hsin-Hsiung Wang , Lee Jones , Rob Herring , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , Fei Shao , Eddie Huang , Sean Wang , Yuchen Huang , Ran Bi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Wen Su , Jiaxin Yu References: <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1611913781-23460-9-git-send-email-hsin-hsiung.wang@mediatek.com> <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> From: Matthias Brugger Message-ID: Date: Sun, 7 Feb 2021 19:48:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2021 04:51, Tzung-Bi Shih wrote: > On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger wrote: >> On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: >>> + mt6359codec: mt6359codec { >>> + }; >> >> I understand that the dmic-mode and mic-type-X depends on the actual board on >> which it is used. In that case I think we should add mt6359codec node in the dts >> instead of dtsi file. I'd advise to set these properties as well as otherwise we >> get a (slightly misleading) warning in the driver. > > I feel it is better to include the node in dtsi to represent the whole > MT6359 PMIC. > > We could either: > - Set default values of these properties in the dtsi to avoid the > warning message. > - Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/ > As this got accpeted upstream, you don't need to do anything about it. Thanks for the pointer. Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CE7C433E0 for ; Sun, 7 Feb 2021 18:48:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B8064DF6 for ; Sun, 7 Feb 2021 18:48:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B8064DF6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5C1olsMgsszw2yxu00FCwUpu/Oi559btG02w8l95XPk=; b=NYIeL1tZ7TU9L5yRTEn5iuHte ktPv5YB5KR3YXTt6c6QVfoWZBjp+Vc2MHWWN8M5v08X5RVsJqIRDGwypOSOCo7C/fdi5gpTOxqA1A eOrftScr3e8J3KgRVRpQx2JITUJ9X3cYWnQDx7u5YCQcfOOeTuRcw8EsMXB7AF5IuYNw7eWLSVp9t kQ5rJXfo1mVA2BeLlNkADn+qn7yDmK8ov73I/4+aG5wdc21UouIXs89YjtNdkGcMePJn6DjeQ1pln f4xCMGzpU7VlTFb1S6t6Y7BzPAJ3hVBZZEg5Z41gi1FXhIBRmH2cz49S1UqiEoRhzBZBeuY5HvucW hnYwq5ahA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8p6w-0002b2-4R; Sun, 07 Feb 2021 18:48:42 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8p6t-0002Zl-Gs; Sun, 07 Feb 2021 18:48:40 +0000 Received: by mail-ed1-x535.google.com with SMTP id t5so15599230eds.12; Sun, 07 Feb 2021 10:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=ToR10LHsn60YUDp2DP0hDjaXCyVzc8zWU/NGOLWEgKHS6gMxtdfHAMZ6v3cS6X0/iY aZwv5NRsuqKhCHL0rJMZX+249h0GhfVmma5wrykmnWvvGkZA1mHvIEORbNp5IKyPx1R7 47IGQ16ETe9b+F4QIb+C5P/JwoY+vv0K3Vzn1umWLIBVY+eKNZSTJIkzD89xhjqn+mF3 UeY+vdZsEvvSLhf5zMl3eweZVvJ8gQ/AZEVlLre/YN1LNTwHJE9ErIpyR1+rmASTrOnV mDbZaSTdvK4AdIeqguB8QY/JDaKUe1YwXadFwDC0rB684zoN3pZTw5ABoJWssinMRv9Y GUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=BH+O/ZhHbTfVjuG8V4+CihNvjp8UaSj9+brvLDln6bIR4Ec/pQcabO90vj/KQO3TAS ySWB3mwSLx8F0pGhTvhx31RUL05cPwEaZojfE3g5h2+KOHyiNfjvhTZzfCGS/kryvU2z nNldf+KlaTUO6rFGv+PSt1LQawVFVGf7Ue9fANrs2ebs8wWDQuJ2UyH87TT2dCL9pLIE eFmX94gpA90IMeqGGReXp1AKKzAnTXyvQ6eDmP7b2iNJvHXkElHFaqTEBmSzCA6tcKRE FbhxlH/WRZkZgk2kPMA05kEfnHUiY3cjZRd0bUAKINnVxzzixgx2p1SC4uoNlODoMu0H D1Iw== X-Gm-Message-State: AOAM531nqypXUGT6CQksQK5vcRMu/E6Hmb7E4YlThgvhQA/yjJ4uiTSR QSiy0l0CFHAJNseZIFMLoWY= X-Google-Smtp-Source: ABdhPJw0mfAfPKKjiEL+LasOhxLInAfCF/IyAaxDCVbPW22DiVvyPcta0oxPzyEwqia1eDWJFUublw== X-Received: by 2002:a50:d6c1:: with SMTP id l1mr13873785edj.336.1612723716670; Sun, 07 Feb 2021 10:48:36 -0800 (PST) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id bz20sm7383803ejc.38.2021.02.07.10.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Feb 2021 10:48:35 -0800 (PST) Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes To: Tzung-Bi Shih References: <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1611913781-23460-9-git-send-email-hsin-hsiung.wang@mediatek.com> <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> From: Matthias Brugger Message-ID: Date: Sun, 7 Feb 2021 19:48:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210207_134839_605827_B90D58B3 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , Jiaxin Yu , Wen Su , srv_heupstream@mediatek.com, Fei Shao , Ran Bi , Sean Wang , Liam Girdwood , Rob Herring , Linux Kernel Mailing List , Project_Global_Chrome_Upstream_Group@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mark Brown , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Eddie Huang , Lee Jones , Yuchen Huang , Hsin-Hsiung Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 02/02/2021 04:51, Tzung-Bi Shih wrote: > On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger wrote: >> On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: >>> + mt6359codec: mt6359codec { >>> + }; >> >> I understand that the dmic-mode and mic-type-X depends on the actual board on >> which it is used. In that case I think we should add mt6359codec node in the dts >> instead of dtsi file. I'd advise to set these properties as well as otherwise we >> get a (slightly misleading) warning in the driver. > > I feel it is better to include the node in dtsi to represent the whole > MT6359 PMIC. > > We could either: > - Set default values of these properties in the dtsi to avoid the > warning message. > - Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/ > As this got accpeted upstream, you don't need to do anything about it. Thanks for the pointer. Matthias _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3E5C433DB for ; Sun, 7 Feb 2021 18:50:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0301464D7F for ; Sun, 7 Feb 2021 18:50:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0301464D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1uE7vvTweIY2xoOt7T7aec9vaWoPBzrhi1aPT/bQ9Dk=; b=lN5Xaaph94j4TH2CswHPl8hf2 hIsAgW6AI9Eat/ni6vKQFPZlKO9NK13oHhN1oLVvvnxzHyZ+8dMsm10jE2BhCbU/pF8bzgqsrhm9l IJc2qmnseiEfv2BDI/8UwrDWt+oOu/QLtytlxHYLcFxjxYg1DmDdC6sGlRKJhwQhMAmxqi24qKnu5 eEkQHofLe6T/vxstzAVD9fxUIJ5Km4U1ad5X3TWB4kAGMU9HwuqwvAAF/3KX54YciVJ4KDYKBBNCi f+pw6pYyIS6jEznWrLR64cNO/OL2ds4Mqwrf+vmypjPW3PS0BzAzxOvnisgW92zrqd7FRGnhcUcot FuwrRYH9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8p6y-0002bR-SM; Sun, 07 Feb 2021 18:48:44 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8p6t-0002Zl-Gs; Sun, 07 Feb 2021 18:48:40 +0000 Received: by mail-ed1-x535.google.com with SMTP id t5so15599230eds.12; Sun, 07 Feb 2021 10:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=ToR10LHsn60YUDp2DP0hDjaXCyVzc8zWU/NGOLWEgKHS6gMxtdfHAMZ6v3cS6X0/iY aZwv5NRsuqKhCHL0rJMZX+249h0GhfVmma5wrykmnWvvGkZA1mHvIEORbNp5IKyPx1R7 47IGQ16ETe9b+F4QIb+C5P/JwoY+vv0K3Vzn1umWLIBVY+eKNZSTJIkzD89xhjqn+mF3 UeY+vdZsEvvSLhf5zMl3eweZVvJ8gQ/AZEVlLre/YN1LNTwHJE9ErIpyR1+rmASTrOnV mDbZaSTdvK4AdIeqguB8QY/JDaKUe1YwXadFwDC0rB684zoN3pZTw5ABoJWssinMRv9Y GUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EGUleL2eUhQNkqgdSNGHaB4lMTeXgM8GYS8mqXoep18=; b=BH+O/ZhHbTfVjuG8V4+CihNvjp8UaSj9+brvLDln6bIR4Ec/pQcabO90vj/KQO3TAS ySWB3mwSLx8F0pGhTvhx31RUL05cPwEaZojfE3g5h2+KOHyiNfjvhTZzfCGS/kryvU2z nNldf+KlaTUO6rFGv+PSt1LQawVFVGf7Ue9fANrs2ebs8wWDQuJ2UyH87TT2dCL9pLIE eFmX94gpA90IMeqGGReXp1AKKzAnTXyvQ6eDmP7b2iNJvHXkElHFaqTEBmSzCA6tcKRE FbhxlH/WRZkZgk2kPMA05kEfnHUiY3cjZRd0bUAKINnVxzzixgx2p1SC4uoNlODoMu0H D1Iw== X-Gm-Message-State: AOAM531nqypXUGT6CQksQK5vcRMu/E6Hmb7E4YlThgvhQA/yjJ4uiTSR QSiy0l0CFHAJNseZIFMLoWY= X-Google-Smtp-Source: ABdhPJw0mfAfPKKjiEL+LasOhxLInAfCF/IyAaxDCVbPW22DiVvyPcta0oxPzyEwqia1eDWJFUublw== X-Received: by 2002:a50:d6c1:: with SMTP id l1mr13873785edj.336.1612723716670; Sun, 07 Feb 2021 10:48:36 -0800 (PST) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id bz20sm7383803ejc.38.2021.02.07.10.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Feb 2021 10:48:35 -0800 (PST) Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes To: Tzung-Bi Shih References: <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1611913781-23460-9-git-send-email-hsin-hsiung.wang@mediatek.com> <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> From: Matthias Brugger Message-ID: Date: Sun, 7 Feb 2021 19:48:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210207_134839_605827_B90D58B3 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , Jiaxin Yu , Wen Su , srv_heupstream@mediatek.com, Fei Shao , Ran Bi , Sean Wang , Liam Girdwood , Rob Herring , Linux Kernel Mailing List , Project_Global_Chrome_Upstream_Group@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mark Brown , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Eddie Huang , Lee Jones , Yuchen Huang , Hsin-Hsiung Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/02/2021 04:51, Tzung-Bi Shih wrote: > On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger wrote: >> On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: >>> + mt6359codec: mt6359codec { >>> + }; >> >> I understand that the dmic-mode and mic-type-X depends on the actual board on >> which it is used. In that case I think we should add mt6359codec node in the dts >> instead of dtsi file. I'd advise to set these properties as well as otherwise we >> get a (slightly misleading) warning in the driver. > > I feel it is better to include the node in dtsi to represent the whole > MT6359 PMIC. > > We could either: > - Set default values of these properties in the dtsi to avoid the > warning message. > - Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/ > As this got accpeted upstream, you don't need to do anything about it. Thanks for the pointer. Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel