Re: [PATCH i-g-t 6/7] lib/igt_kms: remove unused igt_force_and_check_bigjoiner_status

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On 19-04-2024 12:10 pm, Kunal Joshi wrote:
> remove unused igt_force_and_check_bigjoiner_status
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   lib/igt_kms.c | 28 ----------------------------
>   lib/igt_kms.h |  1 -
>   2 files changed, 29 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 324b0527f..35e2a0bb0 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6332,34 +6332,6 @@ bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
>   	return ret >= 0;
>   }
>   
> -/**
> - * Forces the enable/disable state of big joiner for a specific connector.
> - *
> - * @drmfd The file descriptor of the DRM device.
> - * @connector_name The name of the connector.
> - * @enable The desired state of big joiner (true for enable, false for disable).
> - * Returns:
> - *  true if writing the debugfs was successful
> - *  and the state was set as requested, false otherwise.
> - */
> -bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable)
> -{
> -	int debugfs_fd, ret;
> -	char buf[512];
> -
> -	igt_assert_f(connector_name, "Connector name cannot be NULL\n");
> -	debugfs_fd = igt_debugfs_connector_dir(drmfd, connector_name, O_DIRECTORY);
> -	igt_assert_f(debugfs_fd >= 0, "Could not open debugfs for connector %s\n", connector_name);
> -	ret = igt_sysfs_write(debugfs_fd, "i915_bigjoiner_force_enable", enable ? "1" : "0", 1);
> -	igt_assert_f(ret > 0, "Could not write i915_bigjoiner_force_enable for connector %s\n", connector_name);
> -	ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
> -	close(debugfs_fd);
> -	igt_assert_f(ret > 0, "Could not read i915_bigjoiner_force_enable for connector %s\n", connector_name);
> -
> -	return enable ? strstr(buf, "Y") :
> -			strstr(buf, "N");
> -}
> -
>   /**
>    * igt_check_bigjoiner_support:
>    * @display: a pointer to an #igt_display_t structure
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 0abf450c1..01604dac9 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1216,7 +1216,6 @@ bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock);
>   bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
>   			  int max_dotclock, drmModeModeInfo *mode);
>   bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output);
> -bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable);
>   bool igt_check_bigjoiner_support(igt_display_t *display);
>   bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
>   bool intel_pipe_output_combo_valid(igt_display_t *display);