From: Davide Caratti <dcaratti at redhat.com>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH mptcp] net: mptcp: fix memory leak in case slab allocation fails
Date: Tue, 14 May 2019 09:59:25 +0200 [thread overview]
Message-ID: <f0f987fd1ff1e04c24ecb0ef2043bb80900cb044.camel@redhat.com> (raw)
In-Reply-To: alpine.OSX.2.21.1905131632540.11725@mjmartin-mac01.local
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Mon, 2019-05-13 at 16:36 -0700, Mat Martineau wrote:
> On Mon, 13 May 2019, Davide Caratti wrote:
>
> > slab_name is allocated, but not freed, when slab allocation fails: ensure
> > it is freed in the error path of kmem_cache_create(...). While at it, fix
> > reverse christmas tree in subflow_ops-init() local variable declarations.
>
> Davide -
>
Thanks for the leak fix. Looks good to me.
hi Mat, thanks a lot for reviewing.
I forgot to mention, this can be squashed into
aedec94346fb ("mptcp: Create SUBFLOW socket for incoming connections").
regards,
--
davide
next reply other threads:[~2019-05-14 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:59 Davide Caratti [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-14 16:10 [MPTCP] [PATCH mptcp] net: mptcp: fix memory leak in case slab allocation fails Matthieu Baerts
2019-05-13 23:36 Mat Martineau
2019-05-13 16:55 Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f987fd1ff1e04c24ecb0ef2043bb80900cb044.camel@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.