From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53CDC433ED for ; Thu, 1 Apr 2021 10:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EA43610CA for ; Thu, 1 Apr 2021 10:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233947AbhDAKhp (ORCPT ); Thu, 1 Apr 2021 06:37:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46374 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233553AbhDAKhX (ORCPT ); Thu, 1 Apr 2021 06:37:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617273442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwwpY9zbsR9wmWnWgRPCRzGvVQBCnRsTEtAa4NdFU5k=; b=ScnHDH9hunJq0jEW40aJ8NAd2Dlj4H/obNsQeyEQkUDgUFZSjWZDHf/JMcTM2WNqQOiRUJ WBx5FSr/G2eAmjtIzaBGWCobYKZvY95NmKp5pefboRcCxD9j6yBh85kwVc4ojGwVFBWGS0 0cROoGMD0fF5Jl1v4vXyrSGJfZbK0SQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-dRFHr6BHMImm1Qz7UGpXtg-1; Thu, 01 Apr 2021 06:37:20 -0400 X-MC-Unique: dRFHr6BHMImm1Qz7UGpXtg-1 Received: by mail-ed1-f72.google.com with SMTP id i6so2637421edq.12 for ; Thu, 01 Apr 2021 03:37:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CwwpY9zbsR9wmWnWgRPCRzGvVQBCnRsTEtAa4NdFU5k=; b=sc8ofWkrQSNsfWM9C3Tufqq3fb9WDhz5P2YS5aqZrYXLpGCqW9Fq+6JLdbUAwnOPHq XpN0e3HTs3z0wlqDQsxz5GKR5X+hxaf6+WsDTgUhp2Jzp/h4JKr8hiiLHuL6aRvpuGdp r8H+LLB72DhGGDVjO4So3nonehiLtd1KHLr+RQXtV4I7xrKp3TacFBcwLxDk+uh9oX1j o+QBvqpKRaEjIYU1kiQ0RKrfyhqcinhNbEpKfWWCsNFQowZMl0pQJVZqkfkBxvNj3TBk q1AuOIN+VXDj3mH4/8FeYS0pv5lmN97ICv15pLn9vCiVhi2tARZbVfDPGyfjyBIhTeFi 38kA== X-Gm-Message-State: AOAM533dLUx0ps0jqtJYOHgyBr2oCx5scEzLyC53yTAm9TIcEEk80aNF tOPxjvimS7KUfEqb537DS64e79Jh5YZX4LVq4p/uTC/Qf3Iz2MJzl6A22eKVAfir0qUvr2ODPXH 5rglc1mGy3KAqoFPC55uG4BBG X-Received: by 2002:a17:906:73cd:: with SMTP id n13mr8138949ejl.535.1617273439666; Thu, 01 Apr 2021 03:37:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoUdSWV6alowEJjrB0ng3a9PHsGiuAok+cNZ5pAIf5wRLMsANMzn1JKnVF08lT4MhG1RqcJg== X-Received: by 2002:a17:906:73cd:: with SMTP id n13mr8138926ejl.535.1617273439481; Thu, 01 Apr 2021 03:37:19 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id mc10sm2581695ejb.56.2021.04.01.03.37.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 03:37:18 -0700 (PDT) Subject: Re: [PATCH 13/13] KVM: x86/mmu: Tear down roots in fast invalidation thread To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210331210841.3996155-1-bgardon@google.com> <20210331210841.3996155-14-bgardon@google.com> From: Paolo Bonzini Message-ID: Date: Thu, 1 Apr 2021 12:37:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210331210841.3996155-14-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/21 23:08, Ben Gardon wrote: > +/* > + * Since kvm_tdp_mmu_invalidate_roots has acquired a reference to each > + * invalidated root, they will not be freed until this function drops the > + * reference. Before dropping that reference, tear down the paging > + * structure so that whichever thread does drop the last reference > + * only has to do a trivial ammount of work. Since the roots are invalid, > + * no new SPTEs should be created under them. > + */ > +void kvm_tdp_mmu_zap_all_fast(struct kvm *kvm) Please rename this to kvm_tdp_mmu_zap_invalidated_roots. Paolo