From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BB0C433DB for ; Tue, 16 Feb 2021 18:53:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 471F764EB2 for ; Tue, 16 Feb 2021 18:53:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 471F764EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC5Te-0007ig-Cy for qemu-devel@archiver.kernel.org; Tue, 16 Feb 2021 13:53:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC5R0-0005nC-Do for qemu-devel@nongnu.org; Tue, 16 Feb 2021 13:50:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lC5Qy-0001wA-Lg for qemu-devel@nongnu.org; Tue, 16 Feb 2021 13:50:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613501451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SpqN4QggzB6TyEu4x1ZFNYSw8xZSCC3xPQYgpioOtk=; b=QLhtsuEuQfZKuPNdjhW1TgAd4CMMXbvcBN928eVFXZw7VOH8qq7u+rUeZTwzInXpzqiNCL a5vuhJuDs9dFZXkR7nBq4Il0H9GrzYZ2fyHM56js35AtrKQeIKOypall8rcWhePbAiUiq8 zFOqDFzJnaJS9EQgZA3yVv+cUx5o4cc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-MpdbI1FcMw2YsbuNXzNWEA-1; Tue, 16 Feb 2021 13:50:48 -0500 X-MC-Unique: MpdbI1FcMw2YsbuNXzNWEA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D33C88463A1; Tue, 16 Feb 2021 18:50:41 +0000 (UTC) Received: from [10.36.114.70] (ovpn-114-70.ams2.redhat.com [10.36.114.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 652FD70484; Tue, 16 Feb 2021 18:50:26 +0000 (UTC) Subject: Re: [PATCH v5 01/11] memory: Introduce RamDiscardMgr for RAM memory regions To: qemu-devel@nongnu.org References: <20210121110540.33704-1-david@redhat.com> <20210121110540.33704-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 16 Feb 2021 19:50:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210121110540.33704-2-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Kedzierski , Pankaj Gupta , Wei Yang , "Michael S. Tsirkin" , Alex Williamson , Peter Xu , "Dr . David Alan Gilbert" , Auger Eric , Pankaj Gupta , teawater , Jonathan Cameron , Paolo Bonzini , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > + /** > + * @is_populated: > + * > + * Check whether the given range within the #MemoryRegion is completely > + * populated (i.e., no parts are currently discarded). There are no > + * alignment requirements for the range. > + * > + * @rdm: the #RamDiscardMgr > + * @mr: the #MemoryRegion > + * @offset: offset into the #MemoryRegion > + * @size: size in the #MemoryRegion > + * > + * Returns whether the given range is completely populated. > + */ > + bool (*is_populated)(const RamDiscardMgr *rdm, const MemoryRegion *mr, > + ram_addr_t start, ram_addr_t offset); Minor thing I noticed in the meanwhile: Variable naming here is wrong. Last line should be: "ram_addr_t offset, ram_addr_t size" -- Thanks, David / dhildenb