From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966899AbdAJI3c (ORCPT ); Tue, 10 Jan 2017 03:29:32 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:40355 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbdAJI3a (ORCPT ); Tue, 10 Jan 2017 03:29:30 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: kernel-janitors@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> <304ae7a7-bc51-83d7-2a6b-844cdf4c346f@users.sourceforge.net> Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org From: Shawn Lin Message-ID: Date: Tue, 10 Jan 2017 16:28:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <304ae7a7-bc51-83d7-2a6b-844cdf4c346f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/9 5:50, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 21:43:12 +0100 > > * The script "checkpatch.pl" pointed information out like the following. > > WARNING: Prefer kcalloc over kzalloc with multiply > > Thus fix the affected source code place. > Reviewed-by: Shawn Lin > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 294d3c675734..cb4750de2720 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, > if (!mem) > return NULL; > > - mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs, > - GFP_KERNEL); > + mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL); > if (!mem->arr) > goto out_free; > > -- Best Regards Shawn Lin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Date: Tue, 10 Jan 2017 08:28:35 +0000 Subject: Re: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() Message-Id: List-Id: References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> <304ae7a7-bc51-83d7-2a6b-844cdf4c346f@users.sourceforge.net> In-Reply-To: <304ae7a7-bc51-83d7-2a6b-844cdf4c346f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org On 2017/1/9 5:50, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 21:43:12 +0100 > > * The script "checkpatch.pl" pointed information out like the following. > > WARNING: Prefer kcalloc over kzalloc with multiply > > Thus fix the affected source code place. > Reviewed-by: Shawn Lin > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 294d3c675734..cb4750de2720 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, > if (!mem) > return NULL; > > - mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs, > - GFP_KERNEL); > + mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL); > if (!mem->arr) > goto out_free; > > -- Best Regards Shawn Lin