From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/e1000: advertise offload capabilities for the EM PMD Date: Tue, 14 Mar 2017 15:19:21 +0000 Message-ID: References: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Lu, Wenzhuo" , "Legacy, Allain (Wind River)" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7F2235599 for ; Tue, 14 Mar 2017 16:19:23 +0100 (CET) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/13/2017 3:15 AM, Lu, Wenzhuo wrote: > Hi, > >> -----Original Message----- >> From: Allain Legacy [mailto:allain.legacy@windriver.com] >> Sent: Friday, March 10, 2017 10:38 PM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org >> Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD >> >> The hardware offload capabilities are not being advertised for the EM PMD. >> Because of this, applications that only enable these features if the device >> advertises them will never do so. >> >> Normally this is not an issue since normal packet processing should work even if >> hardware offload is not available. But, in older versions of Virtual Box the e1000 >> device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it should >> enable VLAN stripping even if the driver does not request it. This means that any >> ingress packets that have a VLAN tag will be stripped. Since the application did >> not request to enable VLAN stripping it is not expecting these packets so they >> are not processed as VLAN packets. >> >> Regardless of the Virtual Box issue, the driver should be advertising supported >> capabilities as is done in other drivers. >> >> Signed-off-by: Allain Legacy > Acked-by: Wenzhuo Lu Applied to dpdk-next-net/master, thanks.