From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C43CC433EF for ; Fri, 5 Nov 2021 01:22:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B25D60FE3 for ; Fri, 5 Nov 2021 01:22:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B25D60FE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D416836DD; Fri, 5 Nov 2021 02:22:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636075326; bh=+/RxhdWZ5jGiDUAZNbD1A6RqCoJncyWVqnFmPWOJklQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WMebtv21qmtApzEP2As4Exf2UEKkcmEwXLfn44AMQcBnhWKX53FiglbtqyBSsdaqk 9F7O99IEmSHbMqWhJk/3bY0GKhwjHZedDzHiuwJ/4nMbrrgrCoCrVefzamnsW5V5NT qOths850NidSVg1qSZRUbLTe4YoZ/VxpEd4I4v90XzDjgs7XDZ7tLTApVHpHrc0KFS iGyJqx8a7rUVzwFJsBB95OVJPtUG/VKgvBJIS31A8p7ARTn7PO8VX32QjnKtblKpB7 JUSBSWxSVN7VZ4aj9T2Sy9QT3KJB2paDDaOXPXDfo7dQJr5wWSbc4V5/ed+2i6iOgB 62cyDwme5cZfA== Received: by phobos.denx.de (Postfix, from userid 109) id 4061783686; Fri, 5 Nov 2021 02:22:03 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E583983686 for ; Fri, 5 Nov 2021 02:21:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (unknown [91.198.250.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4HljQv676HzQjPn; Fri, 5 Nov 2021 02:21:59 +0100 (CET) Subject: Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration To: Andre Przywara Cc: Samuel Holland , u-boot@lists.denx.de, Jagan Teki , Bin Meng , Heinrich Schuchardt , Sean Anderson , Simon Glass References: <20211104035516.28268-1-samuel@sholland.org> <70136684-120e-925c-3709-576885d4bd17@denx.de> <20211104231140.4e2ad7f5@slackpad.fritz.box> From: Stefan Roese Message-ID: Date: Fri, 5 Nov 2021 02:21:55 +0100 MIME-Version: 1.0 In-Reply-To: <20211104231140.4e2ad7f5@slackpad.fritz.box> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8D5C826A X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Andre, On 05.11.21 00:11, Andre Przywara wrote: > On Thu, 4 Nov 2021 11:37:57 +0100 > Stefan Roese wrote: > > Hi Stefan, > >> On 04.11.21 04:55, Samuel Holland wrote: >>> This series hooks up the watchdog uclass to automatically register >>> watchdog devices for use with sysreset, doing a bit of minor cleanup >>> along the way. >>> >>> The goal is for this to replace the sunxi board-level non-DM reset_cpu() >>> function. I was surprised to find that the wdt_reboot driver requires >>> its own undocumented device tree node, which references the watchdog >>> device by phandle. This is problematic for us, because sunxi-u-boot.dtsi >>> file covers 20 different SoCs with varying watchdog node phandle names. >>> So it would have required adding a -u-boot.dtsi file for each board. >>> >>> Hooking things up automatically makes sense to me; this is what Linux >>> does. However, I put the code behind a new option to avoid surprises for >>> other platforms. >>> >>> Changes in v3: >>> - Move condition to wdt-uclass.c to fix build errors. >>> - Include watchdog name in error message. >>> >>> Changes in v2: >>> - Extend the "if SYSRESET" block to the end of the file. >>> - Also make gpio_reboot_probe function static. >>> - Rebase on top of 492ee6b8d0e7 (now handle all watchdogs). >>> - Added patches 5-6 as an example of how the new option will be used. >>> >>> Samuel Holland (6): >>> sysreset: Add uclass Kconfig dependency to drivers >>> sysreset: Mark driver probe functions as static >>> sysreset: watchdog: Move watchdog reference to plat data >>> watchdog: Automatically register device with sysreset >>> sunxi: Avoid duplicate reset_cpu with SYSRESET enabled >>> sunxi: Use sysreset framework for poweroff/reset >>> >>> arch/arm/Kconfig | 3 +++ >>> arch/arm/mach-sunxi/board.c | 2 ++ >>> drivers/sysreset/Kconfig | 11 ++++++-- >>> drivers/sysreset/sysreset_gpio.c | 2 +- >>> drivers/sysreset/sysreset_resetctl.c | 2 +- >>> drivers/sysreset/sysreset_syscon.c | 2 +- >>> drivers/sysreset/sysreset_watchdog.c | 40 ++++++++++++++++++++++------ >>> drivers/watchdog/wdt-uclass.c | 8 ++++++ >>> include/sysreset.h | 10 +++++++ >>> 9 files changed, 67 insertions(+), 13 deletions(-) >>> >> >> Applied to u-boot-marvell > > Mmmh, why u-boot-marvell, Because I'm handling watchdog related changed since a few years and we did not create a specific subsystem repo for this and I'm usually using my "marvell" one for this. > and why did this end up already in master? > Isn't that material for the next merge window? After all this changes > quite a bit, for a lot of boards, and I did not have a closer look at > the sunxi parts yet. I was hesitating also a bit. But since this patchset is on the list in v1 since over 2 months now (2021-08-21) I thought it was "ready" for inclusion now. We are at -rc1 and I think we still have enough time to fix any resulting problems in this release cycle. Do you see any specific issues? Thanks, Stefan