From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16BAC4363D for ; Fri, 2 Oct 2020 04:51:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57D4C20754 for ; Fri, 2 Oct 2020 04:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="HKxElXgq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57D4C20754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.1661.5024 (Exim 4.92) (envelope-from ) id 1kOD1l-0004Pg-Qr; Fri, 02 Oct 2020 04:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1661.5024; Fri, 02 Oct 2020 04:50:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOD1l-0004PZ-Mu; Fri, 02 Oct 2020 04:50:41 +0000 Received: by outflank-mailman (input) for mailman id 1661; Fri, 02 Oct 2020 04:50:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOD1j-0004PU-QG for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 04:50:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c38b9e92-c5e8-470d-9eb9-3413a05eee0e; Fri, 02 Oct 2020 04:50:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 450E9AD04; Fri, 2 Oct 2020 04:50:36 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOD1j-0004PU-QG for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 04:50:39 +0000 X-Inumbo-ID: c38b9e92-c5e8-470d-9eb9-3413a05eee0e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c38b9e92-c5e8-470d-9eb9-3413a05eee0e; Fri, 02 Oct 2020 04:50:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601614236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J/idnfpv/lIDFEdq+x6upDoD3zsCzNiwA4jbuPtNVBQ=; b=HKxElXgq8DYYV/9IkUwE2TxRxC46woRPr7S/o6FFNNi5MHDqW7kuZma7sIjDNTU2vPduKP u4In4r/Cb0KFYS6Zm6agqMor98qGWMtd0qD7FzYXjFi/Kfi3D8zSV15OZQG6e0bkqVWSE4 MEckAO/zGyNmFip6mPLJTgoDuDeXO3U= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 450E9AD04; Fri, 2 Oct 2020 04:50:36 +0000 (UTC) Subject: Re: [PATCH v3] tools/libs/stat: fix broken build To: Bertrand Marquis Cc: "open list:X86" , Ian Jackson , Wei Liu References: <20200912130836.11024-1-jgross@suse.com> <5232FD74-9636-4EF4-81F8-2EF7EE21D326@arm.com> <87CA2B55-B372-458C-82CC-2423B8AC3EEE@arm.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Fri, 2 Oct 2020 06:50:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87CA2B55-B372-458C-82CC-2423B8AC3EEE@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 01.10.20 18:38, Bertrand Marquis wrote: > Hi Juergen, > >> On 14 Sep 2020, at 11:58, Bertrand Marquis wrote: >> >> >> >>> On 12 Sep 2020, at 14:08, Juergen Gross wrote: >>> >>> Making getBridge() static triggered a build error with some gcc versions: >>> >>> error: 'strncpy' output may be truncated copying 15 bytes from a string of >>> length 255 [-Werror=stringop-truncation] >>> >>> Fix that by using a buffer with 256 bytes instead. >>> >>> Fixes: 6d0ec053907794 ("tools: split libxenstat into new tools/libs/stat directory") >>> Signed-off-by: Juergen Gross >> Reviewed-by: Bertrand Marquis > > Sorry i have to come back on this one. > > I still see an error compiling with Yocto on this one: > | inlined from 'xenstat_collect_networks' at xenstat_linux.c:306:2: > | xenstat_linux.c:81:6: error: 'strncpy' output may be truncated copying 255 bytes from a string of length 255 [-Werror=stringop-truncation] > | 81 | strncpy(result, de->d_name, resultLen); > | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > To solve it, I need to define devBridge[257] as devNoBrideg. IMHO this is a real compiler error. de->d_name is an array of 256 bytes, so doing strncpy() from that to another array of 256 bytes with a length of 256 won't truncate anything. Making devBridge one byte longer would be dangerous, as this would do a strncpy with length of 257 from a source with a length of 256 bytes only. BTW, I think Andrew? has tested my patch with a recent gcc which threw the original error without my patch, and it was fine with the patch. Either your compiler (assuming you are using gcc) has gained that error or you are missing an update fixing it. Juergen