What I meant is that upstream is actually tagging releases:

https://github.com/videolan/x265/releases

and therefore we should package the latest release, rather than a random commit.

Which means you should name the recipe x265_3.1.2.bb and set SRCREV to match the 3.1.2 tag. Going forward, the recipe should be updated the same way: rename file to the new version, update SRCREV.

Another problem is that github is not synced properly with the original x265 repo, and is several months behind. SRC_URI should probably refer to https://bitbucket.org/multicoreware/x265/src/default/

Alternatively, don't use git at all and fetch tarballs: http://ftp.videolan.org/pub/videolan/x265/

Alex

On Sat, 8 Feb 2020 at 00:28, Scott Branden <scott.branden@broadcom.com> wrote:

Hi Alex,

more comment below about PV.

On 2020-02-07 2:26 p.m., Scott Branden wrote:

HI Alex,

On 2020-02-07 2:09 p.m., Alexander Kanavin wrote:

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

I do have a patch for ffmpeg and have tested that works.  I'll add that to the patch series.

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

You'll have to help me out a little here on exactly what you want. 

This is based off the stable tag.
I already specified the SRCREV in the recipe.

Do you want PV to be:
PV = "stable+git${SRCPV}"

?

I was trying to follow the x264 recipe.

Do you want me do something like name the recipe x265_stable.bb instead and not specify PV?

Alex

On Fri, 7 Feb 2020 at 22:35, Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote:

Add x265 recipe from latest revision of stable branch.

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb
new file mode 100644
index 0000000000..7c230e2b1e
--- /dev/null
+++ b/meta/recipes-multimedia/x265/x265_git.bb
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--
2.17.1

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core