From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F416FC433E9 for ; Wed, 3 Mar 2021 13:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0DBA64EEC for ; Wed, 3 Mar 2021 13:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445699AbhCCNrg (ORCPT ); Wed, 3 Mar 2021 08:47:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349655AbhCCLAI (ORCPT ); Wed, 3 Mar 2021 06:00:08 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FEAC061788 for ; Wed, 3 Mar 2021 02:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202012; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RgKmcd8Y2kjZxyQZf6Rm/UlmUS6YJhPJkPSy8kcTa5E=; b=rmfHG1dCneW+9c3ZvQhiKCjQ1/ yn4F6zrJaJlgneU6ZrbT6DmX2bI/8uo+sL/9kTR5zagicV/1LJvLvDOnUaZJfPtID/EYp1SyDQvJI MgaYq9hyBc7+N8JRAyZgpl64IvVJ51kLwGkl9kvc+ikTXgvMBakOEEO0zvnhYZK8E3/Udt8ctiM1G xhdZr7mpehZOZ9P9kf6HYoemi72OVIXuAPyVRK3elZL0lsrEP6eMfuX7rQ2j7FPVPoq92c38gJ0xo zX607DPDxm8Sch419lscBxsipPlZk72i431whfwC4oNJQj929JkYYXT02wziJMEPuurIWz/IvohHd UfQpsBGQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:64686 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHPDR-0004gC-8O; Wed, 03 Mar 2021 11:58:53 +0100 Subject: Re: [PATCH v7] drm: Use USB controller's DMA mask when importing dmabufs To: Thomas Zimmermann , daniel@ffwll.ch, airlied@linux.ie, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sumit.semwal@linaro.org, christian.koenig@amd.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, sean@poorly.run, stern@rowland.harvard.edu, dan.carpenter@oracle.com Cc: dri-devel@lists.freedesktop.org, Pavel Machek , Daniel Vetter , Christoph Hellwig , stable@vger.kernel.org References: <20210303084512.25635-1-tzimmermann@suse.de> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 3 Mar 2021 11:58:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210303084512.25635-1-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Den 03.03.2021 09.45, skrev Thomas Zimmermann: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Therefore importing dmabuf into a USB-based driver > fails, which breaks joining and mirroring of display in X11. > > For USB devices, pick the associated USB controller as attachment device. > This allows the DRM import helpers to perform the DMA setup. If the DMA > controller does not support DMA transfers, we're out of luck and cannot > import. Our current USB-based DRM drivers don't use DMA, so the actual > DMA device is not important. > > Drivers should use DRM_GEM_SHMEM_DROVER_OPS_USB to initialize their > instance of struct drm_driver. > This doesn't seem to be the case anymore. > Tested by joining/mirroring displays of udl and radeon un der Gnome/X11. s/un der/under/ > > v7: > * fix use-before-init bug in gm12u320 (Dan) > v6: > * implement workaround in DRM drivers and hold reference to > DMA device while USB device is in use > * remove dev_is_usb() (Greg) > * collapse USB helper into usb_intf_get_dma_device() (Alan) > * integrate Daniel's TODO statement (Daniel) > * fix typos (Greg) > v5: > * provide a helper for USB interfaces (Alan) > * add FIXME item to documentation and TODO list (Daniel) > v4: > * implement workaround with USB helper functions (Greg) > * use struct usb_device->bus->sysdev as DMA device (Takashi) > v3: > * drop gem_create_object > * use DMA mask of USB controller, if any (Daniel, Christian, Noralf) > v2: > * move fix to importer side (Christian, Daniel) > * update SHMEM and CMA helpers for new PRIME callbacks > > Signed-off-by: Thomas Zimmermann > Fixes: 6eb0233ec2d0 ("usb: don't inherity DMA properties for USB devices") > Tested-by: Pavel Machek > Reviewed-by: Greg Kroah-Hartman > Acked-by: Christian König > Acked-by: Daniel Vetter > Cc: Christoph Hellwig > Cc: Greg Kroah-Hartman > Cc: # v5.10+ > Signed-off-by: Thomas Zimmermann > --- > Documentation/gpu/todo.rst | 21 +++++++++++++++++++++ > drivers/gpu/drm/tiny/gm12u320.c | 28 ++++++++++++++++++++++++++-- > drivers/gpu/drm/udl/udl_drv.c | 17 +++++++++++++++++ > drivers/gpu/drm/udl/udl_drv.h | 1 + > drivers/gpu/drm/udl/udl_main.c | 9 +++++++++ > drivers/usb/core/usb.c | 32 ++++++++++++++++++++++++++++++++ > include/linux/usb.h | 2 ++ > 7 files changed, 108 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c > index 0b4f4f2af1ef..4fe372f43cf5 100644 > --- a/drivers/gpu/drm/tiny/gm12u320.c > +++ b/drivers/gpu/drm/tiny/gm12u320.c [...] > @@ -638,12 +656,15 @@ static int gm12u320_usb_probe(struct usb_interface *interface, > struct gm12u320_device, dev); > if (IS_ERR(gm12u320)) > return PTR_ERR(gm12u320); > + dev = &gm12u320->dev; > + > + gm12u320->dmadev = usb_intf_get_dma_device(to_usb_interface(dev->dev)); > + if (!gm12u320->dmadev) > + drm_warn(dev, "buffer sharing not supported"); /* not an error */ > When implementing this in my own driver I discovered that this device ref will leak if probing fails after this. I've done it like this: gdrm->dmadev = usb_intf_get_dma_device(intf); if (!gdrm->dmadev) dev_warn(dev, "buffer sharing not supported"); ret = drm_dev_register(drm, 0); if (ret) { put_device(gdrm->dmadev); return ret; } An even better solution would be to have a devm_ version of the function. Noralf. > INIT_DELAYED_WORK(&gm12u320->fb_update.work, gm12u320_fb_update_work); > mutex_init(&gm12u320->fb_update.lock); > > - dev = &gm12u320->dev; > - > ret = drmm_mode_config_init(dev); > if (ret) > return ret; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69940C433DB for ; Wed, 3 Mar 2021 10:58:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8369864E6C for ; Wed, 3 Mar 2021 10:58:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8369864E6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tronnes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8B776E10F; Wed, 3 Mar 2021 10:58:57 +0000 (UTC) Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 853226E10F for ; Wed, 3 Mar 2021 10:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202012; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RgKmcd8Y2kjZxyQZf6Rm/UlmUS6YJhPJkPSy8kcTa5E=; b=rmfHG1dCneW+9c3ZvQhiKCjQ1/ yn4F6zrJaJlgneU6ZrbT6DmX2bI/8uo+sL/9kTR5zagicV/1LJvLvDOnUaZJfPtID/EYp1SyDQvJI MgaYq9hyBc7+N8JRAyZgpl64IvVJ51kLwGkl9kvc+ikTXgvMBakOEEO0zvnhYZK8E3/Udt8ctiM1G xhdZr7mpehZOZ9P9kf6HYoemi72OVIXuAPyVRK3elZL0lsrEP6eMfuX7rQ2j7FPVPoq92c38gJ0xo zX607DPDxm8Sch419lscBxsipPlZk72i431whfwC4oNJQj929JkYYXT02wziJMEPuurIWz/IvohHd UfQpsBGQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:64686 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lHPDR-0004gC-8O; Wed, 03 Mar 2021 11:58:53 +0100 Subject: Re: [PATCH v7] drm: Use USB controller's DMA mask when importing dmabufs To: Thomas Zimmermann , daniel@ffwll.ch, airlied@linux.ie, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sumit.semwal@linaro.org, christian.koenig@amd.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, sean@poorly.run, stern@rowland.harvard.edu, dan.carpenter@oracle.com References: <20210303084512.25635-1-tzimmermann@suse.de> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 3 Mar 2021 11:58:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210303084512.25635-1-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , stable@vger.kernel.org, Pavel Machek , dri-devel@lists.freedesktop.org, Christoph Hellwig Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" CgpEZW4gMDMuMDMuMjAyMSAwOS40NSwgc2tyZXYgVGhvbWFzIFppbW1lcm1hbm46Cj4gVVNCIGRl dmljZXMgY2Fubm90IHBlcmZvcm0gRE1BIGFuZCBoZW5jZSBoYXZlIG5vIGRtYV9tYXNrIHNldCBp biB0aGVpcgo+IGRldmljZSBzdHJ1Y3R1cmUuIFRoZXJlZm9yZSBpbXBvcnRpbmcgZG1hYnVmIGlu dG8gYSBVU0ItYmFzZWQgZHJpdmVyCj4gZmFpbHMsIHdoaWNoIGJyZWFrcyBqb2luaW5nIGFuZCBt aXJyb3Jpbmcgb2YgZGlzcGxheSBpbiBYMTEuCj4gCj4gRm9yIFVTQiBkZXZpY2VzLCBwaWNrIHRo ZSBhc3NvY2lhdGVkIFVTQiBjb250cm9sbGVyIGFzIGF0dGFjaG1lbnQgZGV2aWNlLgo+IFRoaXMg YWxsb3dzIHRoZSBEUk0gaW1wb3J0IGhlbHBlcnMgdG8gcGVyZm9ybSB0aGUgRE1BIHNldHVwLiBJ ZiB0aGUgRE1BCj4gY29udHJvbGxlciBkb2VzIG5vdCBzdXBwb3J0IERNQSB0cmFuc2ZlcnMsIHdl J3JlIG91dCBvZiBsdWNrIGFuZCBjYW5ub3QKPiBpbXBvcnQuIE91ciBjdXJyZW50IFVTQi1iYXNl ZCBEUk0gZHJpdmVycyBkb24ndCB1c2UgRE1BLCBzbyB0aGUgYWN0dWFsCj4gRE1BIGRldmljZSBp cyBub3QgaW1wb3J0YW50Lgo+IAo+IERyaXZlcnMgc2hvdWxkIHVzZSBEUk1fR0VNX1NITUVNX0RS T1ZFUl9PUFNfVVNCIHRvIGluaXRpYWxpemUgdGhlaXIKPiBpbnN0YW5jZSBvZiBzdHJ1Y3QgZHJt X2RyaXZlci4KPiAKClRoaXMgZG9lc24ndCBzZWVtIHRvIGJlIHRoZSBjYXNlIGFueW1vcmUuCgo+ IFRlc3RlZCBieSBqb2luaW5nL21pcnJvcmluZyBkaXNwbGF5cyBvZiB1ZGwgYW5kIHJhZGVvbiB1 biBkZXIgR25vbWUvWDExLgoKcy91biBkZXIvdW5kZXIvCgo+IAo+IHY3Ogo+IAkqIGZpeCB1c2Ut YmVmb3JlLWluaXQgYnVnIGluIGdtMTJ1MzIwIChEYW4pCj4gdjY6Cj4gCSogaW1wbGVtZW50IHdv cmthcm91bmQgaW4gRFJNIGRyaXZlcnMgYW5kIGhvbGQgcmVmZXJlbmNlIHRvCj4gCSAgRE1BIGRl dmljZSB3aGlsZSBVU0IgZGV2aWNlIGlzIGluIHVzZQo+IAkqIHJlbW92ZSBkZXZfaXNfdXNiKCkg KEdyZWcpCj4gCSogY29sbGFwc2UgVVNCIGhlbHBlciBpbnRvIHVzYl9pbnRmX2dldF9kbWFfZGV2 aWNlKCkgKEFsYW4pCj4gCSogaW50ZWdyYXRlIERhbmllbCdzIFRPRE8gc3RhdGVtZW50IChEYW5p ZWwpCj4gCSogZml4IHR5cG9zIChHcmVnKQo+IHY1Ogo+IAkqIHByb3ZpZGUgYSBoZWxwZXIgZm9y IFVTQiBpbnRlcmZhY2VzIChBbGFuKQo+IAkqIGFkZCBGSVhNRSBpdGVtIHRvIGRvY3VtZW50YXRp b24gYW5kIFRPRE8gbGlzdCAoRGFuaWVsKQo+IHY0Ogo+IAkqIGltcGxlbWVudCB3b3JrYXJvdW5k IHdpdGggVVNCIGhlbHBlciBmdW5jdGlvbnMgKEdyZWcpCj4gCSogdXNlIHN0cnVjdCB1c2JfZGV2 aWNlLT5idXMtPnN5c2RldiBhcyBETUEgZGV2aWNlIChUYWthc2hpKQo+IHYzOgo+IAkqIGRyb3Ag Z2VtX2NyZWF0ZV9vYmplY3QKPiAJKiB1c2UgRE1BIG1hc2sgb2YgVVNCIGNvbnRyb2xsZXIsIGlm IGFueSAoRGFuaWVsLCBDaHJpc3RpYW4sIE5vcmFsZikKPiB2MjoKPiAJKiBtb3ZlIGZpeCB0byBp bXBvcnRlciBzaWRlIChDaHJpc3RpYW4sIERhbmllbCkKPiAJKiB1cGRhdGUgU0hNRU0gYW5kIENN QSBoZWxwZXJzIGZvciBuZXcgUFJJTUUgY2FsbGJhY2tzCj4gCj4gU2lnbmVkLW9mZi1ieTogVGhv bWFzIFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+Cj4gRml4ZXM6IDZlYjAyMzNlYzJk MCAoInVzYjogZG9uJ3QgaW5oZXJpdHkgRE1BIHByb3BlcnRpZXMgZm9yIFVTQiBkZXZpY2VzIikK PiBUZXN0ZWQtYnk6IFBhdmVsIE1hY2hlayA8cGF2ZWxAdWN3LmN6Pgo+IFJldmlld2VkLWJ5OiBH cmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+IEFja2VkLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gQWNrZWQtYnk6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IENocmlzdG9waCBI ZWxsd2lnIDxoY2hAbHN0LmRlPgo+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51 eGZvdW5kYXRpb24ub3JnPgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NS4xMCsK PiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4K PiAtLS0KPiAgRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QgICAgICB8IDIxICsrKysrKysrKysr KysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vdGlueS9nbTEydTMyMC5jIHwgMjggKysrKysr KysrKysrKysrKysrKysrKysrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9kcnYuYyAg IHwgMTcgKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfZHJ2Lmgg ICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfbWFpbi5jICB8ICA5ICsrKysrKysr Kwo+ICBkcml2ZXJzL3VzYi9jb3JlL3VzYi5jICAgICAgICAgIHwgMzIgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC91c2IuaCAgICAgICAgICAgICB8ICAy ICsrCj4gIDcgZmlsZXMgY2hhbmdlZCwgMTA4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90aW55L2dtMTJ1MzIwLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdGlueS9nbTEydTMyMC5jCj4gaW5kZXggMGI0ZjRmMmFmMWVmLi40ZmUzNzJm NDNjZjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3RpbnkvZ20xMnUzMjAuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS90aW55L2dtMTJ1MzIwLmMKClsuLi5dCgo+IEBAIC02MzgsMTIg KzY1NiwxNSBAQCBzdGF0aWMgaW50IGdtMTJ1MzIwX3VzYl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVy ZmFjZSAqaW50ZXJmYWNlLAo+ICAJCQkJICAgICAgc3RydWN0IGdtMTJ1MzIwX2RldmljZSwgZGV2 KTsKPiAgCWlmIChJU19FUlIoZ20xMnUzMjApKQo+ICAJCXJldHVybiBQVFJfRVJSKGdtMTJ1MzIw KTsKPiArCWRldiA9ICZnbTEydTMyMC0+ZGV2Owo+ICsKPiArCWdtMTJ1MzIwLT5kbWFkZXYgPSB1 c2JfaW50Zl9nZXRfZG1hX2RldmljZSh0b191c2JfaW50ZXJmYWNlKGRldi0+ZGV2KSk7Cj4gKwlp ZiAoIWdtMTJ1MzIwLT5kbWFkZXYpCj4gKwkJZHJtX3dhcm4oZGV2LCAiYnVmZmVyIHNoYXJpbmcg bm90IHN1cHBvcnRlZCIpOyAvKiBub3QgYW4gZXJyb3IgKi8KPiAgCgpXaGVuIGltcGxlbWVudGlu ZyB0aGlzIGluIG15IG93biBkcml2ZXIgSSBkaXNjb3ZlcmVkIHRoYXQgdGhpcyBkZXZpY2UKcmVm IHdpbGwgbGVhayBpZiBwcm9iaW5nIGZhaWxzIGFmdGVyIHRoaXMuCgpJJ3ZlIGRvbmUgaXQgbGlr ZSB0aGlzOgoKCWdkcm0tPmRtYWRldiA9IHVzYl9pbnRmX2dldF9kbWFfZGV2aWNlKGludGYpOwoJ aWYgKCFnZHJtLT5kbWFkZXYpCgkJZGV2X3dhcm4oZGV2LCAiYnVmZmVyIHNoYXJpbmcgbm90IHN1 cHBvcnRlZCIpOwoKCXJldCA9IGRybV9kZXZfcmVnaXN0ZXIoZHJtLCAwKTsKCWlmIChyZXQpIHsK CQlwdXRfZGV2aWNlKGdkcm0tPmRtYWRldik7CgkJcmV0dXJuIHJldDsKCX0KCkFuIGV2ZW4gYmV0 dGVyIHNvbHV0aW9uIHdvdWxkIGJlIHRvIGhhdmUgYSBkZXZtXyB2ZXJzaW9uIG9mIHRoZSBmdW5j dGlvbi4KCk5vcmFsZi4KCj4gIAlJTklUX0RFTEFZRURfV09SSygmZ20xMnUzMjAtPmZiX3VwZGF0 ZS53b3JrLCBnbTEydTMyMF9mYl91cGRhdGVfd29yayk7Cj4gIAltdXRleF9pbml0KCZnbTEydTMy MC0+ZmJfdXBkYXRlLmxvY2spOwo+ICAKPiAtCWRldiA9ICZnbTEydTMyMC0+ZGV2Owo+IC0KPiAg CXJldCA9IGRybW1fbW9kZV9jb25maWdfaW5pdChkZXYpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1 cm4gcmV0OwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK