All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH] qemu-sockets: fix unix socket path copy (again)
Date: Wed, 1 Sep 2021 12:20:23 +0300	[thread overview]
Message-ID: <f12881b4-beae-2b81-5450-a0a2680cd8ba@msgid.tls.msk.ru> (raw)
In-Reply-To: <YS9EAOX4g7zIjxhp@redhat.com>

On 01.09.2021 12:12, Daniel P. Berrangé wrote:
>> Seems right to me, however there are some notes in libc bits/socket.h
>> /* Structure large enough to hold any socket address (with the historical
>>     exception of AF_UNIX).  */
>>
>> And also this
>> https://idea.popcount.org/2019-12-06-addressing/#fn:sockaddr_storage
>>
>> I must say I feel confused by those comments :) Is it large enough or not??
> 
>  From 'man unix(7)'

I quoted this very place in other thread yesterday. And also included
the kernel code which actually does this.

But the question here is about different issue: is sockaddr_un larger
than sockaddr_storage?

/mjt


  reply	other threads:[~2021-09-01  9:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 18:26 [PATCH] qemu-sockets: fix unix socket path copy (again) Michael Tokarev
2021-08-31 19:21 ` Marc-André Lureau
2021-08-31 19:26   ` Michael Tokarev
2021-09-01  9:12   ` Daniel P. Berrangé
2021-09-01  9:20     ` Michael Tokarev [this message]
2021-08-31 19:47 ` Peter Maydell
2021-09-01  8:29   ` Michael Tokarev
2021-09-01  9:52     ` Peter Maydell
2021-09-01 11:45       ` Michael Tokarev
2021-09-01 11:58         ` Daniel P. Berrangé
2021-09-01 11:57     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f12881b4-beae-2b81-5450-a0a2680cd8ba@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.