From: Martin Wilck <mwilck@suse.com>
To: Chao Leng <lengchao@huawei.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>,
Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: rdma/tcp: call nvme_mpath_stop() from reconnect workqueue
Date: Tue, 27 Apr 2021 10:56:23 +0200 [thread overview]
Message-ID: <f129a005ba4be672a787a0d9a5cace910bf4f4a4.camel@suse.com> (raw)
In-Reply-To: <069d47c70946bb5b7aabc2f0650c312fcc0b4157.camel@suse.com>
On Tue, 2021-04-27 at 09:30 +0200, Martin Wilck wrote:
> On Tue, 2021-04-27 at 09:45 +0800, Chao Leng wrote:
> > >
> > > So ... resubmit and cc stable as Sagi suggested, or work out
> > > something
> > > else?
> > Another option:call nvme_mpath_stop in nvme_mpath_init.
> > In this way, transport drivers do not care mpath detail.
>
> That would require that we determine in nvme_mpath_init() whether
> we're
> called for the first time for the given controller, or whether the
> controller is re-initializing. It's not obvious to me how to do that
> reliably without introducing a new state flag.
>
I'll submit a v3 with changed subject as suggested by Sagi. That will
fix the list corruption; we can figure out a better solution later.
Martin
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-27 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:38 [PATCH v2] nvme: rdma/tcp: call nvme_mpath_stop() from reconnect workqueue mwilck
[not found] ` <CAFL455k3aBLcZrZPq=Q-9aws4UesstA5gSOr_E7mEFrLT+KbKw@mail.gmail.com>
2021-04-23 16:43 ` Martin Wilck
2021-04-23 17:09 ` Martin Wilck
2021-04-24 0:21 ` Sagi Grimberg
2021-04-26 14:51 ` Christoph Hellwig
2021-04-26 16:27 ` Martin Wilck
2021-04-27 1:45 ` Chao Leng
2021-04-27 7:30 ` Martin Wilck
2021-04-27 8:56 ` Martin Wilck [this message]
2021-04-27 9:04 ` Martin Wilck
2021-04-25 1:07 ` Chao Leng
2021-04-25 11:34 ` Hannes Reinecke
2021-04-26 2:31 ` Chao Leng
2021-04-26 15:18 ` Martin Wilck
2021-04-26 9:34 ` Martin Wilck
2021-04-26 10:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f129a005ba4be672a787a0d9a5cace910bf4f4a4.camel@suse.com \
--to=mwilck@suse.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.