From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166C42FAD for ; Wed, 18 Aug 2021 15:55:26 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id w4so4470777ljh.13 for ; Wed, 18 Aug 2021 08:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FDEHOwK/tV+p4BwibJ2eZxjOpc4MiqVcjf+8RCPnl/I=; b=H0RQfIKG86hjucXIS4WiNewr/HEa0soca6FW/SoC/rnEEopBHfFKy8EBd0pGQounk/ Oq9/0nUk373C3fZI609KQfoxLIlCX33VL4jD/UoSCTP1jNz94LT73hGlRg0OGe2pZPMl Oibirrv4BUfG5Z6A9XvafJxus+f47S5hMtsDMR0PfSid8tbadkJELX8svkntbABSkpcD RimCcpLAmvdux+9g7Wlco/fYko0MP+hTZL/CMoVJHvmpnxNhBGRdHEtQ4ME9XbOrtsOg Ou9Bf0Prbo4kHm9SvJmQDHot8vFIRpjN5c2/oXbQGbbtlY4/TvTgQHm5WSs8SXzEzrL/ q0pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FDEHOwK/tV+p4BwibJ2eZxjOpc4MiqVcjf+8RCPnl/I=; b=KDnIJiizsCpXOavkpUDwsMQcqRHpbAG+Eei28faz+bV2lFIHYW11t8BvRHsVQWX+G8 voTArBJqJ15vDfKf8xpURPCJoxI9qfl+COzCTeD48dNR4gkdpCMrTx4QC2PBy4XidM6T MrAAQzpI+aU3rn51ltwwVRZ9ysKiML9cAMFvfLuUkaJLHb9RUg4dcFOpK2/mMFnV5758 GM2yI3nFf5YyEGL+vxjXEX6AqKUZukWEmsLasW4ouEZFHw4HNflN3mAO1w+3pyYwYbOz Kl22FBdoUWjZ0g0VkhA/jvDZCr8J3FxxZc/8l0VmpBiqBIOxlGv7IEs3ZvugR+i6D3il EzaQ== X-Gm-Message-State: AOAM530su89Wm8VqjO25i6ys0OPHvRTOFld9ID2bjp+dcCNw9162qeMK 39Yuz1rLN/+b3jBx2mBc94A= X-Google-Smtp-Source: ABdhPJwH2B3VgRzJIvI+pIkKDsVXz6Nb3IHX68qBDgW7hPMqkLurd3vlILu0yEDQld58r5qYiUr6VQ== X-Received: by 2002:a2e:300a:: with SMTP id w10mr8608460ljw.510.1629302124200; Wed, 18 Aug 2021 08:55:24 -0700 (PDT) Received: from [192.168.2.145] (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.googlemail.com with ESMTPSA id y8sm7917lfh.249.2021.08.18.08.55.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 08:55:23 -0700 (PDT) Subject: Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper To: Ulf Hansson , Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk References: <20210818035533.ieqkexltfvvf2p4n@vireshk-i7> <5b2a80c1-9743-e633-6257-ede94c8a274c@gmail.com> <20210818043131.7klajx6drvvkftoc@vireshk-i7> <20210818045307.4brb6cafkh3adjth@vireshk-i7> <080469b3-612b-3a34-86e5-7037a64de2fe@gmail.com> <20210818055849.ybfajzu75ecpdrbn@vireshk-i7> <20210818062723.dqamssfkf7lf7cf7@vireshk-i7> <20210818091417.dvlnsxlgybdsn76x@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Wed, 18 Aug 2021 18:55:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit 18.08.2021 12:41, Ulf Hansson пишет: > On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: >> >> On 18-08-21, 10:29, Ulf Hansson wrote: >>> Me and Dmitry discussed adding a new genpd callback for this. I agreed >>> that it seems like a reasonable thing to add, if he insists. Either way gives the equal result. The new callback allows to remove the boilerplate dev_pm_opp_set_rate(clk_get_rate() code from the rpm-resume of consumer devices, that's it. >>> The intent was to invoke the new callback from __genpd_dev_pm_attach() >>> when the device has been attached to its genpd. This allows the >>> callback, to invoke clk_get_rate() and then dev_pm_opp_set_rate(), to >>> update the vote according to the current state of the HW. >> >> I wouldn't call dev_pm_opp_set_rate() from there, since it means >> configure and enable (both) for different resources, clk, regulator, >> genpd, etc.. > > Right, good point! > > dev_pm_opp_set_rate() is best called from consumer drivers, as they > need to be in control. >> What we need here is just configure. So something like this then: The intent wasn't to use dev_pm_opp_set_rate() from __genpd_dev_pm_attach(), but to set genpd->rpm_pstate in accordance to the h/w configuration. On Tegra we have a chain of PDs and it's not trivial to convert the device's OPP into pstate because only the parent domain can translate the required OPP. Viresh, please take a look at what I did in [1]. Maybe it could be done in another way. [1] https://patchwork.ozlabs.org/project/linux-tegra/patch/20210701232728.23591-3-digetx@gmail.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33ACAC4338F for ; Wed, 18 Aug 2021 15:56:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2F186101A for ; Wed, 18 Aug 2021 15:56:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2F186101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=FiE31kqWKo/pTCcxiPuh7oHeImU8k4ZlvgsM5xZ0Qg4=; b=TRD4OVMZMsqxJf5sc9oWg1XMOG 6XlSP5u2unvx4BXjinPpE2WK5C7cWtQJ6H4X6EL0wNbkNXAnucyDhDg6rl3bSQG6ruHWQW2XNGO3s k9xUkPmwNdEqyB7i5kP1hKi7F5GDhW1DQlIBfjgEpGUoEmiJFu+X1L/qxt9k6lD/Er6dnbZ21NwgL ez2anpGWiRmgPBAArhBN/e7JlEb0ZIegdlyKg4/qA2LKP1qElWrcw4n0lmqTKOn4Nq2SHc8zL/Rww Yugk/5iUo7P47LaeZelTvTdTIqBRtBV6RFO08YrnYmm5+bjoFTYAaxWorXuiwYNbJGqJQ5ZNXiDqJ 4eiTQzKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGNud-0067Qw-9i; Wed, 18 Aug 2021 15:55:31 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGNuX-0067P7-Iu for linux-mtd@lists.infradead.org; Wed, 18 Aug 2021 15:55:29 +0000 Received: by mail-lj1-x232.google.com with SMTP id y6so5993549lje.2 for ; Wed, 18 Aug 2021 08:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FDEHOwK/tV+p4BwibJ2eZxjOpc4MiqVcjf+8RCPnl/I=; b=H0RQfIKG86hjucXIS4WiNewr/HEa0soca6FW/SoC/rnEEopBHfFKy8EBd0pGQounk/ Oq9/0nUk373C3fZI609KQfoxLIlCX33VL4jD/UoSCTP1jNz94LT73hGlRg0OGe2pZPMl Oibirrv4BUfG5Z6A9XvafJxus+f47S5hMtsDMR0PfSid8tbadkJELX8svkntbABSkpcD RimCcpLAmvdux+9g7Wlco/fYko0MP+hTZL/CMoVJHvmpnxNhBGRdHEtQ4ME9XbOrtsOg Ou9Bf0Prbo4kHm9SvJmQDHot8vFIRpjN5c2/oXbQGbbtlY4/TvTgQHm5WSs8SXzEzrL/ q0pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FDEHOwK/tV+p4BwibJ2eZxjOpc4MiqVcjf+8RCPnl/I=; b=bIEDOgn04ZhA9p+1UQ//e4S3lggbsAr05Ws9VDCrv3ctX4qMoiifIw5+2/i8CIhLQU DMX2osB98iu57O4DP2ycaE8rB23wRTMQJksqz8SKv37azitOu+nCjDkdz4lIo7AcplUY 4PHNXBmOB+5iQB3uy7wSvAT4NILTIvXy0004/42pV9F3LMwXCpQUXzeC4xiZ41mLlDA5 Gd3CADdboAHDqZEUnW5S9oFQ1jZ/AYloNkXtXj/umnCaCZkWyTtXwO/2kfc1n9w8TRex bxHjzETyy5RN43/7HkY3GPBGW+V7JVuQrK/SXDFAXHVhg+0PhvDbgEhU6KDcnVR/zFJR Qmdg== X-Gm-Message-State: AOAM533hECX5E3cVljOkk/eGMvWLXM07hJ9fSHcTtE2tUgkfCJpBHK4z Q0Ifdlf16nfFQ6UdCCwnQc0= X-Google-Smtp-Source: ABdhPJwH2B3VgRzJIvI+pIkKDsVXz6Nb3IHX68qBDgW7hPMqkLurd3vlILu0yEDQld58r5qYiUr6VQ== X-Received: by 2002:a2e:300a:: with SMTP id w10mr8608460ljw.510.1629302124200; Wed, 18 Aug 2021 08:55:24 -0700 (PDT) Received: from [192.168.2.145] (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.googlemail.com with ESMTPSA id y8sm7917lfh.249.2021.08.18.08.55.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 08:55:23 -0700 (PDT) Subject: Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper To: Ulf Hansson , Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk References: <20210818035533.ieqkexltfvvf2p4n@vireshk-i7> <5b2a80c1-9743-e633-6257-ede94c8a274c@gmail.com> <20210818043131.7klajx6drvvkftoc@vireshk-i7> <20210818045307.4brb6cafkh3adjth@vireshk-i7> <080469b3-612b-3a34-86e5-7037a64de2fe@gmail.com> <20210818055849.ybfajzu75ecpdrbn@vireshk-i7> <20210818062723.dqamssfkf7lf7cf7@vireshk-i7> <20210818091417.dvlnsxlgybdsn76x@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Wed, 18 Aug 2021 18:55:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_085525_684465_4B62C310 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org MTguMDguMjAyMSAxMjo0MSwgVWxmIEhhbnNzb24g0L/QuNGI0LXRgjoKPiBPbiBXZWQsIDE4IEF1 ZyAyMDIxIGF0IDExOjE0LCBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPiB3 cm90ZToKPj4KPj4gT24gMTgtMDgtMjEsIDEwOjI5LCBVbGYgSGFuc3NvbiB3cm90ZToKPj4+IE1l IGFuZCBEbWl0cnkgZGlzY3Vzc2VkIGFkZGluZyBhIG5ldyBnZW5wZCBjYWxsYmFjayBmb3IgdGhp cy4gSSBhZ3JlZWQKPj4+IHRoYXQgaXQgc2VlbXMgbGlrZSBhIHJlYXNvbmFibGUgdGhpbmcgdG8g YWRkLCBpZiBoZSBpbnNpc3RzLgoKRWl0aGVyIHdheSBnaXZlcyB0aGUgZXF1YWwgcmVzdWx0LiBU aGUgbmV3IGNhbGxiYWNrIGFsbG93cyB0byByZW1vdmUgdGhlCmJvaWxlcnBsYXRlIGRldl9wbV9v cHBfc2V0X3JhdGUoY2xrX2dldF9yYXRlKCkgY29kZSBmcm9tIHRoZSBycG0tcmVzdW1lCm9mIGNv bnN1bWVyIGRldmljZXMsIHRoYXQncyBpdC4KCj4+PiBUaGUgaW50ZW50IHdhcyB0byBpbnZva2Ug dGhlIG5ldyBjYWxsYmFjayBmcm9tIF9fZ2VucGRfZGV2X3BtX2F0dGFjaCgpCj4+PiB3aGVuIHRo ZSBkZXZpY2UgaGFzIGJlZW4gYXR0YWNoZWQgdG8gaXRzIGdlbnBkLiBUaGlzIGFsbG93cyB0aGUK Pj4+IGNhbGxiYWNrLCB0byBpbnZva2UgY2xrX2dldF9yYXRlKCkgYW5kIHRoZW4gZGV2X3BtX29w cF9zZXRfcmF0ZSgpLCB0bwo+Pj4gdXBkYXRlIHRoZSB2b3RlIGFjY29yZGluZyB0byB0aGUgY3Vy cmVudCBzdGF0ZSBvZiB0aGUgSFcuCj4+Cj4+IEkgd291bGRuJ3QgY2FsbCBkZXZfcG1fb3BwX3Nl dF9yYXRlKCkgZnJvbSB0aGVyZSwgc2luY2UgaXQgbWVhbnMKPj4gY29uZmlndXJlIGFuZCBlbmFi bGUgKGJvdGgpIGZvciBkaWZmZXJlbnQgcmVzb3VyY2VzLCBjbGssIHJlZ3VsYXRvciwKPj4gZ2Vu cGQsIGV0Yy4uCj4gCj4gUmlnaHQsIGdvb2QgcG9pbnQhCj4gCj4gZGV2X3BtX29wcF9zZXRfcmF0 ZSgpIGlzIGJlc3QgY2FsbGVkIGZyb20gY29uc3VtZXIgZHJpdmVycywgYXMgdGhleQo+IG5lZWQg dG8gYmUgaW4gY29udHJvbC4KPj4gV2hhdCB3ZSBuZWVkIGhlcmUgaXMganVzdCBjb25maWd1cmUu IFNvIHNvbWV0aGluZyBsaWtlIHRoaXMgdGhlbjoKVGhlIGludGVudCB3YXNuJ3QgdG8gdXNlIGRl dl9wbV9vcHBfc2V0X3JhdGUoKSBmcm9tCl9fZ2VucGRfZGV2X3BtX2F0dGFjaCgpLCBidXQgdG8g c2V0IGdlbnBkLT5ycG1fcHN0YXRlIGluIGFjY29yZGFuY2UgdG8KdGhlIGgvdyBjb25maWd1cmF0 aW9uLgoKT24gVGVncmEgd2UgaGF2ZSBhIGNoYWluIG9mIFBEcyBhbmQgaXQncyBub3QgdHJpdmlh bCB0byBjb252ZXJ0IHRoZQpkZXZpY2UncyBPUFAgaW50byBwc3RhdGUgYmVjYXVzZSBvbmx5IHRo ZSBwYXJlbnQgZG9tYWluIGNhbiB0cmFuc2xhdGUKdGhlIHJlcXVpcmVkIE9QUC4KClZpcmVzaCwg cGxlYXNlIHRha2UgYSBsb29rIGF0IHdoYXQgSSBkaWQgaW4gWzFdLiBNYXliZSBpdCBjb3VsZCBi ZSBkb25lCmluIGFub3RoZXIgd2F5LgoKWzFdCmh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcv cHJvamVjdC9saW51eC10ZWdyYS9wYXRjaC8yMDIxMDcwMTIzMjcyOC4yMzU5MS0zLWRpZ2V0eEBn bWFpbC5jb20vCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=