From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD22C433DB for ; Thu, 28 Jan 2021 20:02:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBA0764DF5 for ; Thu, 28 Jan 2021 20:02:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBA0764DF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.77442.140246 (Exim 4.92) (envelope-from ) id 1l5DUC-00047t-PV; Thu, 28 Jan 2021 20:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 77442.140246; Thu, 28 Jan 2021 20:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5DUC-00047m-Md; Thu, 28 Jan 2021 20:01:48 +0000 Received: by outflank-mailman (input) for mailman id 77442; Thu, 28 Jan 2021 20:01:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5DUA-00047f-Vv for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 20:01:47 +0000 Received: from mail-lj1-x22e.google.com (unknown [2a00:1450:4864:20::22e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 311d70e6-1491-4441-a507-14671e49e5f5; Thu, 28 Jan 2021 20:01:45 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id f2so7844854ljp.11 for ; Thu, 28 Jan 2021 12:01:45 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k30sm1769744lfo.166.2021.01.28.12.01.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 12:01:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 311d70e6-1491-4441-a507-14671e49e5f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=a8sCxpm8BjbOrDmAamUB94nVe5Kq0FQKMiaQCIiIbbk=; b=ljA/kWZ4CHHZ8/RuFbcFaPrzRe3elza3y6Hrs2cD3FSdqTtBmRw30srpaB3slDnwJe a/fl8L2QvPledaRgIv2x0OpyirF3w6P7IKdmiQCi4mz8BI6IG7bbaJ6qH+jji26/VUkO G0iFhq5B8wxFOnlbpaXy13RBIiN2X+BeYD05S9vhtaQgJfG5aDhEzj+hbde6zu68m09G oTpYhfud2KngaTaFwETqA8yPPJwbSjrJQYIvyCH6XonWWpXpNLOkwfnA/6gbk4CdPPEU FgssembHcpvxNGZdRJRMiPXcFDao2PbEiLiFaLkC3Yt3nAocWPo+EO2WE8frUMVWDy61 lFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=a8sCxpm8BjbOrDmAamUB94nVe5Kq0FQKMiaQCIiIbbk=; b=CWwLJCy2BpAdkiV8luLOQvI3UKSTMCNc2IGOIdu7Qz4uRjXLs1ZHl34aXNTOmHMONL R4m3Dau39oWBKDNOjowjSxld4kRV1DgCFYk5JnG4HmnONv3auASIKbAyw3moSdHrEuV0 nSgl/bess2QvVConUb8PmpmUP8aGSD3i+R24JxzDrv9yLGU5Awcq2zG48lgCD30Dkw/C nE4sly+f38dKinSXjdFAcEojd+EfsMY/LbUOcC6YluzzB69c13OxR1VY98oiiHDZZ9DQ 70dTZ0fTDYrUMDb34s2aifcwnbpoK+RWj9oXT/o/4kI1BHNS0YavuoueShoTc+iW1MEl 4qGA== X-Gm-Message-State: AOAM533GWKRicY9yIf6EpI/9GVatEfTu60WjoG7h7Ej/YBqlF6f2w9Zv n26F/LBMa1mFB9QLOXcky/ktdISy2mHUzQ== X-Google-Smtp-Source: ABdhPJzL3N1oHAcAjnnEFVVOQbwV+tj7SkC6608CPymlYeQPUcOweZKiu3qKnCXxSNS37xYurXYb8w== X-Received: by 2002:a2e:88c9:: with SMTP id a9mr488482ljk.107.1611864104605; Thu, 28 Jan 2021 12:01:44 -0800 (PST) Subject: Re: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common To: Jan Beulich Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Daniel De Graaf , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-10-git-send-email-olekstysh@gmail.com> <19fa20ec-739b-250a-19f5-c4cbafd632fa@gmail.com> <46d8a845-8cbc-365b-1032-f079bf1e7d67@suse.com> From: Oleksandr Message-ID: Date: Thu, 28 Jan 2021 22:01:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <46d8a845-8cbc-365b-1032-f079bf1e7d67@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 28.01.21 15:18, Jan Beulich wrote: Hi Jan > On 28.01.2021 13:06, Oleksandr wrote: >> On 28.01.21 12:52, Jan Beulich wrote: >> >> Hi Jan >> >>> On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: >>>> --- /dev/null >>>> +++ b/xen/include/xen/dm.h >>>> @@ -0,0 +1,41 @@ >>>> +/* >>>> + * Copyright (c) 2016 Citrix Systems Inc. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify it >>>> + * under the terms and conditions of the GNU General Public License, >>>> + * version 2, as published by the Free Software Foundation. >>>> + * >>>> + * This program is distributed in the hope it will be useful, but WITHOUT >>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>>> + * more details. >>>> + * >>>> + * You should have received a copy of the GNU General Public License along with >>>> + * this program; If not, see . >>>> + */ >>>> + >>>> +#ifndef __XEN_DM_H__ >>>> +#define __XEN_DM_H__ >>>> + >>>> +#include >>>> + >>>> +struct dmop_args { >>>> + domid_t domid; >>>> + unsigned int nr_bufs; >>>> + /* Reserve enough buf elements for all current hypercalls. */ >>>> + struct xen_dm_op_buf buf[2]; >>> So this is then the patch where the public header needs including, >>> to satisfy this use of a struct declared there independent of what >>> xen/sched.h includes. In fact public/xen.h needs including here >>> as well, I think, for domid_t. Otoh I can't see why you include >>> xen/sched.h. >> Yes, xen/sched.h indeed doesn't need to be included here, I mentioned >> that we could just replace >> >> it by xen/types.h (this is the minimum what we need here I think). As I >> understand public/xen.h is already included by public/hvm/dm_op.h... > But that's something you better wouldn't depend on anywhere. > What one public header does or does not include may change over > time. ok, will include public/xen.h as well. -- Regards, Oleksandr Tyshchenko