From: Hans Verkuil <hverkuil@xs4all.nl>
To: Johan Fjeldtvedt <jaffe1@gmail.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] pulse8-cec: store logical address mask
Date: Mon, 5 Sep 2016 15:02:10 +0200 [thread overview]
Message-ID: <f1337508-d648-7cbe-cd0b-b39021913815@xs4all.nl> (raw)
In-Reply-To: <20160830123129.24306-2-jaffe1@gmail.com>
On 08/30/2016 02:31 PM, Johan Fjeldtvedt wrote:
> In addition to setting the ACK mask, also set the logical address mask
> setting in the dongle. This is (and not the ACK mask) is persisted for
> use in autonomous mode.
>
> The logical address mask to use is deduced from the primary device type
> in adap->log_addrs.
>
> Signed-off-by: Johan Fjeldtvedt <jaffe1@gmail.com>
> ---
> drivers/staging/media/pulse8-cec/pulse8-cec.c | 34 +++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/drivers/staging/media/pulse8-cec/pulse8-cec.c b/drivers/staging/media/pulse8-cec/pulse8-cec.c
> index 1158ba9..ede285a 100644
> --- a/drivers/staging/media/pulse8-cec/pulse8-cec.c
> +++ b/drivers/staging/media/pulse8-cec/pulse8-cec.c
> @@ -498,6 +498,40 @@ static int pulse8_cec_adap_log_addr(struct cec_adapter *adap, u8 log_addr)
> if (err)
> goto unlock;
>
> + switch (adap->log_addrs.primary_device_type[0]) {
> + case CEC_OP_PRIM_DEVTYPE_TV:
> + mask = 0;
Is this right? Shouldn't it be 0x001?
> + break;
> + case CEC_OP_PRIM_DEVTYPE_RECORD:
> + mask = 0x206;
Note that cec.h has CEC_LOG_ADDR_MASK_ defines. It's better to use those.
Regards,
Hans
> + break;
> + case CEC_OP_PRIM_DEVTYPE_TUNER:
> + mask = 0x4C8;
> + break;
> + case CEC_OP_PRIM_DEVTYPE_PLAYBACK:
> + mask = 0x910;
> + break;
> + case CEC_OP_PRIM_DEVTYPE_AUDIOSYSTEM:
> + mask = 0x20;
> + break;
> + case CEC_OP_PRIM_DEVTYPE_SWITCH:
> + mask = 0x8000;
> + break;
> + case CEC_OP_PRIM_DEVTYPE_PROCESSOR:
> + mask = 0x4000;
> + break;
> + default:
> + mask = 0;
> + break;
> + }
> + cmd[0] = MSGCODE_SET_LOGICAL_ADDRESS_MASK;
> + cmd[1] = mask >> 8;
> + cmd[2] = mask & 0xff;
> + err = pulse8_send_and_wait(pulse8, cmd, 3,
> + MSGCODE_COMMAND_ACCEPTED, 0);
> + if (err)
> + goto unlock;
> +
> cmd[0] = MSGCODE_SET_DEFAULT_LOGICAL_ADDRESS;
> cmd[1] = log_addr;
> err = pulse8_send_and_wait(pulse8, cmd, 2,
>
prev parent reply other threads:[~2016-09-05 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 12:31 [PATCH 1/2] pulse8-cec: fixes Johan Fjeldtvedt
2016-08-30 12:31 ` [PATCH 2/2] pulse8-cec: store logical address mask Johan Fjeldtvedt
2016-09-05 13:02 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1337508-d648-7cbe-cd0b-b39021913815@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=jaffe1@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.