From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH 1/8] drm/ast: Unpin cursor BO during cleanup Date: Wed, 5 Jun 2019 09:56:13 +0200 Message-ID: References: <20190604154201.14460-1-tzimmermann@suse.de> <20190604154201.14460-2-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0818741858==" Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id B28A288007 for ; Wed, 5 Jun 2019 07:56:20 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst , kraxel@redhat.com, airlied@redhat.com, daniel@ffwll.ch, maxime.ripard@bootlin.com, sean@poorly.run, sam@ravnborg.org, christian.koenig@amd.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0818741858== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ii5kohPc2k1R9VndKhFsgIO3QRBFn7AmC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ii5kohPc2k1R9VndKhFsgIO3QRBFn7AmC Content-Type: multipart/mixed; boundary="d6XQltpGtzV2ocgVzymJ0BFwRBiNKBWdX"; protected-headers="v1" From: Thomas Zimmermann To: Maarten Lankhorst , kraxel@redhat.com, airlied@redhat.com, daniel@ffwll.ch, maxime.ripard@bootlin.com, sean@poorly.run, sam@ravnborg.org, christian.koenig@amd.com Cc: dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH 1/8] drm/ast: Unpin cursor BO during cleanup References: <20190604154201.14460-1-tzimmermann@suse.de> <20190604154201.14460-2-tzimmermann@suse.de> In-Reply-To: --d6XQltpGtzV2ocgVzymJ0BFwRBiNKBWdX Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 05.06.19 um 09:45 schrieb Maarten Lankhorst: > Op 04-06-2019 om 17:41 schreef Thomas Zimmermann: >> The unpin operation was missing from ast_cursor_fini(). Fixed now. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/ast/ast_mode.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_= mode.c >> index fb700d620b64..41741cd6cd15 100644 >> --- a/drivers/gpu/drm/ast/ast_mode.c >> +++ b/drivers/gpu/drm/ast/ast_mode.c >> @@ -959,6 +959,7 @@ static void ast_cursor_fini(struct drm_device *dev= ) >> struct drm_gem_vram_object *gbo =3D >> drm_gem_vram_of_gem(ast->cursor_cache); >> drm_gem_vram_kunmap_at(gbo, &ast->cache_kmap); >> + drm_gem_vram_unpin(gbo); >> drm_gem_object_put_unlocked(ast->cursor_cache); >> } >> =20 >=20 > Fixes tag? I didn't add one as it would be the original commit 312fec1405dd5. Since the code is only called during driver shutdown, I don't think it ever was a problem. Unpinning the cursor is still the correct thing to do. Best regards Thomas >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --d6XQltpGtzV2ocgVzymJ0BFwRBiNKBWdX-- --Ii5kohPc2k1R9VndKhFsgIO3QRBFn7AmC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAlz3dZ0ACgkQaA3BHVML eiOyFQf/VojPlvULJ6qLB+I9CKJbqMZucDNbPVAl/FctyyKxx24/ReGi3mpwL1Tq tHaQGdsmw/fvqgzMiftlID1l4F4hDJlYeHO/CwuCHmVNGBTXby03fbmKwb8wARgx ub9cKi6wzhpnush2Ye2yeY0lWHrSH3C8vZJt3GZUYbxZUDNEEApifktwXboxgTYw 892bImHNEYr1yfGZUC4HOauRRdVcGvkMPKwBVQQ6qP/RDcDznt2EGc2fsxx+cb+j IcACtrIcnaHWS1s0dsV5+46IOWB+ApI9ETjiGWAu04jVtsDX4gXmXV2FxRUfqReN uLNt4tMBTDGTnEDMzLmXtgIBPTdRCQ== =wITH -----END PGP SIGNATURE----- --Ii5kohPc2k1R9VndKhFsgIO3QRBFn7AmC-- --===============0818741858== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0818741858==--