From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:60192 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756118AbdDMJNF (ORCPT ); Thu, 13 Apr 2017 05:13:05 -0400 Subject: Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid To: Tomi Valkeinen , linux-media@vger.kernel.org References: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl> <1461922746-17521-4-git-send-email-hverkuil@xs4all.nl> <5731C7D2.4090807@ti.com> <5b6f679c-69dd-78be-a398-30aa4b4da1db@xs4all.nl> <1d801302-388b-1d00-f0be-18aaef8cf80f@ti.com> <5d47b07d-1866-f832-0d06-e834e7e2aebb@xs4all.nl> <54a864cd-00b8-3e5f-94d6-ceee1248cd53@xs4all.nl> Cc: dri-devel@lists.freedesktop.org, Hans Verkuil From: Hans Verkuil Message-ID: Date: Thu, 13 Apr 2017 11:12:59 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 04/13/2017 10:43 AM, Tomi Valkeinen wrote: > On 12/04/17 17:04, Hans Verkuil wrote: > >>> So is some other driver supporting this already? Or is the omap4 the >>> first platform you're trying this on? >> >> No, there are quite a few CEC drivers by now, but typically the CEC block is >> a totally independent IP block with its own power, irq, etc. The omap4 is by far >> the most complex one to set up with various GPIO pins, interrupts, regulators, >> etc. to deal with. >> >> Normally it takes about 2 days to make a new CEC driver, but the omap4 is much >> more work :-( > > Ok. > > I mentioned the omapdrm restructuring that we've planned to do, I think > after that this will be easier to implement in a nice way. > > For now, I think more or less what you have now is an acceptable > solution. We can hack the tpd12s015 to keep the level shifter always > enabled, and, afaics, everything else can be handled inside the hdmi4 > driver, right? Right. > Generally speaking, what are the "dependencies" for CEC? It needs to > access EDID? Does CEC care about HPD? Does it care if the cable is > connected or not? For Panda, the level shifter of tpd12s015 is obviously > one hard dendency. > > Is there anything else CEC needs to access or control (besides the CEC > IP itself)? The CEC framework needs to be informed about the physical address contained in the EDID (part of the CEA-861 block). And when the HPD goes down it needs to be informed as well (same call, but with CEC_PHYS_ADDR_INVALID as argument). And it needs to stay powered up even if the HPD is down. That's all. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid Date: Thu, 13 Apr 2017 11:12:59 +0200 Message-ID: References: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl> <1461922746-17521-4-git-send-email-hverkuil@xs4all.nl> <5731C7D2.4090807@ti.com> <5b6f679c-69dd-78be-a398-30aa4b4da1db@xs4all.nl> <1d801302-388b-1d00-f0be-18aaef8cf80f@ti.com> <5d47b07d-1866-f832-0d06-e834e7e2aebb@xs4all.nl> <54a864cd-00b8-3e5f-94d6-ceee1248cd53@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lb3-smtp-cloud2.xs4all.net (lb3-smtp-cloud2.xs4all.net [194.109.24.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71ADD6E84C for ; Thu, 13 Apr 2017 09:13:05 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen , linux-media@vger.kernel.org Cc: Hans Verkuil , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMDQvMTMvMjAxNyAxMDo0MyBBTSwgVG9taSBWYWxrZWluZW4gd3JvdGU6Cj4gT24gMTIvMDQv MTcgMTc6MDQsIEhhbnMgVmVya3VpbCB3cm90ZToKPiAKPj4+IFNvIGlzIHNvbWUgb3RoZXIgZHJp dmVyIHN1cHBvcnRpbmcgdGhpcyBhbHJlYWR5PyBPciBpcyB0aGUgb21hcDQgdGhlCj4+PiBmaXJz dCBwbGF0Zm9ybSB5b3UncmUgdHJ5aW5nIHRoaXMgb24/Cj4+Cj4+IE5vLCB0aGVyZSBhcmUgcXVp dGUgYSBmZXcgQ0VDIGRyaXZlcnMgYnkgbm93LCBidXQgdHlwaWNhbGx5IHRoZSBDRUMgYmxvY2sg aXMKPj4gYSB0b3RhbGx5IGluZGVwZW5kZW50IElQIGJsb2NrIHdpdGggaXRzIG93biBwb3dlciwg aXJxLCBldGMuIFRoZSBvbWFwNCBpcyBieSBmYXIKPj4gdGhlIG1vc3QgY29tcGxleCBvbmUgdG8g c2V0IHVwIHdpdGggdmFyaW91cyBHUElPIHBpbnMsIGludGVycnVwdHMsIHJlZ3VsYXRvcnMsCj4+ IGV0Yy4gdG8gZGVhbCB3aXRoLgo+Pgo+PiBOb3JtYWxseSBpdCB0YWtlcyBhYm91dCAyIGRheXMg dG8gbWFrZSBhIG5ldyBDRUMgZHJpdmVyLCBidXQgdGhlIG9tYXA0IGlzIG11Y2gKPj4gbW9yZSB3 b3JrIDotKAo+IAo+IE9rLgo+IAo+IEkgbWVudGlvbmVkIHRoZSBvbWFwZHJtIHJlc3RydWN0dXJp bmcgdGhhdCB3ZSd2ZSBwbGFubmVkIHRvIGRvLCBJIHRoaW5rCj4gYWZ0ZXIgdGhhdCB0aGlzIHdp bGwgYmUgZWFzaWVyIHRvIGltcGxlbWVudCBpbiBhIG5pY2Ugd2F5Lgo+IAo+IEZvciBub3csIEkg dGhpbmsgbW9yZSBvciBsZXNzIHdoYXQgeW91IGhhdmUgbm93IGlzIGFuIGFjY2VwdGFibGUKPiBz b2x1dGlvbi4gV2UgY2FuIGhhY2sgdGhlIHRwZDEyczAxNSB0byBrZWVwIHRoZSBsZXZlbCBzaGlm dGVyIGFsd2F5cwo+IGVuYWJsZWQsIGFuZCwgYWZhaWNzLCBldmVyeXRoaW5nIGVsc2UgY2FuIGJl IGhhbmRsZWQgaW5zaWRlIHRoZSBoZG1pNAo+IGRyaXZlciwgcmlnaHQ/CgpSaWdodC4KCj4gR2Vu ZXJhbGx5IHNwZWFraW5nLCB3aGF0IGFyZSB0aGUgImRlcGVuZGVuY2llcyIgZm9yIENFQz8gSXQg bmVlZHMgdG8KPiBhY2Nlc3MgRURJRD8gRG9lcyBDRUMgY2FyZSBhYm91dCBIUEQ/IERvZXMgaXQg Y2FyZSBpZiB0aGUgY2FibGUgaXMKPiBjb25uZWN0ZWQgb3Igbm90PyBGb3IgUGFuZGEsIHRoZSBs ZXZlbCBzaGlmdGVyIG9mIHRwZDEyczAxNSBpcyBvYnZpb3VzbHkKPiBvbmUgaGFyZCBkZW5kZW5j eS4KPiAKPiBJcyB0aGVyZSBhbnl0aGluZyBlbHNlIENFQyBuZWVkcyB0byBhY2Nlc3Mgb3IgY29u dHJvbCAoYmVzaWRlcyB0aGUgQ0VDCj4gSVAgaXRzZWxmKT8KClRoZSBDRUMgZnJhbWV3b3JrIG5l ZWRzIHRvIGJlIGluZm9ybWVkIGFib3V0IHRoZSBwaHlzaWNhbCBhZGRyZXNzIGNvbnRhaW5lZApp biB0aGUgRURJRCAocGFydCBvZiB0aGUgQ0VBLTg2MSBibG9jaykuIEFuZCB3aGVuIHRoZSBIUEQg Z29lcyBkb3duIGl0IG5lZWRzCnRvIGJlIGluZm9ybWVkIGFzIHdlbGwgKHNhbWUgY2FsbCwgYnV0 IHdpdGggQ0VDX1BIWVNfQUREUl9JTlZBTElEIGFzIGFyZ3VtZW50KS4KCkFuZCBpdCBuZWVkcyB0 byBzdGF5IHBvd2VyZWQgdXAgZXZlbiBpZiB0aGUgSFBEIGlzIGRvd24uCgpUaGF0J3MgYWxsLgoK UmVnYXJkcywKCglIYW5zCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=