From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5884FC6FD1D for ; Mon, 20 Mar 2023 10:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbjCTKUx (ORCPT ); Mon, 20 Mar 2023 06:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230176AbjCTKUo (ORCPT ); Mon, 20 Mar 2023 06:20:44 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9B2122A3D for ; Mon, 20 Mar 2023 03:20:35 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id y4so44629110edo.2 for ; Mon, 20 Mar 2023 03:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679307634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2kK6ZKQu/hSTehLzcd0ok1R36H64mU2xn5KpGhq6J1w=; b=Ju6zmO0MlfizGGz7Jd7gcva/CJl93kFD7GL9WBLqwSkQXbm5diuXdjj66wL4FqPd0o vDDspm4OpDKzQCvZjrw48YkcjilgM2DN0tTww/RgQ+zeLRf3ab6kDouqkBfp3Fs/lf5P IiCthWkEFSAhHxMOTZONAInrmRc7bSZ4ytEHlYF1DSeNT71Oss6698O9b6VI3HSPWO51 7kV19EcKUprriQNj8EZkOrzRmEvpiM6MDK4EDxxcuULZyLikbgPLwLGGaw9jHZlad1/4 WY7GSPPz82nh7+5l+vQjbk23/B0uB2FuuZFy1+G0GmqeAjGX09lCzcMaPqIW7mn+QDVa XPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679307634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2kK6ZKQu/hSTehLzcd0ok1R36H64mU2xn5KpGhq6J1w=; b=gXjF2cOJ7jwoBB5A+2mSensZ3LCEnghv27KYvYPA2hnBBeEUGRe+O1j2pJR8iSS7TB ZoiwD77LjTiq+141vH5xLGWjiBHeGqThPvcXR9j84uxsef1xsIlUQmIfTHLblzsXzRf9 Y3Lk1nODcZQgnF5fm7wiHZDhCEJ70TszcGg0luby5Bp65qGe0jyjG0Z9ibjsOw0eEXKS zXLIKipE/y7EMfQ4hcxNV/tGgd8gjPJvxPgJC2QNuajOB4WONCvxYuEP+B6wcEy+Qogr j4ygOTLiqPBwd41NWq0PnjHwNUuwQ8X5whla5GST90010Yhbpzb/cj0UjxXJwxN8jkXY fLOA== X-Gm-Message-State: AO0yUKWSR8oBGXjspDyHC/QOIq5i71pfX4DOG3mIhEhz9dDbNWdLUVYK fO+5qut2x3vX/NRuJwNPSM3nBg== X-Google-Smtp-Source: AK7set9UbCg3tUOgT6QPPPtQgc+SuVDmWxP5HoFhnXgAOMYpzcIlAvQy0NuhQuV0XfPLvoiivhc3GQ== X-Received: by 2002:aa7:db52:0:b0:4fa:ba60:8188 with SMTP id n18-20020aa7db52000000b004faba608188mr12697594edt.8.1679307633952; Mon, 20 Mar 2023 03:20:33 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:4428:8354:afb6:2992? ([2a02:810d:15c0:828:4428:8354:afb6:2992]) by smtp.gmail.com with ESMTPSA id y70-20020a50bb4c000000b004fa380a14e7sm4663350ede.77.2023.03.20.03.20.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:20:33 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 11:20:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/7] dt-bindings: misc: Add the Lantiq PEF2466 E1/T1/J1 framer Content-Language: en-US To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni References: <20230316122741.577663-1-herve.codina@bootlin.com> <20230316122741.577663-2-herve.codina@bootlin.com> <96b01241-d57d-a460-4a8b-9e83eaab24ae@linaro.org> <20230320104619.468a304b@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230320104619.468a304b@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/03/2023 10:46, Herve Codina wrote: >> >>> + >>> + lantiq,data-rate-bps: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + enum: [2048000, 4096000, 8192000, 16384000] >>> + default: 2048000 >>> + description: >>> + Data rate (bit per seconds) on the system highway. >> >> Why do you need it? How is it different from clock? Do you expect some >> DDR here? > > This is needed to set the data position on the data line. > If the data line clock (sysclk-rate-hz) is greater than 'data-rate-bps', > the device interleaves some holes between data in the full frame. > > The exact position of the data and the holes is defined by 'channel-phase' > > So, two information are needed: > - The number of slots available (deduced from 'lantiq,data-rate-bps') > - The slot to use in the available slots ('lantiq,channel-phase" property > > lantiq,data-rate-bps is not a clock but a property used to set the frame > physical setting. ie the correct data position in the frame. OK (...) >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + pef2256@2000000 { >> >> Figure out some generic node name. > > What do you think about 'framer' ? Sure, I don't have particular proposal. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46320C6FD1D for ; Mon, 20 Mar 2023 10:22:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3E07D1F4; Mon, 20 Mar 2023 11:21:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3E07D1F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679307718; bh=7Ekhr+Bgrk2zZPq0jS4YiFJhUDR/LxnnP4C56s8lNM0=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FUrzj8x0jnQTjqbx9I7lrDn7ncel/Z0eFQI+xyv6BzpjmPETPKVN2zfeZqbAApo2w F+FK4Q+TZDO/Rg38oXhqEH5ocD/41e83MNfvLoKMsRcxX7Dc4DJckOc2II8tAa+nsK 0CJvKHa/F8cF94ZsrtJNvYRgB+yy+bPhwlPk42PM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A9E2FF80093; Mon, 20 Mar 2023 11:20:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A4A5F8027B; Mon, 20 Mar 2023 11:20:42 +0100 (CET) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3AC24F80093 for ; Mon, 20 Mar 2023 11:20:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3AC24F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Ju6zmO0M Received: by mail-ed1-x52a.google.com with SMTP id t5so7752062edd.7 for ; Mon, 20 Mar 2023 03:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679307634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2kK6ZKQu/hSTehLzcd0ok1R36H64mU2xn5KpGhq6J1w=; b=Ju6zmO0MlfizGGz7Jd7gcva/CJl93kFD7GL9WBLqwSkQXbm5diuXdjj66wL4FqPd0o vDDspm4OpDKzQCvZjrw48YkcjilgM2DN0tTww/RgQ+zeLRf3ab6kDouqkBfp3Fs/lf5P IiCthWkEFSAhHxMOTZONAInrmRc7bSZ4ytEHlYF1DSeNT71Oss6698O9b6VI3HSPWO51 7kV19EcKUprriQNj8EZkOrzRmEvpiM6MDK4EDxxcuULZyLikbgPLwLGGaw9jHZlad1/4 WY7GSPPz82nh7+5l+vQjbk23/B0uB2FuuZFy1+G0GmqeAjGX09lCzcMaPqIW7mn+QDVa XPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679307634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2kK6ZKQu/hSTehLzcd0ok1R36H64mU2xn5KpGhq6J1w=; b=MFkPjfcMhpsr5eEUlLNuHQAL9nRehla7D4+R2BALDY2GYtUL9k/yPiSazug7KrHXDT /O2bROXD8P+AebI/RvMIDyECoJlgtXT6zvhR/QM8LFdk2IOliPX9cw8cgfDBlzIlA7s3 EVHSZ2n+SPoSJJg7f6NfawzwejqmciMyY8tehzjPJex/4Q/yi+X2QM8B6F72MMa8+fec qX0dD9BR0cffIIyeUVtdz0AJpDzgzESEQQrpb7uzEn1WLnvhtXRXmdmD4njUlUHPHChv WXRAIPxYU1a0O6slQFsC9kWt31k1p3+wMY5bw1OkEB3PZhIkOUhULzZ3Rjd1wo4aQLnX c/Vw== X-Gm-Message-State: AO0yUKV20i+qIWfX8F/1/39ngiEiCQiJco3gaxRSpr6tPQzRfLc/RPNK f6dIiVeztECCuJpgTQxyL/fuuQ== X-Google-Smtp-Source: AK7set9UbCg3tUOgT6QPPPtQgc+SuVDmWxP5HoFhnXgAOMYpzcIlAvQy0NuhQuV0XfPLvoiivhc3GQ== X-Received: by 2002:aa7:db52:0:b0:4fa:ba60:8188 with SMTP id n18-20020aa7db52000000b004faba608188mr12697594edt.8.1679307633952; Mon, 20 Mar 2023 03:20:33 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:4428:8354:afb6:2992? ([2a02:810d:15c0:828:4428:8354:afb6:2992]) by smtp.gmail.com with ESMTPSA id y70-20020a50bb4c000000b004fa380a14e7sm4663350ede.77.2023.03.20.03.20.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:20:33 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 11:20:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/7] dt-bindings: misc: Add the Lantiq PEF2466 E1/T1/J1 framer Content-Language: en-US To: Herve Codina References: <20230316122741.577663-1-herve.codina@bootlin.com> <20230316122741.577663-2-herve.codina@bootlin.com> <96b01241-d57d-a460-4a8b-9e83eaab24ae@linaro.org> <20230320104619.468a304b@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230320104619.468a304b@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: NRRDVTPZQ3WNOPM4353WCS73GVHFVPBR X-Message-ID-Hash: NRRDVTPZQ3WNOPM4353WCS73GVHFVPBR X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/03/2023 10:46, Herve Codina wrote: >> >>> + >>> + lantiq,data-rate-bps: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + enum: [2048000, 4096000, 8192000, 16384000] >>> + default: 2048000 >>> + description: >>> + Data rate (bit per seconds) on the system highway. >> >> Why do you need it? How is it different from clock? Do you expect some >> DDR here? > > This is needed to set the data position on the data line. > If the data line clock (sysclk-rate-hz) is greater than 'data-rate-bps', > the device interleaves some holes between data in the full frame. > > The exact position of the data and the holes is defined by 'channel-phase' > > So, two information are needed: > - The number of slots available (deduced from 'lantiq,data-rate-bps') > - The slot to use in the available slots ('lantiq,channel-phase" property > > lantiq,data-rate-bps is not a clock but a property used to set the frame > physical setting. ie the correct data position in the frame. OK (...) >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + pef2256@2000000 { >> >> Figure out some generic node name. > > What do you think about 'framer' ? Sure, I don't have particular proposal. Best regards, Krzysztof