From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v3 21/40] maintainers: claim ownership of
 DPAA Mempool driver
Date: Wed, 27 Sep 2017 14:00:19 +0530
Message-ID: <f148997c-1335-bf84-ac3c-519920de337f@nxp.com>
References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com>
 <3516429.Zj0nEJyuAA@xps> <86d8df7b-60f4-b562-a197-6116f9bd0205@nxp.com>
 <60248422.eIQP2pKO6C@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0045.outbound.protection.outlook.com [104.47.33.45])
 by dpdk.org (Postfix) with ESMTP id 64C775592
 for <dev@dpdk.org>; Wed, 27 Sep 2017 10:19:33 +0200 (CEST)
In-Reply-To: <60248422.eIQP2pKO6C@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Friday 22 September 2017 01:05 PM, Thomas Monjalon wrote:
> 22/09/2017 09:37, Shreyansh Jain:
>> On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote:
>>> 22/09/2017 08:47, Shreyansh Jain:
>>>> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
>>>>> 23/08/2017 16:11, Shreyansh Jain:
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -409,6 +409,7 @@ NXP dpaa
>>>>>>     M: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>>     M: Shreyansh Jain <shreyansh.jain@nxp.com>
>>>>>>     F: drivers/bus/dpaa/
>>>>>> +F: drivers/mempool/dpaa/
>>>>>>     F: doc/guides/nics/dpaa.rst
>>>>>>     F: doc/guides/nics/features/dpaa.ini
>>>>>
>>>>> This kind of patch can be squashed in the first patch introducing
>>>>> this new directory.
>>>>
>>>> Then the patch script (devtools/check-git-log.sh) reports error - I
>>>> think. That is the primary reason I split them across multiple patches.
>>>> You sure that doesn't matter?
>>>
>>> Which error?
>>>
>>> To be clear I suggest to squash with patch 19 where
>>> drivers/mempool/dpaa/Makefile is introduced.
>>
>> Yes, I understand that.
>> It would report error that the headline is wrong because I am hitting
>> different directories - "MAINTAINERS" and "drivers/mempool/*" with the
>> same patch having headline "mempool/*".
> 
> The test you are talking about has this comment:
> 	# check headline prefix when touching only drivers, e.g. net/<driver name>
> If you hit a warning, there is a bug.

Somehow I had the impression it throws an error in such cases. I changed 
as suggested and check-git-log.sh script didn't throw any error - I was 
wrong. Thanks for correcting.

-
Shreyansh