From mboxrd@z Thu Jan 1 00:00:00 1970 From: Animesh Manna Subject: Re: [PATCH 43/67] drm/i915: Use HAS_CSR instead of gen number on DMC load. Date: Mon, 22 May 2017 16:16:13 +0530 Message-ID: References: <1491506163-14587-1-git-send-email-rodrigo.vivi@intel.com> <1491506163-14587-43-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1758320380==" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C86189DE3 for ; Mon, 22 May 2017 10:46:16 +0000 (UTC) In-Reply-To: <1491506163-14587-43-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1758320380== Content-Type: multipart/alternative; boundary="------------E1B4046D954D40BF291E755E" This is a multi-part message in MIME format. --------------E1B4046D954D40BF291E755E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 4/7/2017 12:45 AM, Rodrigo Vivi wrote: > Since we have HAS_CSR tied to the platform definition > let's use this instead of checking per platform. > > One less thing to worry when adding support to new platforms. > > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_csr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c > index 496a965..eecee65 100644 > --- a/drivers/gpu/drm/i915/intel_csr.c > +++ b/drivers/gpu/drm/i915/intel_csr.c > @@ -241,7 +241,7 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv) > u32 *payload = dev_priv->csr.dmc_payload; > uint32_t i, fw_size; > > - if (!IS_GEN9(dev_priv)) { > + if (!HAS_CSR(dev_priv)) { > DRM_ERROR("No CSR support available for this platform\n"); > return; > } Changes looks good to me. Reviewed-by: Animesh Manna Regards, Animesh --------------E1B4046D954D40BF291E755E Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit



On 4/7/2017 12:45 AM, Rodrigo Vivi wrote:
Since we have HAS_CSR tied to the platform definition
let's use this instead of checking per platform.

One less thing to worry when adding support to new platforms.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 496a965..eecee65 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -241,7 +241,7 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv)
 	u32 *payload = dev_priv->csr.dmc_payload;
 	uint32_t i, fw_size;
 
-	if (!IS_GEN9(dev_priv)) {
+	if (!HAS_CSR(dev_priv)) {
 		DRM_ERROR("No CSR support available for this platform\n");
 		return;
 	}
Changes looks good to me.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>

    
Regards,
Animesh

    

--------------E1B4046D954D40BF291E755E-- --===============1758320380== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1758320380==--