From: "Siou-Jhih, Guo" <hallblazzar@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: Fix misspelling in comment
Date: Tue, 5 Oct 2021 22:16:33 +0100 [thread overview]
Message-ID: <f1569e97-8996-e538-182c-cc5f6510dc35@gmail.com> (raw)
In-Reply-To: <YVwpEa5T4HnOX5/g@kroah.com>
On 05/10/2021 11:29, Greg Kroah-Hartman wrote:
> On Wed, Sep 29, 2021 at 12:29:01PM +0100, hallblazzar wrote:
>> As format check raised by scripts/checkpatch.pl, comment in the rtw_ap.c
>> looks misspelled by accident. Help fix it.
>>
>> The original error is as below shows:
>>
>> CHECK: 'followign' may be misspelled - perhaps 'following'?
>> +Set to 0 (HT pure) under the followign conditions
>>
>> Signed-off-by: Siou-Jhih, Guo <hallblazzar@gmail.com>
>
> This does not match with your "From" line in your email header :(
>
>> ---
>> drivers/staging/r8188eu/core/rtw_ap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What changed from v1? That always has to go below the --- line as per
> the documentation, right?
>
> Please fix up and send a v3.
>
> thanks,
>
> greg k-h
Hello Greg,
Really thankful for your time and point those issues out. I've fixed
the issues and re-sent v3 patch
[PATCH v2] staging: r8188eu: Fix misspelling in comment
If anything should I additionally aware, I'd like to fix them.
Regards,
Bill G.
next prev parent reply other threads:[~2021-10-05 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 11:29 [PATCH v2] staging: r8188eu: Fix misspelling in comment hallblazzar
2021-10-05 10:29 ` Greg Kroah-Hartman
2021-10-05 21:16 ` Siou-Jhih, Guo [this message]
2021-10-06 1:02 ` Joe Perches
2021-10-11 21:54 ` Siou-Jhih, Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1569e97-8996-e538-182c-cc5f6510dc35@gmail.com \
--to=hallblazzar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.