All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Matthew Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Cc: David GOUARIN <dgouarin@gmail.com>,
	Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
Subject: Re: [Buildroot] [PATCH v9] package/freeradius-server: new package
Date: Tue, 26 Jul 2022 19:55:41 +0200	[thread overview]
Message-ID: <f15e5b88-a42d-26aa-28ed-cf7acdf63e60@mind.be> (raw)
In-Reply-To: <20220104215541.23003-1-matthew.weber@collins.com>



On 04/01/2022 22:55, Matthew Weber via buildroot wrote:
> From: David GOUARIN <dgouarin@gmail.com>
> 
> FreeRADIUS is an open source server which implements
> a protocol for remote user Authorization, Authentication
> and Accounting.
> 
> Signed-off-by: David GOUARIN <dgouarin@gmail.com>
> Signed-off-by: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@collins.com>

  Finally applied to master, thanks. I still made a large number of changes.

      - remove second patch, superseded by other patches;
      - add upstream links to patches;
      - add 3 more patches to avoid looking in host directories;
      - explicitly add dependency on !static inherited from talloc (redundant
        with glibc, but future-safe);
      - simplify Config.in comment;
      - check hash with PGP signature;
      - add conf opts for runtime paths;
      - add conf opts to disable unsupported modules;
      - add more optional dependencies;
      - enable/disable all modules that use a dependency;
      - search defaults file in /etc/default, not /etc/sysconfig.

  I also created an upstream pull request for all the patches that are not yet 
upstream.

  Regards,
  Arnout

> ---
> Changes
> v8 -> v9:
>   - A systemd unit is installed if systemd is enabled. The default provided
>     by `freeradius-server/redhat/radiusd.service` was not used because of
>     extra options not compatible with Buildroot. The unit is instead based
>     on a simplified version of that upstream file.
> 
> v7 -> v8:
>    - added dependencies to include libpcap
>    - version bump to 3.0.25
> 
> v6 -> v7
>    - resolve rlm_sql module compilation error (Newer GCC)
>      (remove mysql_version.h as mysql.h is included)
> 
> v5 -> v6:
>    - cleaned up patches to all be git formatted
>    - added depends on BR2_USE_MMU
>    - rebased on master
>    - added CPE info
> 
> v4 -> v5:
>    - better package patches formatting
> 
> v3 -> v4:
>    Taken in account Thomas review
>    - fix build with BR2_COMPILER_PARANOID_UNSAFE_PATH
>    - import patches inside package directory instead of downloading them
>    - remove config.cache file, pass the answers on the command line instead
>    - add comments for weird TARGET_DIR and R directives
>    - remove broken python optional feature. Managed to get it to build
>      with python 2.7, not 3.0 and it still fails basic testing
> 
> v2 -> v3:
>    - As suggested by Matt, merge with pending upstream patch. Included most of it,
>      including patches based on Yocto work :
>      http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-connectivity/freeradius/files
>      Didn't kept all the --without directive, as they do not seem useful, nor
>      the custom INSTALL_TARGET_CMDS.
> 
> v1 -> v2:
>     - fix invalid characters in Config.in
[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-07-26 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 21:55 [Buildroot] [PATCH v9] package/freeradius-server: new package Matthew Weber via buildroot
2022-01-09 18:13 ` Romain Naour
2022-07-26 17:55 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f15e5b88-a42d-26aa-28ed-cf7acdf63e60@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=dgouarin@gmail.com \
    --cc=kalpesh.panchal@rockwellcollins.com \
    --cc=matthew.weber@collins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.