From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752124AbcGRKPD (ORCPT ); Mon, 18 Jul 2016 06:15:03 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:35279 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbcGRKO7 (ORCPT ); Mon, 18 Jul 2016 06:14:59 -0400 Subject: Re: [PATCH 1/2] net: ethernet: marvell: pxa168_eth: use phydev from struct net_device To: Philippe Reynes , davem@davemloft.net, jszhang@marvell.com, mugunthanvnm@ti.com, a@unstable.cc, fw@strlen.de References: <1468791046-19567-1-git-send-email-tremyfr@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Mon, 18 Jul 2016 13:14:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1468791046-19567-1-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 7/18/2016 12:30 AM, Philippe Reynes wrote: > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct net_device. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/marvell/pxa168_eth.c | 36 +++++++++++++---------------- > 1 files changed, 16 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c > index 54d5154..d466326 100644 > --- a/drivers/net/ethernet/marvell/pxa168_eth.c > +++ b/drivers/net/ethernet/marvell/pxa168_eth.c [...] > @@ -973,16 +972,17 @@ static int pxa168_init_phy(struct net_device *dev) > { > struct pxa168_eth_private *pep = netdev_priv(dev); > struct ethtool_cmd cmd; > + struct phy_device *phy = NULL; Initializer not really needed. > int err; > > - if (pep->phy) > + if (dev->phydev) > return 0; > > - pep->phy = mdiobus_scan(pep->smi_bus, pep->phy_addr); > - if (IS_ERR(pep->phy)) > - return PTR_ERR(pep->phy); > + phy = mdiobus_scan(pep->smi_bus, pep->phy_addr); > + if (IS_ERR(phy)) > + return PTR_ERR(phy); > > - err = phy_connect_direct(dev, pep->phy, pxa168_eth_adjust_link, > + err = phy_connect_direct(dev, phy, pxa168_eth_adjust_link, > pep->phy_intf); > if (err) > return err; Hm, where do you assign 'dev->phydev'? [...] MBR, Sergei