From: Eric Miao <eric.y.miao@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Paul Shen <bshen9@marvell.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [RFC PATCH 5/5] ASoC: simplify the SSP DMA parameters settings by run-time generation
Date: Thu, 23 Apr 2009 16:26:05 +0800 [thread overview]
Message-ID: <f17812d70904230126i9321f67s3298fff4386feee1@mail.gmail.com> (raw)
In-Reply-To: <20090423082328.GB30105@sirena.org.uk>
On Thu, Apr 23, 2009 at 4:23 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> On Thu, Apr 23, 2009 at 01:08:51PM +0800, Eric Miao wrote:
>> The SSP DMA parameters can actually be easily generated at run-time since
>> they are almost similar except for the FIFO width and direction. Another
>> benefit is the re-use of information from 'struct ssp_device', like SSDR
>> physical FIFO address and DRCMR register index for both directions.
>
>> Signed-off-by: Eric Miao <eric.miao@marvell.com>
>
> This looks like a win - is there any reason not to merge it without
> waiting for the rest of the series (I've not tested it yet)?
>
Should be no. I'll get this regenerated to be aligned with the current
code. Moment.
--
Cheers
- eric
next prev parent reply other threads:[~2009-04-23 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 5:08 [RFC PATCH 5/5] ASoC: simplify the SSP DMA parameters settings by run-time generation Eric Miao
2009-04-23 8:23 ` Mark Brown
2009-04-23 8:26 ` Eric Miao [this message]
2009-04-23 8:53 ` pHilipp Zabel
2009-04-23 9:02 ` Eric Miao
2009-04-23 9:05 ` Eric Miao
2009-04-23 9:30 ` Mark Brown
2009-04-23 9:08 ` Mark Brown
2009-04-23 9:28 ` Eric Miao
2009-04-23 9:34 ` Mark Brown
2009-04-23 9:41 ` Eric Miao
2009-04-23 9:44 ` Mark Brown
2009-04-23 9:57 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70904230126i9321f67s3298fff4386feee1@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=bshen9@marvell.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.