From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FB1C4332F for ; Tue, 8 Feb 2022 15:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379501AbiBHPK5 (ORCPT ); Tue, 8 Feb 2022 10:10:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245039AbiBHPKz (ORCPT ); Tue, 8 Feb 2022 10:10:55 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2424AC061577 for ; Tue, 8 Feb 2022 07:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644333054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEdNY3YBugunq8yXpBBABtVIZDrmoxsBt8YDexXqqEo=; b=ASvoJxYo9vPV7gZdwqRDokLdmB6sQfHMa6ZZU+clWuu+1uMngawhe3FtvRyBqxs+BNPNED BGbZdx93DiOi64TQIC8W2+LFKActIutOUf5ubWgPIne00Qbs326Xe/M8LLdi/2wGyY8nsY 1vY07UqxcYGutO+9l6TV97k9JzeVH/I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-nu-yFIGXOW-M81s5zN0zEg-1; Tue, 08 Feb 2022 10:10:53 -0500 X-MC-Unique: nu-yFIGXOW-M81s5zN0zEg-1 Received: by mail-wm1-f70.google.com with SMTP id 130-20020a1c0288000000b0037bc5cbd027so1146597wmc.8 for ; Tue, 08 Feb 2022 07:10:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zEdNY3YBugunq8yXpBBABtVIZDrmoxsBt8YDexXqqEo=; b=2sUtC8IqPRK3wvbZzAmgsPlNyYxWOFkFYYG04yvcAQKvICPT/Sg7Rq55HA4+hXQEzv f05VvGqMmDQQfS43h/FGUY6Xd4SDQWsR+hMgJCslNUjMZPmYchC+jpEXRuKLJ+ojfCZz yd23GwZMvB/5BUek0N/3uluhM7TRTF7jbP05OLXmWbLulHY54pxZog9bCaI8/Koode2T FFtOz/Gp/3/2c3qh0tTSgqJ0bXUoPUhrbj2m4QVedaKDJo163SqMQLfKqNbI8MCDQ4D2 2N8Z48GLd8q6mKkQSADM9M2/6/U58tFZ4AVddwzGMo8T+hn2WqOXW+OA5uZMg1FLlceR b2MA== X-Gm-Message-State: AOAM533UcMyw/kD17Qro+mBuLmmwOMRlIU0WWxqSus5K+G+YI9qivHDU KhKBbIkjJNJLK9Zyz2pft6tMWYjUxGWcV2wTPL6wETOdfDEOEbf2kWNuUWEKYuBdwqRtQ6tTw3a BIlwi4lkhyKT0L9Rn+rBW0tV+ X-Received: by 2002:adf:ef10:: with SMTP id e16mr3652218wro.428.1644333051931; Tue, 08 Feb 2022 07:10:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFW9XXEiShgJBRMmm2UkmN1bA7P1SHblO06AiaMNERAOilbmNeV2HVlkYhh60Zpx3AWddEMQ== X-Received: by 2002:adf:ef10:: with SMTP id e16mr3652206wro.428.1644333051654; Tue, 08 Feb 2022 07:10:51 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id n13sm2601507wms.8.2022.02.08.07.10.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 07:10:51 -0800 (PST) Message-ID: Date: Tue, 8 Feb 2022 16:10:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Content-Language: en-US To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Fbdev development list , Linux PWM List , David Airlie , Daniel Vetter , Mark Brown , Linux Kernel Mailing List , DRI Development , Liam Girdwood , Rob Herring , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Thierry Reding , Maxime Ripard , Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lee Jones , Andy Shevchenko , Sam Ravnborg References: <20220204134347.1187749-1-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, Thanks a lot for testing! On 2/8/22 15:19, Geert Uytterhoeven wrote: > Hi Javier, > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. > > I gave it a try on an Adafruit FeatherWing 128x32 OLED, connected to an > OrangeCrab ECP5 FPGA board running a 64 MHz VexRiscv RISC-V softcore. > > Findings: > - Kernel size increased by 349 KiB, > - The "Memory:" line reports 412 KiB less memory, > - On top of that, "free" shows ca. 92 KiB more memory in use after > bootup. > - The logo (I have a custom monochrome logo enabled) is no longer shown. I was able to display your tux monochrome with ./fbtest -f /dev/fb1 test004 > - The screen is empty, with a (very very slow) flashing cursor in the > middle of the screen, with a bogus long line next to it, which I can > see being redrawn. > - Writing text (e.g. hello) to /dev/tty0, I first see the text, > followed by an enlargement of some of the characters. So far I was mostly testing using your fbtest repo tests and all of them (modulo test009 that says "Screen size too small for this test"). But I've tried now using as a VT and I see the same visual artifacts. I wonder what's the difference between fbcon and the way your tests use the fbdev API. > - "time ls" on the serial console (no files in the current directory, > so nothing to print) increases from 0.86s to 1.92s, so the system is > more loaded. As ssd1307fb relied on deferred I/O too, the slowdown > might be (partly) due to redrawing of the visual artefacts > mentioned above. > I was trying to first have the driver and then figure out how to optimize it. For v3 I'm using regmap to access instead of the I2C layer directly. I noticed that this is even slower but it makes the driver more clean and allows to support both I2C and SPI (untested but will include it as a WIP). > So while the displays seems to be initialized correctly, it looks like > there are some serious bugs in the conversion from xrgb8888 to > monochrome. > Yes, that's possible. I haven't tried to use it as a console before because the display resolution is just too small. But will include now in my tests. > Gr{oetje,eeting}s, > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 851BBC433F5 for ; Tue, 8 Feb 2022 15:10:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F77110E181; Tue, 8 Feb 2022 15:10:57 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 309DA10E181 for ; Tue, 8 Feb 2022 15:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644333054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEdNY3YBugunq8yXpBBABtVIZDrmoxsBt8YDexXqqEo=; b=ASvoJxYo9vPV7gZdwqRDokLdmB6sQfHMa6ZZU+clWuu+1uMngawhe3FtvRyBqxs+BNPNED BGbZdx93DiOi64TQIC8W2+LFKActIutOUf5ubWgPIne00Qbs326Xe/M8LLdi/2wGyY8nsY 1vY07UqxcYGutO+9l6TV97k9JzeVH/I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-8-BSH4vGkHOAShqpPBAP8IGg-1; Tue, 08 Feb 2022 10:10:53 -0500 X-MC-Unique: BSH4vGkHOAShqpPBAP8IGg-1 Received: by mail-wm1-f70.google.com with SMTP id l4-20020a05600c4f0400b0037bb2ce79d8so1146623wmq.9 for ; Tue, 08 Feb 2022 07:10:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zEdNY3YBugunq8yXpBBABtVIZDrmoxsBt8YDexXqqEo=; b=qU4dwfy5MnX+R+pn82iBZFzG6/v9SeXin+zFk01IBM+WD7F7VBsCSpDATKE+SZOxGO PFCD+uiTx3LhO8cEAqRGMW6HWRlNqHiqKDek7NknOE5T8frdzQmGXljCLP5tFJwhBVTh x/TdJWX98mLSA55d/l121psleB4r1NZXEBOAHaT58PaImJSEmWLnraL2Ok82x+RilEne liedOnYPEdWKkb3wo/zASCpjvRBbPMveNt6/loHx/vnmTJutRODRN4zx71qtBjv/9yx+ RAMCrDrS5kInmJl8ea0qUx7FcptVuI1FAmCDXtSBP2tt8sO3f/SdjSz2GcorVjvDlIOU wNPw== X-Gm-Message-State: AOAM532aaMnAojbLC8C63hy9EZ9wWVMQT20aFm5yaET7/AZ4aJ3PtCU4 BzdrHjaLZMuyjyrdoUG24NmeYt6sNQCmNiVKTpmLdtKZfhqljWlvQ3OFQc1GUR45G2lqK0ynF2M zfBquoiFLH3xOnA/sFMwWdSabz1vw X-Received: by 2002:adf:ef10:: with SMTP id e16mr3652222wro.428.1644333051931; Tue, 08 Feb 2022 07:10:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFW9XXEiShgJBRMmm2UkmN1bA7P1SHblO06AiaMNERAOilbmNeV2HVlkYhh60Zpx3AWddEMQ== X-Received: by 2002:adf:ef10:: with SMTP id e16mr3652206wro.428.1644333051654; Tue, 08 Feb 2022 07:10:51 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id n13sm2601507wms.8.2022.02.08.07.10.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 07:10:51 -0800 (PST) Message-ID: Date: Tue, 8 Feb 2022 16:10:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays To: Geert Uytterhoeven References: <20220204134347.1187749-1-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Fbdev development list , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Sam Ravnborg , Linux PWM List , David Airlie , Daniel Vetter , Linux Kernel Mailing List , DRI Development , Liam Girdwood , Rob Herring , Mark Brown , Thierry Reding , Maxime Ripard , Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Andy Shevchenko , Lee Jones Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Geert, Thanks a lot for testing! On 2/8/22 15:19, Geert Uytterhoeven wrote: > Hi Javier, > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. > > I gave it a try on an Adafruit FeatherWing 128x32 OLED, connected to an > OrangeCrab ECP5 FPGA board running a 64 MHz VexRiscv RISC-V softcore. > > Findings: > - Kernel size increased by 349 KiB, > - The "Memory:" line reports 412 KiB less memory, > - On top of that, "free" shows ca. 92 KiB more memory in use after > bootup. > - The logo (I have a custom monochrome logo enabled) is no longer shown. I was able to display your tux monochrome with ./fbtest -f /dev/fb1 test004 > - The screen is empty, with a (very very slow) flashing cursor in the > middle of the screen, with a bogus long line next to it, which I can > see being redrawn. > - Writing text (e.g. hello) to /dev/tty0, I first see the text, > followed by an enlargement of some of the characters. So far I was mostly testing using your fbtest repo tests and all of them (modulo test009 that says "Screen size too small for this test"). But I've tried now using as a VT and I see the same visual artifacts. I wonder what's the difference between fbcon and the way your tests use the fbdev API. > - "time ls" on the serial console (no files in the current directory, > so nothing to print) increases from 0.86s to 1.92s, so the system is > more loaded. As ssd1307fb relied on deferred I/O too, the slowdown > might be (partly) due to redrawing of the visual artefacts > mentioned above. > I was trying to first have the driver and then figure out how to optimize it. For v3 I'm using regmap to access instead of the I2C layer directly. I noticed that this is even slower but it makes the driver more clean and allows to support both I2C and SPI (untested but will include it as a WIP). > So while the displays seems to be initialized correctly, it looks like > there are some serious bugs in the conversion from xrgb8888 to > monochrome. > Yes, that's possible. I haven't tried to use it as a console before because the display resolution is just too small. But will include now in my tests. > Gr{oetje,eeting}s, > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat