From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] test: Fix memory corruption issues which
 fails the link_bonding test.
Date: Tue, 18 Jul 2017 17:13:54 +0100
Message-ID: <f1980db9-4cd1-4d2b-1e10-aa5f93e9e814@intel.com>
References: <1499671222-8283-1-git-send-email-herbert.guan@arm.com>
 <1499685226-8659-1-git-send-email-herbert.guan@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Herbert Guan <herbert.guan@arm.com>, dev@dpdk.org,
 declan.doherty@intel.com, jianbo.liu@linaro.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id A01653253
 for <dev@dpdk.org>; Tue, 18 Jul 2017 18:14:01 +0200 (CEST)
In-Reply-To: <1499685226-8659-1-git-send-email-herbert.guan@arm.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/10/2017 12:13 PM, Herbert Guan wrote:
> Patch V2: fix build warnings by deleting unused variables. 
> 
> There were double-free problems in some test cases, which will cause
> a duplicated mbuf will be added into mempool.  After double-free, 
> some new allocated mbuf will hold a same address and thus cause the 
> memory corruption.
> 
> Another minor issue is that in some test cases, allocated mbuf will
> not be released after test case exits.  Hopefully these leaked mbuf
> will be released by the next test case in its setup phase when
> stopping the virtual pmd ports, while this do is a memory leak of
> the exited test case.
> 
> To fix above 2 issues, this patch will do:
> 1) Release virtual pmd ports' tx queue in the clean up function
>    remove_slaves_and_stop_bonded_device() of each test cases.
> 2) Do not release allocated mbufs for test bursts.  These mbufs
>    will be released in remove_slaves_and_stop_bonded_device() when
>    test case exits.
> 
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>

Updated unit test causing segfault, before and after patch, am I doing
something wrong?

I will postpone this patch until unit test can be verified.

Thanks,
ferruh