From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9188C432BE for ; Thu, 29 Jul 2021 09:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 849EE60F5E for ; Thu, 29 Jul 2021 09:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235017AbhG2JK2 (ORCPT ); Thu, 29 Jul 2021 05:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235244AbhG2JK2 (ORCPT ); Thu, 29 Jul 2021 05:10:28 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3409EC061757 for ; Thu, 29 Jul 2021 02:10:24 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id bp1so9737657lfb.3 for ; Thu, 29 Jul 2021 02:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j1oTdGaEQ77wKFt5yMUzZqXg44oVq6MHBdIKvRtKHso=; b=xiRwb6lr+yN2TvAWWqnnWrrLDB723jy82nWZmOQ8iowGgp/4xpqEERcNg7aNe5TMiu /KXTATfbuD5j1Pnh2+TbZ9CCZp9PqZ1qebUtJQK8wDsCEIJGEQpJzKE4QRNKY6utUDp+ BEapaAqUXw0T9DqgL1mfwrMFNCtjgrduBVYu4KMH8cNbOfU19ti5pTFvRPbHaPSExcRi sDvrhiOGF3CsPKysGtGFELNvONsDuI9ZtUQNFJqBxo4dEFtvnLBCPZeL1bDsdrzaXI83 tlLWKf3j89ECUP6m2GVoDiYRclqxVqrwepriFE/bcX8AsIAsQNCGRV4OhKlx2xjzuXKV QqUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j1oTdGaEQ77wKFt5yMUzZqXg44oVq6MHBdIKvRtKHso=; b=MvEwzswD8byOkxQCjpCqyNW97HCloTSse5AP0U5W/ASzuWffA8onRbd2kPRWtmh03n pLUTk5thOcC8sh60JAABESLu57KNj0eM6PBIJaUAoaZnIolHSYRGxXLEgJ4K9vuYNJHY WxuDVDQkJX92lrZzjT707MtUUng+8o77/rIJfpg040G//7sbr52A4GOOzMtxT9iyn2Tx kAy/Q+DxMdP1sRWm5v1k68FKB8iGR+kzEZac7I5WvFXDnSVCU50PGtl/fA5Z4Joj5eSH PzF2ZtvJWTKZYjyUG4HFpUcNlHXBp568qFx59BmjvOgFeFUkO/b5xR210VW0HfvjfHg9 /RoA== X-Gm-Message-State: AOAM531zCI8SHydpUUSkTx4GuN0mUInGyBoYzqhxvdyIpg4lunPiYsBj haAJfOEH5MhBlDE9aJo+ly1O+w== X-Google-Smtp-Source: ABdhPJwibZhgd98KMXz/38f1bi6OLY99Lu6tvHg+uIoC2n0wFaLTXoWHoZpl/kqoKRgpcmyUUWlhJw== X-Received: by 2002:a05:6512:131d:: with SMTP id x29mr3220085lfu.655.1627549822611; Thu, 29 Jul 2021 02:10:22 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id v130sm243109lfa.284.2021.07.29.02.10.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:10:22 -0700 (PDT) Subject: Re: [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660 To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jonathan Marek , Abhinav Kumar , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210728222057.52641-1-konrad.dybcio@somainline.org> From: Dmitry Baryshkov Message-ID: Date: Thu, 29 Jul 2021 12:10:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728222057.52641-1-konrad.dybcio@somainline.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 29/07/2021 01:20, Konrad Dybcio wrote: > VDDA is not present and the specified load value is wrong. Fix it. > > Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 - > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index f3f1c03c7db9..763f127e4621 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -154,7 +154,6 @@ static const struct msm_dsi_config sdm660_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdd", 73400, 32 }, /* 0.9 V */ > {"vdda", 12560, 4 }, /* 1.2 V */ > }, > }, > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index a34cf151c517..bb31230721bd 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1050,7 +1050,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vcca", 17000, 32}, > + {"vcca", 73400, 32}, > }, > }, > .ops = { > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B04C4338F for ; Thu, 29 Jul 2021 09:10:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2799B60F0F for ; Thu, 29 Jul 2021 09:10:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2799B60F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D12B6E98C; Thu, 29 Jul 2021 09:10:25 +0000 (UTC) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53FFA6E853 for ; Thu, 29 Jul 2021 09:10:24 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id r17so9710403lfe.2 for ; Thu, 29 Jul 2021 02:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j1oTdGaEQ77wKFt5yMUzZqXg44oVq6MHBdIKvRtKHso=; b=xiRwb6lr+yN2TvAWWqnnWrrLDB723jy82nWZmOQ8iowGgp/4xpqEERcNg7aNe5TMiu /KXTATfbuD5j1Pnh2+TbZ9CCZp9PqZ1qebUtJQK8wDsCEIJGEQpJzKE4QRNKY6utUDp+ BEapaAqUXw0T9DqgL1mfwrMFNCtjgrduBVYu4KMH8cNbOfU19ti5pTFvRPbHaPSExcRi sDvrhiOGF3CsPKysGtGFELNvONsDuI9ZtUQNFJqBxo4dEFtvnLBCPZeL1bDsdrzaXI83 tlLWKf3j89ECUP6m2GVoDiYRclqxVqrwepriFE/bcX8AsIAsQNCGRV4OhKlx2xjzuXKV QqUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j1oTdGaEQ77wKFt5yMUzZqXg44oVq6MHBdIKvRtKHso=; b=it/uQQ7Oom59QSnaKanwnFXPWxcSLE8lM+Jydfb31YsFOet3EDDMRKhMSY3bLN5+EU 4WHL/fwIdITvyQ76OZaD0Oe4EC8krht4i5BZ4cd5Vf0E+wxI2UihFU+dZTPRvlsX9De8 RqMXNu1MmzOarfzWLdYBvQu8+4oF6frd0ApVhTl7Cx73+gnTAEnEQYgbCI8pWdmnPVcI XfpdGXhU+51PwK8IHOEbg7UxqHmCa/kzR4RC2a2vam9M6uoPoyRgeTFWgXCljHEfUgjZ OrYC8npFyk+mWgYQWLYoeXhfPIOwMXy1Z71Z2TMo+MptkPTlavRW3d2YWIrH/k9ksFEq fOLQ== X-Gm-Message-State: AOAM531TaC3vt+KGkp55B33Xcmo6mvVmcBswRzZe6B5/F8Ucu5A8JF4q AS3KL6mxAq0faew11zKbHOvTLg== X-Google-Smtp-Source: ABdhPJwibZhgd98KMXz/38f1bi6OLY99Lu6tvHg+uIoC2n0wFaLTXoWHoZpl/kqoKRgpcmyUUWlhJw== X-Received: by 2002:a05:6512:131d:: with SMTP id x29mr3220085lfu.655.1627549822611; Thu, 29 Jul 2021 02:10:22 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id v130sm243109lfa.284.2021.07.29.02.10.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:10:22 -0700 (PDT) Subject: Re: [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660 To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht References: <20210728222057.52641-1-konrad.dybcio@somainline.org> From: Dmitry Baryshkov Message-ID: Date: Thu, 29 Jul 2021 12:10:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728222057.52641-1-konrad.dybcio@somainline.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jamipkettunen@somainline.org, martin.botka@somainline.org, Abhinav Kumar , angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 29/07/2021 01:20, Konrad Dybcio wrote: > VDDA is not present and the specified load value is wrong. Fix it. > > Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 - > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index f3f1c03c7db9..763f127e4621 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -154,7 +154,6 @@ static const struct msm_dsi_config sdm660_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdd", 73400, 32 }, /* 0.9 V */ > {"vdda", 12560, 4 }, /* 1.2 V */ > }, > }, > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index a34cf151c517..bb31230721bd 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1050,7 +1050,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vcca", 17000, 32}, > + {"vcca", 73400, 32}, > }, > }, > .ops = { > -- With best wishes Dmitry