From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F60C433FE for ; Mon, 20 Sep 2021 09:53:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37BFA60F9D for ; Mon, 20 Sep 2021 09:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37BFA60F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5434E6E457; Mon, 20 Sep 2021 09:53:39 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA3E56E454; Mon, 20 Sep 2021 09:53:37 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="286773771" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="286773771" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:53:37 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="473541206" Received: from yohlee-mobl1.gar.corp.intel.com (HELO [10.214.151.93]) ([10.214.151.93]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:53:32 -0700 Subject: Re: [PATCH v3 4/6] drm/i915/gt: Register the migrate contexts with their engines To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: maarten.lankhorst@linux.intel.com, Tvrtko Ursulin , Brost Matthew , Chris Wilson References: <20210914193112.497379-1-thomas.hellstrom@linux.intel.com> <20210914193112.497379-5-thomas.hellstrom@linux.intel.com> From: Matthew Auld Message-ID: Date: Mon, 20 Sep 2021 10:53:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210914193112.497379-5-thomas.hellstrom@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 14/09/2021 20:31, Thomas Hellström wrote: > Pinned contexts, like the migrate contexts need reset after resume > since their context image may have been lost. Also the GuC needs to > register pinned contexts. > > Add a list to struct intel_engine_cs where we add all pinned contexts on > creation, and traverse that list at resume time to reset the pinned > contexts. > > This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now, > but proper LMEM backup / restore is needed for full suspend functionality. > However, note that even with full LMEM backup / restore it may be > desirable to keep the reset since backing up the migrate context images > must happen using memcpy() after the migrate context has become inactive, > and for performance- and other reasons we want to avoid memcpy() from > LMEM. > > Also traverse the list at guc_init_lrc_mapping() calling > guc_kernel_context_pin() for the pinned contexts, like is already done > for the kernel context. > > v2: > - Don't reset the contexts on each __engine_unpark() but rather at > resume time (Chris Wilson). > v3: > - Reset contexts in the engine sanitize callback. (Chris Wilson) > > Cc: Tvrtko Ursulin > Cc: Matthew Auld > Cc: Maarten Lankhorst > Cc: Brost Matthew > Cc: Chris Wilson > Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC76C433F5 for ; Mon, 20 Sep 2021 09:53:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5495B60F9D for ; Mon, 20 Sep 2021 09:53:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5495B60F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B68F66E454; Mon, 20 Sep 2021 09:53:38 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA3E56E454; Mon, 20 Sep 2021 09:53:37 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="286773771" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="286773771" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:53:37 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="473541206" Received: from yohlee-mobl1.gar.corp.intel.com (HELO [10.214.151.93]) ([10.214.151.93]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:53:32 -0700 To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: maarten.lankhorst@linux.intel.com, Tvrtko Ursulin , Brost Matthew , Chris Wilson References: <20210914193112.497379-1-thomas.hellstrom@linux.intel.com> <20210914193112.497379-5-thomas.hellstrom@linux.intel.com> From: Matthew Auld Message-ID: Date: Mon, 20 Sep 2021 10:53:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210914193112.497379-5-thomas.hellstrom@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/gt: Register the migrate contexts with their engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 14/09/2021 20:31, Thomas Hellström wrote: > Pinned contexts, like the migrate contexts need reset after resume > since their context image may have been lost. Also the GuC needs to > register pinned contexts. > > Add a list to struct intel_engine_cs where we add all pinned contexts on > creation, and traverse that list at resume time to reset the pinned > contexts. > > This fixes the kms_pipe_crc_basic@suspend-read-crc-pipe-a selftest for now, > but proper LMEM backup / restore is needed for full suspend functionality. > However, note that even with full LMEM backup / restore it may be > desirable to keep the reset since backing up the migrate context images > must happen using memcpy() after the migrate context has become inactive, > and for performance- and other reasons we want to avoid memcpy() from > LMEM. > > Also traverse the list at guc_init_lrc_mapping() calling > guc_kernel_context_pin() for the pinned contexts, like is already done > for the kernel context. > > v2: > - Don't reset the contexts on each __engine_unpark() but rather at > resume time (Chris Wilson). > v3: > - Reset contexts in the engine sanitize callback. (Chris Wilson) > > Cc: Tvrtko Ursulin > Cc: Matthew Auld > Cc: Maarten Lankhorst > Cc: Brost Matthew > Cc: Chris Wilson > Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld