From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47126C54EAA for ; Tue, 31 Jan 2023 01:03:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B842F6B0072; Mon, 30 Jan 2023 20:03:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B33A66B0073; Mon, 30 Jan 2023 20:03:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9858C6B0074; Mon, 30 Jan 2023 20:03:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 85F856B0072 for ; Mon, 30 Jan 2023 20:03:22 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5EB46120BC6 for ; Tue, 31 Jan 2023 01:03:22 +0000 (UTC) X-FDA: 80413295844.29.07FDB40 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf11.hostedemail.com (Postfix) with ESMTP id BD04740007 for ; Tue, 31 Jan 2023 01:03:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V8XGRm9y; spf=pass (imf11.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675126999; a=rsa-sha256; cv=fail; b=WfevleVaYf4DjVn9yyCnZta/A4XZca9XoH3UPoCemrk8ZFVUQ3GZSSZ6+EEYVG02RtH87z hF7nTUuxkT7Lk33JV6BWtx8zWoTTd3s2J69S9fPDYt4jC0EsyJek1E6aVrffUx8PHCZimP uGpst/kgfpmayLnQOzwZkJnowYowv28= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V8XGRm9y; spf=pass (imf11.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675126999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3V/rjHNtjmczaxigmYQL53sIG4i6DnAVfDpE4Q3NK/k=; b=pVlJ8B0XQj+mskAatOFcLKMSmywFyAJ2GC+y1kcqGyT18zym1MzXqre+BH0/fE/ZIcS8kt ZwbmDaqS8XfQCsFdTvTUDD7vXDFkzh5bFVkAAYgWLCuDpSvrDtlOmGCa9moKoZWsehpilG gV6wqh8TNejBK5H2LFxwRlcJiJK3/tw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675126998; x=1706662998; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sXawECdU1OgExeSORdUSt+pht4J55ScWee4T+3C9K9g=; b=V8XGRm9y8FKuFigvKtmZXLto7acSFnxJzJBlApUihHCfNrfPL6OYj+wi GXwUh7547TKtZ4YhtUiOJkl+39csZpAWVOunumCXhb2Uk3FiO8/+n5oiI NB11QjuP7WfO/DxSLqNo/VBtozwBPPbKY+HOY9g0bX0Hnci6PBzWEbbIb /LPDWJh+NT/P3gbZ15Cy6wBmYaXThIzR/ULcDJNIyuNbtGhhsEERx1I1v AkM7WmAVjxmBwMY8lBd70H8eXi3Gz0FrfpU6oUZFOeJge5Vt8VPgeQ1B9 Y8sqsga48pLmUYQZrqHr5e0YKqVRJW2+IIJc6lrtCVO/4Ht8un0hzwZ6a w==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="392268966" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="392268966" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 17:03:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="788240557" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="788240557" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2023 17:03:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 30 Jan 2023 17:03:16 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 30 Jan 2023 17:03:16 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 30 Jan 2023 17:03:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyqGz/2QRttcdK1GuEV+UOKEW3TJELehVF22qz02B7F4E5qdjGjPy4FeH+gdQdqpZMz6nOp5nuDl2LeLkANCpj7A8dWO1d/4SUws/GztG2ci7mk/QTkuRH1zmhyBBOxY9wwFXh/WFmWHvh8SPB7+b8fgxQcTcPjDFTGb8ZN/08UP3Z0HW6sPWS+WyNeCVEAmo2Jj0q3FaFD+AKHQ8ozW2iutlNLsYEV90Yi9dcXuvTdAqMdRfNkIkXWswjQ+7eM/IHG8n5ua7C00ntKiqJmtp24KfTXk6MDtDj382j2wU0V2sdvd9HS5njG9A3NRxDn48/7y+67LednJddQMkDPv9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3V/rjHNtjmczaxigmYQL53sIG4i6DnAVfDpE4Q3NK/k=; b=Cfbj31UYA7eOQzW82ms3QNEf4bVMS5YFqDd+HmSdN2RrpZ/m3rtaAjw8U83Fr5wY9gfV8niuBoMZvLnJ3Oq/JIKZsraEVxecHAeNRWzwIaxmVu5d7KbfrXU2mUG+F/zCHo2Z1x/tdgMlBBTmF4iE/7/CpMuLyH7Ei0TZBsJDpPe2srjlIzlypPoYKi8R0GKvy1T0X05/bzH7UVuCIbWYT1sK3obKi831+kadXmoxpDWQh9CaZbCvib8M1TYNubKClTZspBsx1P/scRYSZhvzPqtSsEYHWcDLpSnChSUe4e4g0LPjmidJiJDwW4uCPBqpWCG7ijAJdEwlzI6Hm+C7hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) by SA2PR11MB4954.namprd11.prod.outlook.com (2603:10b6:806:11b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 31 Jan 2023 01:03:14 +0000 Received: from SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf]) by SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf%9]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 01:03:14 +0000 Message-ID: Date: Tue, 31 Jan 2023 09:03:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 2/5] filemap: do file page mapping with folio granularity Content-Language: en-US To: Matthew Wilcox CC: , , , , References: <20230130125504.2509710-1-fengwei.yin@intel.com> <20230130125504.2509710-3-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0027.apcprd02.prod.outlook.com (2603:1096:3:18::15) To SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB4831:EE_|SA2PR11MB4954:EE_ X-MS-Office365-Filtering-Correlation-Id: 846313e5-6398-4787-784a-08db0326ee26 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QkhvpCG0B26494SiVJseb51fg8dkU9fYmGxw2fD8me5TGYWsSJGRRP6h/YRWQ50XqJhm63j1PtzUn3Mrr216Rv8dGhN4mYm8MA7gupAD4XNantkSZ8R4oOjJ/hVa+PUSTRAaS5DmCXMoLVi6dK1GDt+Gf1Rh++0wPg6HIYlhQ0AR1CaVsXM2iSnIQ3kpWwsbRgUJR017YU1IR5JqoyJftk2V3C5e8Js6AOLFyyk5sDNN5QGpNN9ZJijSDu30B4hoH0GYZ6rR8pLJrQ7eYsA3ZFFyv65qEWJMn8L9U07clc6mGdJ0mLDGYS2EWNH64NNR4ctVleMf++vvYuo4L4W8WJAjWI83NqWTgOQiD26CSJHZf5XFetXZBpH4aaK8ief9xNfDwQJZp4eP/wyikzKIqOeRd87/hnq1cm8HaGir7UjvYrEBX+xS4JDWWO4XOQU2TIyCDcs2iDrRlmrZjpjD7CzEKEnksSHmVe8XC/jfhYcz+Wt+Nf8gCKZjyD7bkxLTsr9j8W/TFXHsRVnUUatmrp1sr6qhZWIomrRj0p2MEjiMMPJerZKumvC3uVqW57o3p5N+jSFoKOVwV3QLRPh+7KqfQXP6eBFz8PCdjoBzp+r/CPNoMYXTqwOSQys+YuH7BSI072OxJEcWxFU8/tW29uR8mZ8jdvifQOccqDiBfWutUNhxiN85ZTe3P6wJYt6e+9ZfKz6QD0/AQXawJWl+XrPUrQeWrT/3u95rDFUN21U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4831.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199018)(8936002)(41300700001)(31696002)(86362001)(5660300002)(83380400001)(82960400001)(2616005)(4326008)(316002)(66946007)(38100700002)(8676002)(66476007)(6916009)(66556008)(6666004)(186003)(6506007)(6512007)(53546011)(36756003)(26005)(478600001)(6486002)(107886003)(66899018)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTB0RlVnNWZMY3RlUDRvRDB0ZnJGWG9ZZlh1Wm84aUxGcXFjcHFLb2tjaUYr?= =?utf-8?B?dGJuQlRTQUVCNWpPQlB2ckJOU21RMDlaTk5vU1JpVXVJdlNmZ2IrMG05Tktj?= =?utf-8?B?NHF4RVZva0kyNm0rSENadmd3UlFxT3dWTE4rQ2R1bElkc3NwWXlKcjFWcDg1?= =?utf-8?B?bnhZQjNWdnhISDFBYTVOVzJCVDYyNzhkV0tCTndlRnk1dE15Tk40c0FKSVI5?= =?utf-8?B?ZzVZWVZPSCt5dWZNN3lWanJocG1yQ2h4Mm1VTUhrVDVwcGtlc3ZwamhYUDlH?= =?utf-8?B?K0pleWZvK1lBUkVJeUxXZEpRMERUTEptcDVYRm5PbkxJK0VzZGZQQWcyUC90?= =?utf-8?B?SURzYnRCZEVwTVBPZHI2YVBQT21MbnVVUG9Fa1U1T0NSTDdNVFRsWGFPeU9V?= =?utf-8?B?Q0NRaDYvWFMxQk9jdGNleEVhcW5MdGx1eHZSQlB6OS9kU3pLTHdWdmJ6N0FG?= =?utf-8?B?a0tVZGJpeDN4RzJ0OFdqWVIzZGpIbG8yNnBCRCs2TnB3cGM4bDlqcHllSkt0?= =?utf-8?B?L1U3S3A2T2M2WkhEQmFWWVIvRkxsQzR4c0hUNE1xQUs0NGRsMjFrQmczS2l1?= =?utf-8?B?bVUrK3FhWFRvTjZoWFBXdXM4Mmk4Z0JoZWdBN0s3WFo5R3RQUnNYVlZES3lX?= =?utf-8?B?L1RnTFRZZEI2SUJtRlVqOUEzMzZkZVUwTDlrVW5rNCtKZVZib3J0cGd0cDd0?= =?utf-8?B?LytRRzBxZVI0ZkRYQkU4Zk00bXBJSWtaaW53TStOOWxRaFpwTnVVUDZjdTZw?= =?utf-8?B?WVhXRGpqZk1PSTcrdjYzcG1vNFJUZStmQXAwVGhxSjhVbGpWOE9vRUZ4N0xJ?= =?utf-8?B?dVFFTCt5VHlWeEZwdDdIWExxakkyaExBak5lNXdGeUVwZzYreDE0YmsrT0w0?= =?utf-8?B?ZjhKYXBCTlNOeTVYRGRIMEF0dnZzbHRZVGdVYWdzWnBwd2h1ZHRWL0V3WWov?= =?utf-8?B?WVhPVDM3eElpMnY4bVR0K0pFK09nRnl5czhEcWp0STZNZk5FTDlzVERST2M3?= =?utf-8?B?VkRqSkd0ZTFCVEE2M1NaYnVueW5Ed1JybmpmNHo3N1FJTXMxdm1KTjJlaEtU?= =?utf-8?B?VEtweUZna2dTbVFTVjJFQkoybXdVTnlVY1h2SmcwK2dqUkJjc0grcmZFNWlu?= =?utf-8?B?b0Q0VkRyekdsdTNicFFOdVlxOUNTYnNNMmI0NDRoUWoyYkNya2RjQmtOcEVp?= =?utf-8?B?bWFNUXVURmsvUS9wZU1maUl3NEpkeTE5ZnFncDN1b2U0L3FBdGhNMUsyZHNP?= =?utf-8?B?enFRNXQ1MDRSVFRkMHhmdkRFcDFnWEtWU1R4c1hocGFDRkNkdG9UOWtTZ3J4?= =?utf-8?B?a0pML25QYVMwVlU0bzRPVS9yM2h4b3RmK0dWMm9Nc3ZmUjN3TGRYalJOQ0FX?= =?utf-8?B?RVVkZkUwL0VsbzB1LzNqcCtQZ05yZXhwY1VHK2k1ZVdNOGlBV1hFV1NuYjNE?= =?utf-8?B?ckdpa1VOZzF1YWI4dTFDV0lNNk1kVHZzMUxiK2FONXlndmdGdDU5cndqdkFF?= =?utf-8?B?cjVwYTlQVitFdXVGTUZUc1FYZ1FDRzZMNFg0U1k1U1VkK3FIK3FxNFZhVTJo?= =?utf-8?B?dDRnSjNYaEpRcXlDM3ozM0dCNkVFMHdvZFFLWDY2c3VtbC9NTWJablNmMU51?= =?utf-8?B?c3IzV1Z4YkZnZEhRLzVaOTBzcWlnR2t6YTBqQTZwb0RSZzdzUlFlWlFVQ2Vu?= =?utf-8?B?d1RDZFRXTGd5S2RxN3RDZXFyNGV5dXBwQmFKSWtHeXFRamZQa3o3Y2VLbVVZ?= =?utf-8?B?OG5pUW1TbWRkM2NKZXZJSEJpQy9TNVJPWFNpUDZaUWY1ZDZuQTIvb3pRS25D?= =?utf-8?B?bFN6enFZeW5FWTQwU1A2VEUzb0hkY0JTdldCQkdyUGphK0VtUWJDMzNmZENQ?= =?utf-8?B?SVhVVE9IU05EalRGR1ljMlliQW9HMDZKalVHQWthODRkUnF4bnRsVko2cEtQ?= =?utf-8?B?cnpNUTJOT1BtYjZjK25hUzhqZWVKN2E2dHhhZHNvbEFoWjNVMDB4MU9wTlNU?= =?utf-8?B?SnYxWm1MRXhySkdTd1lJUm4wdDc3QUExU2ZoT3Y2WFNrdUZNVnBMRWFWdEVt?= =?utf-8?B?ajE4K3dGcUZwWGJGRmFwUHBrRkRWVUsvdXZBOVQ0bWM0MHFGZGQ5NTFtM2kw?= =?utf-8?B?UXBaanhEUVBCRTRtR3ExbkZMRm9HUTdFeWFoVXdseWwydWxpMTAybUpJbnd2?= =?utf-8?B?aVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 846313e5-6398-4787-784a-08db0326ee26 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4831.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 01:03:14.5476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6r/4QrpLpB8ES0hMUH+YuxBeRGov40mfIs35WDDoXDtt4E/dr+uAJkgMkNXiqWoxmPgCgbE84jrrR7h90UsMFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4954 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: BD04740007 X-Rspamd-Server: rspam01 X-Stat-Signature: pyb37pc9uh8z341t9ujmehg6t8kia3kg X-HE-Tag: 1675126998-15744 X-HE-Meta: U2FsdGVkX18VQNuwPARguQ7wrrBqilSlTzIm76cB2y29a+PFBSrZgG/A2Jl+hhhOu/ZrcXDMPS5Z2SwXvI7zxGqWCEO3hWQss6F7rnTuJca5rq/alnM2MjDtn6jfkfWDfv9FIbbgCna/In+4DOSrOffCvyug1he8PSs4lGbv1tXfUyoDSJTbahCUmYqIyTHqb+cZqotbGk2VRYdZOIbkPXELHqfEWgU/Zxt93a9M+TI7z+zK7picMU6fvA+KRLP9u0BxNdY5W5fnoyJ1TWRSUcjTRVzPBuc/rA+UqZUd6R2Z7ubLQFsjdqdn+g1oY0Ik/C3xSQZlo7HsJUxcxnPwams6TgqDj6B43rh0YqvdK0/uid0RSDBNBV239TgZ65ysWOLVQ5SAnlZxl9R/pK72rei40EJbnNVnGT4lRpvip9O5/MYFv716KyUzOy+IeTFQOEqWqKd+noNNhQFsuWSbE/tpI4C3/HO3OJPIvMJjIkPRsdn+pGePsx6QlcDPvRdfY9zv3x17HDJ65Pt1SzwQDi2u4JL1HK807jre8eYWJii3FapP8tg2e67t7hQqmY7l6iAZTJuCnwfKRcHHSiMUoGpvDxaGAqmlAHkQwXHJvLIZAsoWfIjmGvPu1jTK+2WtHVKuYMrUDgMoFly3bDfZthRXZkoR4YhjmlgzwDake4H+ZkftjNy6v4pPqUpqNQAqAEkxsPiv7eabehfAa4cvgILWg+gIMVaB3c2J6WygXE9qdLY9TsHaiVwCFXNGDyilTGnOD95WByqt8yYJ2jzg2jvM+fisFTDWV/19Iyh7LVWHr9YM6dWSjKulW62/PUrLMH9BVYiuANtzRb+4nhN9yOaYJqGh2Cf7cJwiOTZZEOWVLn3LyBX8VnfTRuzemhTiDzIX1AqpBWZkFLXz08JtKoo97iZ8UBJGly8bbzXJc3NUgRqCtCuE5V6f1p78dy+oe+1vvnFqI/MhktiTIZI v9Tqj+IT F7yNhINyRz+YJgNkPrp56lXUg7LELC0Au8eJPeuBTbLP5teUBPih9e6RpHmEbc/CuwV893Cmwvchn8j0j2dL79e4sLVNqxSODlBy59lVfrsHAFQ35Yo6oZaNLmeBBb2dRhpMuKJ3AXrhkznW+rvQdBrUP9nRv7SKPiv9JdNAWxA/7Nim6kDT/VmDaM9MRcM6tdCBg+5IKjvnRO53w4XHVsv3RL5rb9Ty6hYa8OID2Gn4ME2Y0HxWXyEayQi01jA8+hKStRP7fAh/HXzMmzrDtEOK2BRu9VRFZar3m0Vg/RfRQmQNbtwKe9rapVjzyQt+QSaYQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/2023 9:35 PM, Matthew Wilcox wrote: > On Mon, Jan 30, 2023 at 08:55:01PM +0800, Yin Fengwei wrote: >> Add function to do file page mapping based on folio and update >> filemap_map_pages() to use new function. So the filemap page >> mapping will deal with folio granularity instead of page >> granularity. This allow batched folio refcount update. >> >> Signed-off-by: Yin Fengwei >> --- >> mm/filemap.c | 82 ++++++++++++++++++++++++++++++---------------------- >> 1 file changed, 48 insertions(+), 34 deletions(-) >> >> diff --git a/mm/filemap.c b/mm/filemap.c >> index c915ded191f0..fe0c226c8b1e 100644 >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -3351,6 +3351,43 @@ static inline struct folio *next_map_page(struct address_space *mapping, >> mapping, xas, end_pgoff); >> } >> >> + > > I'd remove this blank line, we typically only have one blank line > between functions. OK. > >> +static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >> + struct folio *folio, struct page *page, unsigned long addr, >> + int len) > > I see this under-indentation in other parts of the mm and it drives me > crazy. Two tabs to indent the arguments please, otherwise they look > like part of the function. OK. I will correct all the indent problems in this series in next version. > > Also, 'len' is ambiguous. I'd call this 'nr' or 'nr_pages'. Also > it should be an unsigned int. > >> +{ >> + vm_fault_t ret = 0; >> + struct vm_area_struct *vma = vmf->vma; >> + struct file *file = vma->vm_file; >> + unsigned int mmap_miss = READ_ONCE(file->f_ra.mmap_miss); >> + int ref_count = 0, count = 0; > > Also make these unsigned. > >> - /* >> - * NOTE: If there're PTE markers, we'll leave them to be >> - * handled in the specific fault path, and it'll prohibit the >> - * fault-around logic. >> - */ > > I'd rather not lose this comment; can you move it into > filemap_map_folio_range() please? I will keep all the comments in the right place in next version. Regards Yin, Fengwei > >> - if (!pte_none(*vmf->pte)) >> - goto unlock; >> - >> - /* We're about to handle the fault */ >> - if (vmf->address == addr) >> + if (VM_FAULT_NOPAGE == >> + filemap_map_folio_range(vmf, folio, page, addr, len)) >> ret = VM_FAULT_NOPAGE; > > That indentation is also confusing. Try this: > > if (filemap_map_folio_range(vmf, folio, page, addr, len) == > VM_FAULT_NOPAGE) > ret = VM_FAULT_NOPAGE; > > Except there's an easier way to write it: > > ret |= filemap_map_folio_range(vmf, folio, page, addr, len); > > > Thanks for doing this! Looks so much better and performs better!