From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B0EEC433F5 for ; Fri, 15 Apr 2022 06:17:11 +0000 (UTC) Received: from localhost ([::1]:60428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfFGX-0006iZ-T7 for qemu-devel@archiver.kernel.org; Fri, 15 Apr 2022 02:17:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfFCs-0005E6-Vx for qemu-devel@nongnu.org; Fri, 15 Apr 2022 02:13:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48200) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfFCr-0005P3-8K for qemu-devel@nongnu.org; Fri, 15 Apr 2022 02:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650003200; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2kFeMkOQD8FYRKavrs3YwOQCweUqQ+elnLR6esje7A=; b=GstaySNTIWVgQVjfLBiieFU/pPKIGIiiO9Ck2DbUXRNNWFdAbK61IfB+29QzEmnfDeM7nJ QsTrEavR0rX/DhieMxKWQl37SRyVgV7y0YxgxKBVnp6HdfZgruGAVxJBqVQm3fTI8O6l8S Cimn8e7J4B+7YhkzakStYiYUHQ+vcxk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-O3LmHFwmP9a5WeSyhwCBxQ-1; Fri, 15 Apr 2022 02:13:17 -0400 X-MC-Unique: O3LmHFwmP9a5WeSyhwCBxQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80AB6185A794; Fri, 15 Apr 2022 06:13:16 +0000 (UTC) Received: from [10.72.13.171] (ovpn-13-171.pek2.redhat.com [10.72.13.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC5A1C07F43; Fri, 15 Apr 2022 06:13:11 +0000 (UTC) Subject: Re: [PATCH v5 2/4] hw/arm/virt: Consider SMP configuration in CPU topology To: Jonathan Cameron References: <20220403145953.10522-1-gshan@redhat.com> <20220403145953.10522-3-gshan@redhat.com> <6f713fec-71e6-3300-a504-817f45a82a51@huawei.com> <27df8771-ebe0-b5fe-39c4-83696e21e3a3@redhat.com> <503fb329-8f39-eddb-d05a-729279934fa7@redhat.com> <20220414103310.0000356a@Huawei.com> From: Gavin Shan Message-ID: Date: Fri, 15 Apr 2022 14:13:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20220414103310.0000356a@Huawei.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: peter.maydell@linaro.org, drjones@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, zhenyzha@redhat.com, "wangyanan \(Y\)" , qemu-arm@nongnu.org, shan.gavin@gmail.com, imammedo@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Jonathan, On 4/14/22 5:33 PM, Jonathan Cameron wrote: > On Thu, 14 Apr 2022 15:35:41 +0800 > Gavin Shan wrote: >> On 4/14/22 10:49 AM, wangyanan (Y) wrote: >>> On 2022/4/14 10:37, Gavin Shan wrote: >>>> On 4/14/22 10:27 AM, wangyanan (Y) wrote: >>>>> On 2022/4/14 8:08, Gavin Shan wrote: >>>>>> On 4/13/22 8:39 PM, wangyanan (Y) wrote: >>>>>>> On 2022/4/3 22:59, Gavin Shan wrote: [...] >>>>> Oh, after further testing this patch breaks numa-test for aarch64, >>>>> which should be checked and fixed. I guess it's because we have >>>>> more IDs supported for ARM. We have to fully running the QEMU >>>>> tests before sending some patches to ensure that they are not >>>>> breaking anything. :) >>>>> >>>> >>>> Thanks for catching the failure and reporting back. I'm not >>>> too much familar with QEMU's test workframe. Could you please >>>> share the detailed commands to reproduce the failure? I will >>>> fix in v6, which will be done in a separate patch :) >>>> >>> There is a reference link: https://wiki.qemu.org/Testing >>> To catch the failure of this patch: "make check" will be enough. >>> > > Speaking from experience, best bet is also upload to a gitlab repo > and let the CI hit things. It will catch this plus any weirdness > elsewhere without you having to figure out too much unless you see > a failure. > > The CI is pretty good though more tests always needed! > Thanks a lot for the hint. I usually use github to host my code. I will setup gitlab repositories so that the verification and tests can be automated. Not sure if there is any document on how to trigger the automatic verification and testing from gitlab? [...] Thanks, Gavin