From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Commit 1fe8e0... (include more headers in if_tunnel.h) breaks my user-space build. Date: Fri, 13 Jan 2017 11:12:32 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit To: netdev , mikko.rapeli@iki.fi Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:53548 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdAMTSY (ORCPT ); Fri, 13 Jan 2017 14:18:24 -0500 Sender: netdev-owner@vger.kernel.org List-ID: I am including netinet/ip.h, and also linux/if_tunnel.h, and the linux/ip.h conflicts with netinet/ip.h. Maybe my build environment is screwed up, but maybe also it would be better to just let the user include appropriate headers before including if_tunnel.h and revert this patch? include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h Fixes userspace compilation errors like: error: field ‘iph’ has incomplete type error: field ‘prefix’ has incomplete type Signed-off-by: Mikko Rapeli Signed-off-by: David S. Miller Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com