From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Tue, 21 Apr 2020 05:57:01 +0000 Subject: Re: [PATCH 4/5] backlight: led_bl: fix led -> backlight brightness mapping Message-Id: List-Id: References: <20200417113312.24340-1-tomi.valkeinen@ti.com> <20200417113312.24340-4-tomi.valkeinen@ti.com> <20200420155514.lyb73ujf5fzgpvp4@holly.lan> In-Reply-To: <20200420155514.lyb73ujf5fzgpvp4@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Thompson Cc: Jingoo Han , linux-fbdev@vger.kernel.org, Lee Jones , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz On 20/04/2020 18:55, Daniel Thompson wrote: > On Fri, Apr 17, 2020 at 02:33:11PM +0300, Tomi Valkeinen wrote: >> The code that maps the LED default brightness to backlight levels has >> two issues: 1) if the default brightness is the first backlight level >> (usually 0), the code fails to find it, and 2) when the code fails to >> find a backlight level, it ends up using max_brightness + 1 as the >> default brightness. >> >> Fix these two issues. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/video/backlight/led_bl.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c >> index 63693c4f0883..021b5edd895c 100644 >> --- a/drivers/video/backlight/led_bl.c >> +++ b/drivers/video/backlight/led_bl.c >> @@ -159,10 +159,11 @@ static int led_bl_parse_levels(struct device *dev, >> */ >> db = priv->default_brightness; >> for (i = 0 ; i < num_levels; i++) { >> - if ((i && db > levels[i - 1]) && db <= levels[i]) >> + if ((i = 0 || db > levels[i - 1]) && db <= levels[i]) >> break; >> } >> - priv->default_brightness = i; >> + >> + priv->default_brightness = i < num_levels ? i : 0; > > This seems a bit odd. If the LED is currently set to brighter than the > maximum brightness level why would we choose a default brightness of > zero? Indeed, better to set it to max. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B185C2BA19 for ; Tue, 21 Apr 2020 05:57:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D82142071E for ; Tue, 21 Apr 2020 05:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="bKJhu38s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D82142071E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41BD56E876; Tue, 21 Apr 2020 05:57:07 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 684E36E876 for ; Tue, 21 Apr 2020 05:57:06 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 03L5v4Oi024178; Tue, 21 Apr 2020 00:57:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1587448625; bh=lEPFY3sdNt+zO3O+OUJhUYR9jmgRloBcGSEbsMTsgZM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=bKJhu38sj4KLljzyigvb1UiT3Qbizn561QC5niwZdyH6LfoDkwgZvYJw18MkVhD1z UymbNwXYvXyshP9rWbl1LeLVA19PmFbhPvbPJgzF1RuT8i8Ljm2M6aYdfTgzMvmQwI MBIZrWZtbR0uj0i+zj7bWL2Uo6DNPQP2zUhE0fbU= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 03L5v4GM110696; Tue, 21 Apr 2020 00:57:04 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 21 Apr 2020 00:57:03 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 21 Apr 2020 00:57:03 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 03L5v2fq040981; Tue, 21 Apr 2020 00:57:02 -0500 Subject: Re: [PATCH 4/5] backlight: led_bl: fix led -> backlight brightness mapping To: Daniel Thompson References: <20200417113312.24340-1-tomi.valkeinen@ti.com> <20200417113312.24340-4-tomi.valkeinen@ti.com> <20200420155514.lyb73ujf5fzgpvp4@holly.lan> From: Tomi Valkeinen Message-ID: Date: Tue, 21 Apr 2020 08:57:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200420155514.lyb73ujf5fzgpvp4@holly.lan> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , linux-fbdev@vger.kernel.org, Lee Jones , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 20/04/2020 18:55, Daniel Thompson wrote: > On Fri, Apr 17, 2020 at 02:33:11PM +0300, Tomi Valkeinen wrote: >> The code that maps the LED default brightness to backlight levels has >> two issues: 1) if the default brightness is the first backlight level >> (usually 0), the code fails to find it, and 2) when the code fails to >> find a backlight level, it ends up using max_brightness + 1 as the >> default brightness. >> >> Fix these two issues. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/video/backlight/led_bl.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c >> index 63693c4f0883..021b5edd895c 100644 >> --- a/drivers/video/backlight/led_bl.c >> +++ b/drivers/video/backlight/led_bl.c >> @@ -159,10 +159,11 @@ static int led_bl_parse_levels(struct device *dev, >> */ >> db = priv->default_brightness; >> for (i = 0 ; i < num_levels; i++) { >> - if ((i && db > levels[i - 1]) && db <= levels[i]) >> + if ((i == 0 || db > levels[i - 1]) && db <= levels[i]) >> break; >> } >> - priv->default_brightness = i; >> + >> + priv->default_brightness = i < num_levels ? i : 0; > > This seems a bit odd. If the LED is currently set to brighter than the > maximum brightness level why would we choose a default brightness of > zero? Indeed, better to set it to max. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel