From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165A9C43461 for ; Fri, 4 Sep 2020 15:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0C382074D for ; Fri, 4 Sep 2020 15:27:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xb5Q8BrZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730879AbgIDP15 (ORCPT ); Fri, 4 Sep 2020 11:27:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730224AbgIDP14 (ORCPT ); Fri, 4 Sep 2020 11:27:56 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9062C061244 for ; Fri, 4 Sep 2020 08:27:55 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a17so7132943wrn.6 for ; Fri, 04 Sep 2020 08:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J54yf/+y6j9B4lqfF8MXGc99/gXu3ZgRSBAxExZh6jM=; b=Xb5Q8BrZovY7UOT2ygwdzPop/+q1i8UwiGV2oJyjmxraxd9UmjMAb3gigWWcQCf/HH wm/K7MRS2OZ6GrBphLHenp1StPKHMZN0of0bYp6ZW92Ru9D5r2cc81/pJ1+Uz70f1I5v 1kSf4zMpT/PE1pmChPTsgyOxgSdS7sX8oaJdi7IKSJIJivNEJcWpX/8UoNBRRNXg/2O/ vkmQVavijZPWZjCcJ9xlTyGSg2Rz/KOovzbgZB/8QmUIhfbvCz1NMKnEM3sc1SLUp2QD +NHAvvLXV4fyWo8oPfnB+hgMv+/YK+qQTXqF06ls8Pajkow69VJH/DWYsugWNYgniEke kxJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J54yf/+y6j9B4lqfF8MXGc99/gXu3ZgRSBAxExZh6jM=; b=qc1lFMvSYqwVu3BiCyTuSqZZRh9LCfmIns4yd1lxccnNZOMWQhlAJQrr0axbrMFqsJ Fg7q5haQB6uRtH5UyfCYa0KjR1Npi5n8XKtVqMsixR8QSu/+dO/8p10a5SQbxuuJJmfE mrGtIpBfNJEIkgH6iP77e6wCL5ivt4AYPzeDicixqAcVGE7iH5qxkKEd9Ntp0lV5B0+u HftD8qUj4TY3qCgPMVRoq5J7YK5oJaMSo9ZgCMWsNfPScqhkWfsgyvuJGck7om3f9b2h ILjUrhUxeFUK+oxICd8FUtLUd+cX8Klk9MHXW2W0tm6pHmMksNV+RYNThOkVhCxOSnwA OlnQ== X-Gm-Message-State: AOAM5309Mr8Lus0Ps/8kIubotZIYe5xLXh13iBzR43sbHYhxkMmbqoyY EwGFVnUzlAUfdwRAY5B4too= X-Google-Smtp-Source: ABdhPJz+vURV0StFNyGQNWTu2+LzPY8L0L0Don8L3RBD+x7T2KsDJU350RpgiyYsG70Qg29wu4Lf4Q== X-Received: by 2002:adf:db88:: with SMTP id u8mr8115534wri.184.1599233274436; Fri, 04 Sep 2020 08:27:54 -0700 (PDT) Received: from ?IPv6:2001:a61:3ab0:7001:e081:d401:3da8:e4bc? ([2001:a61:3ab0:7001:e081:d401:3da8:e4bc]) by smtp.gmail.com with ESMTPSA id y1sm11565920wma.36.2020.09.04.08.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2020 08:27:53 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, Jakub Wilk Subject: Re: [PATCH (2) 20/34] mbsinit.3: Use sizeof consistently To: Alejandro Colomar References: <26629635-bf4c-1279-314d-db92f11adbb7@gmail.com> <257c9374-3253-9091-c116-045ee16590c0@gmail.com> <40ba6e68-c2f6-649c-2225-6037e3c0c077@gmail.com> <8458b842-7d4b-f19b-c596-7f529dd48ba6@gmail.com> <497bc4f4-31f5-91a5-8bc4-469e22b26502@gmail.com> <8160510c-4d9e-7f30-e810-648b0b58a986@gmail.com> <87d5b09a-a3c8-622c-d731-5d42644a5f24@gmail.com> <61d2f2f9-08d0-9f1a-9642-ae56b3f4b61d@gmail.com> <4bb9e639-83ee-ede0-f6ad-dfc16787d358@gmail.com> <3c25bbda-bc90-1364-77cd-2c637f09d611@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Fri, 4 Sep 2020 17:27:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-man-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hello Alex, On 9/4/20 4:44 PM, Alejandro Colomar wrote: >>>From 77587b9c0b58cde232ea3bfaeef5f50607d83b5e Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar > Date: Thu, 3 Sep 2020 21:50:10 +0200 > Subject: [PATCH 20/34] mbsinit.3: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory Thanks. Patch applied. Cheers, Michael > Signed-off-by: Alejandro Colomar > --- > man3/mbsinit.3 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man3/mbsinit.3 b/man3/mbsinit.3 > index aeaa6ce88..74fe48f86 100644 > --- a/man3/mbsinit.3 > +++ b/man3/mbsinit.3 > @@ -59,7 +59,7 @@ in initial state is to set it to zero: > .in +4n > .EX > mbstate_t state; > -memset(&state, 0, sizeof(mbstate_t)); > +memset(&state, 0, sizeof(state)); > .EE > .in > .PP > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/