From: Jan Beulich <firstname.lastname@example.org> To: Andrew Cooper <email@example.com> Cc: George Dunlap <firstname.lastname@example.org>, Ian Jackson <email@example.com>, Julien Grall <firstname.lastname@example.org>, Stefano Stabellini <email@example.com>, Wei Liu <firstname.lastname@example.org>, email@example.com, Dmitry Isaikin <firstname.lastname@example.org> Subject: Re: [PATCH v1] domctl: hold domctl lock while domain is destroyed Date: Fri, 17 Sep 2021 08:17:02 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 16.09.2021 19:52, Andrew Cooper wrote: > On 16/09/2021 13:30, Jan Beulich wrote: >> On 16.09.2021 13:10, Dmitry Isaikin wrote: >>> From: Dmitry Isaykin <email@example.com> >>> >>> This significantly speeds up concurrent destruction of multiple domains on x86. >> This effectively is a simplistic revert of 228ab9992ffb ("domctl: >> improve locking during domain destruction"). There it was found to >> actually improve things; > > Was it? I recall that it was simply an expectation that performance > would be better... My recollection is that it was, for one of our customers. > Amazon previously identified 228ab9992ffb as a massive perf hit, too. Interesting. I don't recall any mail to that effect. > Clearly some of the reasoning behind 228ab9992ffb was flawed and/or > incomplete, and it appears as if it wasn't necessarily a wise move in > hindsight. Possible; I continue to think though that the present observation wants properly understanding instead of more or less blindly undoing that change. Jan
next prev parent reply other threads:[~2021-09-17 6:17 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-16 11:10 Dmitry Isaikin 2021-09-16 12:30 ` Jan Beulich 2021-09-16 13:08 ` Roger Pau Monné 2021-09-16 17:52 ` Andrew Cooper 2021-09-17 6:17 ` Jan Beulich [this message] 2021-09-17 9:27 ` Julien Grall 2021-09-17 9:41 ` Andrew Cooper 2021-09-17 9:47 ` Jan Beulich 2021-09-17 16:01 ` Julien Grall 2021-09-20 8:19 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1] domctl: hold domctl lock while domain is destroyed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.