From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbdANMxj (ORCPT ); Sat, 14 Jan 2017 07:53:39 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51332 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbdANMxh (ORCPT ); Sat, 14 Jan 2017 07:53:37 -0500 Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips To: David Lechner , devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <1484157171-15571-1-git-send-email-david@lechnology.com> <1484157171-15571-2-git-send-email-david@lechnology.com> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Sat, 14 Jan 2017 12:53:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484157171-15571-2-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/17 17:52, David Lechner wrote: > This adds device tree bindings for the TI ADS7950 family of A/DC chips. > > Signed-off-by: David Lechner This is in of itself good, but we may need to have some deprecated elements to continue supporting what was implicitly happening with the missnaming so as to avoid accidentally breaking someone's device tree. Jonathan > --- > .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > new file mode 100644 > index 0000000..e77a6f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > @@ -0,0 +1,23 @@ > +* Texas Instruments ADS7950 family of A/DC chips > + > +Required properties: > + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", > + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", > + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" > + - reg: SPI chip select number for the device > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads7957"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips Date: Sat, 14 Jan 2017 12:53:35 +0000 Message-ID: References: <1484157171-15571-1-git-send-email-david@lechnology.com> <1484157171-15571-2-git-send-email-david@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1484157171-15571-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Lechner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/01/17 17:52, David Lechner wrote: > This adds device tree bindings for the TI ADS7950 family of A/DC chips. > > Signed-off-by: David Lechner This is in of itself good, but we may need to have some deprecated elements to continue supporting what was implicitly happening with the missnaming so as to avoid accidentally breaking someone's device tree. Jonathan > --- > .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > new file mode 100644 > index 0000000..e77a6f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > @@ -0,0 +1,23 @@ > +* Texas Instruments ADS7950 family of A/DC chips > + > +Required properties: > + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", > + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", > + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" > + - reg: SPI chip select number for the device > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads7957"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; >