Re: [LTP] [PATCH v4] Rewrite userns06.c using new LTP API

From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Rewrite userns06.c using new LTP API
Date: Tue, 19 Apr 2022 09:36:12 +0200	[thread overview]
Message-ID: <f1ef4946-7640-07fa-44be-fd3ac13a9695@suse.com> (raw)
In-Reply-To: <Yl5jM+a7yGtVpaIG@pevik>

[-- Attachment #1.1: Type: text/plain, Size: 868 bytes --]

Hi Petr,

sure you can merge. Thanks!

Andrea

On 4/19/22 09:22, Petr Vorel wrote:
> Hi Andrea,
>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
> 2 small things:
>
> Actually adding one more #ifdef HAVE_LIBCAP
> might be better than calling tst_brk() manually (this is better than my previous
> suggestion):
>
> #include "config.h"
>
> #ifdef HAVE_LIBCAP
> # define TST_NO_DEFAULT_MAIN
> #endif
>
> #include "tst_test.h"
>
> #ifdef HAVE_LIBCAP
>
> #include <string.h>
> #include <sys/wait.h>
> #include <sys/capability.h>
>
> int main(int argc, char *argv[])
> {
> ...
> }
>
> #else
> TST_TEST_TCONF("System is missing libcap");
> #endif
>
> But if you prefer to original version (define main), then TCONF should be used.
>
> Also #define _GNU_SOURCE is not needed, it should be dropped.
>
> If you agree, I can merge it with proposed changes.
>
> Kind regards,
> Petr
>

[-- Attachment #1.2: Type: text/html, Size: 1321 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp