From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbdLUPxy (ORCPT ); Thu, 21 Dec 2017 10:53:54 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:40696 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752471AbdLUPxw (ORCPT ); Thu, 21 Dec 2017 10:53:52 -0500 X-Google-Smtp-Source: ACJfBou5RvFrfLh0kDaPH/HUvD5OLi+q8bhq/CDK2x2Dd37ZIjujkK6uL9DcAkJOgzNHWR/vcdVIaQ== Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region To: "Shaikh, Azhar" , Jason Gunthorpe Cc: "linux-kernel@vger.kernel.org" , James Ettle , Hans de Goede , Arnd Bergmann , Jarkko Sakkinen , Peter Huewe , Greg Kroah-Hartman , "linux-integrity@vger.kernel.org" References: <20171220113538.16099-1-javierm@redhat.com> <20171220113538.16099-2-javierm@redhat.com> <20171220180855.GB22908@ziepe.ca> <20171220185458.GE22908@ziepe.ca> <5FFFAD06ADE1CA4381B3F0F7C6AF5828988917@ORSMSX109.amr.corp.intel.com> <5FFFAD06ADE1CA4381B3F0F7C6AF5828988F88@ORSMSX109.amr.corp.intel.com> From: Javier Martinez Canillas Message-ID: Date: Thu, 21 Dec 2017 16:53:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF5828988F88@ORSMSX109.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/2017 04:39 PM, Shaikh, Azhar wrote: > HI Javier, > > >> -----Original Message----- >> From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity- >> owner@vger.kernel.org] On Behalf Of Javier Martinez Canillas >> Sent: Thursday, December 21, 2017 4:49 AM >> To: Shaikh, Azhar ; Jason Gunthorpe >> >> Cc: linux-kernel@vger.kernel.org; James Ettle ; Hans de >> Goede ; Arnd Bergmann ; Jarkko >> Sakkinen ; Peter Huewe >> ; Greg Kroah-Hartman >> ; linux-integrity@vger.kernel.org >> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O >> memory region >> >> Hello Azhar, >> >> On 12/20/2017 08:15 PM, Shaikh, Azhar wrote: >>> >>> >>>> -----Original Message----- >>>> From: Jason Gunthorpe [mailto:jgg@ziepe.ca] >>>> Sent: Wednesday, December 20, 2017 10:55 AM >>>> To: Javier Martinez Canillas >>>> Cc: linux-kernel@vger.kernel.org; James Ettle ; >>>> Hans de Goede ; Shaikh, Azhar >>>> ; Arnd Bergmann ; Jarkko >>>> Sakkinen ; Peter Huewe >>>> ; Greg Kroah-Hartman >> ; >>>> linux- integrity@vger.kernel.org >>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already >>>> unmapped I/O memory region >>>> >>>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote: >>>> >>>>>> The below draft fixes everything except #1. That needs a more >>>>>> thoughtful idea.. >>>>>> >>>>> >>>>> I'll just drop this patch from the series and you can fix all the >>>>> issues in the error / driver removal paths. It's not a dependency >>>>> anyways, I included it just because noticed the issue while reading the >> code. >>>> >>>> Azhar, this means it becomes your problem :) >>>> >>> >>> Sure, I will fix this. >>> Javier you can drop this patch. >>> >> >> On a second though, we should just merge $SUBJECT since is an obvious fix >> for one of the issues. Then you could fix the remaining bugs in error and >> driver removal paths. > > I think you are asking to keep this patch as a part of this series, itself and not upload separately. Is this correct? Please correct me if I am wrong. > Yes, what I meant is that we should just keep this patch in the series since it fixes one of the resource cleanup bugs. Then you can fix the other issues as a follow-up. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat