From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678AFC433E0 for ; Mon, 27 Jul 2020 09:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40AC220786 for ; Mon, 27 Jul 2020 09:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727852AbgG0JzS (ORCPT ); Mon, 27 Jul 2020 05:55:18 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:9833 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgG0JzS (ORCPT ); Mon, 27 Jul 2020 05:55:18 -0400 Received: from [10.193.177.176] (raina-lt.asicdesigners.com [10.193.177.176] (may be forged)) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 06R9suuS003589; Mon, 27 Jul 2020 02:54:56 -0700 Cc: ayush.sawal@asicdesigners.com, David Miller , netdev@vger.kernel.org, secdev@chelsio.com, lkp@intel.com Subject: Re: [PATCH net V2] Crypto/chcr: Registering cxgb4 to xfrmdev_ops To: Steffen Klassert , Herbert Xu References: <20200724084124.21651-1-ayush.sawal@chelsio.com> <20200724.170108.362782113011946610.davem@davemloft.net> <20200725062034.GA19493@gondor.apana.org.au> <20200727091627.GX20687@gauss3.secunet.de> From: Ayush Sawal Message-ID: Date: Mon, 27 Jul 2020 15:29:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091627.GX20687@gauss3.secunet.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/27/2020 2:46 PM, Steffen Klassert wrote: > On Sat, Jul 25, 2020 at 04:20:34PM +1000, Herbert Xu wrote: >> On Fri, Jul 24, 2020 at 05:01:08PM -0700, David Miller wrote: >>> Please start submitting chcr patches to the crypto subsystem, where it >>> belongs, instead of the networking GIT trees. >> Hi Dave: >> >> I think this patch belongs to the networking tree. The reason is >> that it's related to xfrm offload which has nothing to do with the >> Crypto API. > Hm, I think some of this code is just misplaced under drivers/crypto. > All functions in 'drivers/crypto/chelsio/chcr_ipsec.c' implement > networking (IPsec). So it should be under drivers/net, then it > can be merged via the net or net-next tree as usual for network > drivers. Ok, We have started the work towards shifting inline ipsec, nic tls & chtls code present in drivers/crypto/chelsio/ into drivers/net/ethernet/chelsio/. Only co-processor code will exist in the drivers/crypto/chelsio directory. Thanks, Ayush >> Do xfrm offload drivers usually go through the networking tree or >> would it be better directed through the xfrm tree? > The drivers go through the networking trees, and I think it should > stay like this. Otherwise we would create needless merge conflicts. >